Skip to contentSkip to conversation

iio: adc: ina2xx: add INA236 support

PATCH In review Chuang Zhu 3 participants 6 messages Mar 15 – Apr 20 IIO

lore
Share & tools
lore

Chuang Zhu

author
#0 lore raw

PATCH v3 1/1 iio: adc: ina2xx: add INA236 support

The calibration divisor is not directly specified in the datasheet, but can be calculated:

I = Current_LSB * Current
Current = ShuntVoltage * CAL / calibration_divisor CAL = 0.00512 / (Current_LSB * Rshunt) ShuntVoltage = Vshunt / ShuntVoltage_LSB

=> I = (0.00512 / (calibration_divisor*ShuntVoltage_LSB)) * (Vshunt / Rshunt)

Ohm's law, I = Vshunt / Rshunt
=> 0.00512 / (calibration_divisor*ShuntVoltage_LSB) = 1

ShuntVoltage_LSB = 2.5 uV = 0.0000025 V
=> calibration_divisor = 2048

---
 drivers/iio/adc/ina2xx-adc.c | 57 ++++++++++++++++++++++++++++++------
 1 file changed, 48 insertions(+), 9 deletions(-)
drivers/iio/adc/ina2xx-adc.c +48 -9
index 857e1b69d6cd..6a4ee833d12c 100644
@@ -121,7 +121,7 @@ static const struct regmap_config ina2xx_regmap_config = {
 	.volatile_reg = ina2xx_is_volatile_reg,
 };
 
-enum ina2xx_ids { ina219, ina226 };
+enum ina2xx_ids { ina219, ina226, ina236 };
 
 struct ina2xx_config {
 	const char *name;
@@ -175,6 +175,16 @@ static const struct ina2xx_config ina2xx_config[] = {
 		.power_lsb_factor = 25,
 		.chip_id = ina226,
 	},
+	[ina236] = {
+		.name = "ina236",
+		.config_default = INA226_CONFIG_DEFAULT,
+		.calibration_value = 2048,
+		.shunt_voltage_lsb = 2500,
+		.bus_voltage_shift = 0,
+		.bus_voltage_lsb = 1600,
+		.power_lsb_factor = 32,
+		.chip_id = ina236,
+	},
 };
 
 static int ina2xx_read_raw(struct iio_dev *indio_dev,
@@ -499,20 +509,26 @@ static int ina2xx_write_raw(struct iio_dev *indio_dev,
 		break;
 
 	case IIO_CHAN_INFO_INT_TIME:
-		if (chip->config->chip_id == ina226) {
+		switch (chip->config->chip_id) {
+		case ina226:
+		case ina236:
 			if (chan->address == INA2XX_SHUNT_VOLTAGE)
 				ret = ina226_set_int_time_vshunt(chip, val2,
 								 &tmp);
 			else
 				ret = ina226_set_int_time_vbus(chip, val2,
 							       &tmp);
-		} else {
+			break;
+		case ina219:
 			if (chan->address == INA2XX_SHUNT_VOLTAGE)
 				ret = ina219_set_int_time_vshunt(chip, val2,
 								 &tmp);
 			else
 				ret = ina219_set_int_time_vbus(chip, val2,
 							       &tmp);
+			break;
+		default:
+			ret = -EINVAL;
 		}
 		break;
 
@@ -727,14 +743,20 @@ static int ina2xx_conversion_ready(struct iio_dev *indio_dev)
 	 * For now, we do an extra read of the MASK_ENABLE register (INA226)
 	 * resp. the BUS_VOLTAGE register (INA219).
 	 */
-	if (chip->config->chip_id == ina226) {
+	switch (chip->config->chip_id) {
+	case ina226:
+	case ina236:
 		ret = regmap_read(chip->regmap,
 				  INA226_MASK_ENABLE, &alert);
 		alert &= INA226_CVRF;
-	} else {
+		break;
+	case ina219:
 		ret = regmap_read(chip->regmap,
 				  INA2XX_BUS_VOLTAGE, &alert);
 		alert &= INA219_CNVR;
+		break;
+	default:
+		ret = -EINVAL;
 	}
 
 	if (ret < 0)
@@ -998,16 +1020,22 @@ static int ina2xx_probe(struct i2c_client *client)
 	/* Patch the current config register with default. */
 	val = chip->config->config_default;
 
-	if (type == ina226) {
+	switch (type) {
+	case ina226:
+	case ina236:
 		ina226_set_average(chip, INA226_DEFAULT_AVG, &val);
 		ina226_set_int_time_vbus(chip, INA226_DEFAULT_IT, &val);
 		ina226_set_int_time_vshunt(chip, INA226_DEFAULT_IT, &val);
-	} else {
+		break;
+	case ina219:
 		chip->avg = 1;
 		ina219_set_int_time_vbus(chip, INA219_DEFAULT_IT, &val);
 		ina219_set_int_time_vshunt(chip, INA219_DEFAULT_IT, &val);
 		ina219_set_vbus_range_denom(chip, INA219_DEFAULT_BRNG, &val);
 		ina219_set_vshunt_pga_gain(chip, INA219_DEFAULT_PGA, &val);
+		break;
+	default:
+		return -EINVAL;
 	}
 
 	ret = ina2xx_init(chip, val);
@@ -1017,14 +1045,20 @@ static int ina2xx_probe(struct i2c_client *client)
 	}
 
 	indio_dev->modes = INDIO_DIRECT_MODE;
-	if (type == ina226) {
+	switch (type) {
+	case ina226:
+	case ina236:
 		indio_dev->channels = ina226_channels;
 		indio_dev->num_channels = ARRAY_SIZE(ina226_channels);
 		indio_dev->info = &ina226_info;
-	} else {
+		break;
+	case ina219:
 		indio_dev->channels = ina219_channels;
 		indio_dev->num_channels = ARRAY_SIZE(ina219_channels);
 		indio_dev->info = &ina219_info;
+		break;
+	default:
+		return -EINVAL;
 	}
 	indio_dev->name = id ? id->name : chip->config->name;
 
@@ -1057,6 +1091,7 @@ static const struct i2c_device_id ina2xx_id[] = {
 	{ "ina226", ina226 },
 	{ "ina230", ina226 },
 	{ "ina231", ina226 },
+	{ "ina236", ina236 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, ina2xx_id);
@@ -1082,6 +1117,10 @@ static const struct of_device_id ina2xx_of_match[] = {
 		.compatible = "ti,ina231",
 		.data = (void *)ina226
 	},
+	{
+		.compatible = "ti,ina236",
+		.data = (void *)ina236
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, ina2xx_of_match);
Signature · 1 line
2.51.2
maintainer
#1 lore raw
Quoted 9 lines · On Mon, 16 Mar 2026 02:23:04 +0800 Chuang Zhu <[email protected]> wrote:

The calibration divisor is not directly specified in the datasheet, but can be calculated:

I = Current_LSB * Current
Current = ShuntVoltage * CAL / calibration_divisor CAL = 0.00512 / (Current_LSB * Rshunt) ShuntVoltage = Vshunt / ShuntVoltage_LSB

=> I = (0.00512 / (calibration_divisor*ShuntVoltage_LSB)) * (Vshunt / Rshunt)

Quoted 8 lines

Ohm's law, I = Vshunt / Rshunt
=> 0.00512 / (calibration_divisor*ShuntVoltage_LSB) = 1

ShuntVoltage_LSB = 2.5 uV = 0.0000025 V
=> calibration_divisor = 2048

---

No change log? There should be one here so reviewers know what you've updated without having to go look at earlier versions.

I've picked this up with the following diff merged in:

drivers/iio/adc/ina2xx-adc.c +6 -4
index 6a4ee833d12c..dd37109a008a 100644
@@ -748,20 +748,22 @@ static int ina2xx_conversion_ready(struct iio_dev *indio_dev)
        case ina236:
                ret = regmap_read(chip->regmap,
                                  INA226_MASK_ENABLE, &alert);
+               if (ret < 0)
+                       return ret;
+
                alert &= INA226_CVRF;
                break;
        case ina219:
                ret = regmap_read(chip->regmap,
                                  INA2XX_BUS_VOLTAGE, &alert);
+               if (ret < 0)
+                       return ret;
                alert &= INA219_CNVR;
                break;
        default:
-               ret = -EINVAL;
+               return -EINVAL;
        }
 
-       if (ret < 0)
-               return ret;
-
        return !!alert;
 }
 

See below for why. Pushed out as the testing branch of iio.git. Please give it a quick look to check I didn't mess this up!

Thanks,

J

Quoted 34 lines
 drivers/iio/adc/ina2xx-adc.c | 57 ++++++++++++++++++++++++++++++------
 1 file changed, 48 insertions(+), 9 deletions(-)
drivers/iio/adc/ina2xx-adc.c +11 -1
index 857e1b69d6cd..6a4ee833d12c 100644
@@ -121,7 +121,7 @@ static const struct regmap_config ina2xx_regmap_config = {
 	.volatile_reg = ina2xx_is_volatile_reg,
 };
 
-enum ina2xx_ids { ina219, ina226 };
+enum ina2xx_ids { ina219, ina226, ina236 };
 
 struct ina2xx_config {
 	const char *name;
@@ -175,6 +175,16 @@ static const struct ina2xx_config ina2xx_config[] = {
 		.power_lsb_factor = 25,
 		.chip_id = ina226,
 	},
+	[ina236] = {
+		.name = "ina236",
+		.config_default = INA226_CONFIG_DEFAULT,
+		.calibration_value = 2048,
+		.shunt_voltage_lsb = 2500,
+		.bus_voltage_shift = 0,
+		.bus_voltage_lsb = 1600,
+		.power_lsb_factor = 32,
+		.chip_id = ina236,
+	},
 };
 
 static int ina2xx_read_raw(struct iio_dev *indio_dev,

drivers/iio/adc/ina2xx-adc.c static int ina2xx_write_raw(struct iio_dev *indio_dev, · line 509

Quoted 1 line
drivers/iio/adc/ina2xx-adc.c +0 -0
@@ -499,20 +509,26 @@ static int ina2xx_write_raw(struct iio_dev *indio_dev,
 		break;

Side note for follow up patches is this function would benefit a lot from use of guard()

Quoted 28 lines
drivers/iio/adc/ina2xx-adc.c +8 -2
 	case IIO_CHAN_INFO_INT_TIME:
-		if (chip->config->chip_id == ina226) {
+		switch (chip->config->chip_id) {
+		case ina226:
+		case ina236:
 			if (chan->address == INA2XX_SHUNT_VOLTAGE)
 				ret = ina226_set_int_time_vshunt(chip, val2,
 								 &tmp);
 			else
 				ret = ina226_set_int_time_vbus(chip, val2,
 							       &tmp);
-		} else {
+			break;
+		case ina219:
 			if (chan->address == INA2XX_SHUNT_VOLTAGE)
 				ret = ina219_set_int_time_vshunt(chip, val2,
 								 &tmp);
 			else
 				ret = ina219_set_int_time_vbus(chip, val2,
 							       &tmp);
+			break;
+		default:
+			ret = -EINVAL;
 		}
 		break;
 

drivers/iio/adc/ina2xx-adc.c static int ina2xx_conversion_ready(struct iio_dev *indio_dev) · line 751

Quoted 10 lines
drivers/iio/adc/ina2xx-adc.c +3 -1
@@ -727,14 +743,20 @@ static int ina2xx_conversion_ready(struct iio_dev *indio_dev)
 	 * For now, we do an extra read of the MASK_ENABLE register (INA226)
 	 * resp. the BUS_VOLTAGE register (INA219).
 	 */
-	if (chip->config->chip_id == ina226) {
+	switch (chip->config->chip_id) {
+	case ina226:
+	case ina236:
 		ret = regmap_read(chip->regmap,
 				  INA226_MASK_ENABLE, &alert);
 		alert &= INA226_CVRF;

Not caused by your patch as it's existing code but it's really ugly to check for an error only after modifying data that, if there is an error would be uninitialized.

Can we clean that up whilst here by bringing duplicating the if (ret < 0) and pulling it into these case blocks?

drivers/iio/adc/ina2xx-adc.c static int ina2xx_conversion_ready(struct iio_dev *indio_dev) · line 759

Quoted 9 lines
drivers/iio/adc/ina2xx-adc.c +5 -1
-	} else {
+		break;
+	case ina219:
 		ret = regmap_read(chip->regmap,
 				  INA2XX_BUS_VOLTAGE, &alert);
 		alert &= INA219_CNVR;
+		break;
+	default:
+		ret = -EINVAL;

This might as well return after moving if (ret < 0) into the other two.

(as noted above, i just did this whilst applying your patch).

Quoted 3 lines
drivers/iio/adc/ina2xx-adc.c +0 -0
 	}
 
 	if (ret < 0)
#2 lore raw
In reply to Chuang Zhu
Quoted 19 lines · Chuang Zhu

The calibration divisor is not directly specified in the datasheet, but can be calculated:

I = Current_LSB * Current
Current = ShuntVoltage * CAL / calibration_divisor CAL = 0.00512 / (Current_LSB * Rshunt) ShuntVoltage = Vshunt / ShuntVoltage_LSB

=> I = (0.00512 / (calibration_divisor*ShuntVoltage_LSB)) * (Vshunt / Rshunt)

Ohm's law, I = Vshunt / Rshunt
=> 0.00512 / (calibration_divisor*ShuntVoltage_LSB) = 1

ShuntVoltage_LSB = 2.5 uV = 0.0000025 V
=> calibration_divisor = 2048

drivers/iio/adc/ina2xx-adc.c static const struct of_device_id ina2xx_of_match[] = { · line 1121

Quoted 5 lines
drivers/iio/adc/ina2xx-adc.c +2 -0
@@ -1082,6 +1117,10 @@ static const struct of_device_id ina2xx_of_match[] = {
 		.compatible = "ti,ina231",
 		.data = (void *)ina226
 	},
+	{
+		.compatible = "ti,ina236",

This is not documented. Please add/extend a binding for it.

Rob

maintainer
#3 lore raw
Quoted 19 lines · On Wed, 8 Apr 2026 10:55:20 -0500 Rob Herring <[email protected]> wrote:
Quoted 16 lines · Chuang Zhu

The calibration divisor is not directly specified in the datasheet, but can be calculated:

I = Current_LSB * Current
Current = ShuntVoltage * CAL / calibration_divisor CAL = 0.00512 / (Current_LSB * Rshunt) ShuntVoltage = Vshunt / ShuntVoltage_LSB

=> I = (0.00512 / (calibration_divisor*ShuntVoltage_LSB)) * (Vshunt / Rshunt)

Ohm's law, I = Vshunt / Rshunt
=> 0.00512 / (calibration_divisor*ShuntVoltage_LSB) = 1

ShuntVoltage_LSB = 2.5 uV = 0.0000025 V
=> calibration_divisor = 2048

Quoted 8 lines

drivers/iio/adc/ina2xx-adc.c static const struct of_device_id ina2xx_of_match[] = { · line 1121

Quoted 6 lines
drivers/iio/adc/ina2xx-adc.c +2 -0
@@ -1082,6 +1117,10 @@ static const struct of_device_id ina2xx_of_match[] = {
 		.compatible = "ti,ina231",
 		.data = (void *)ina226
 	},
+	{
+		.compatible = "ti,ina236",  

This is not documented. Please add/extend a binding for it.

Good point. I missed that.

As this has gone upstream now, follow up patch please.

Jonathan

Quoted 2 lines

Rob

author
#4 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

drivers/iio/adc/ina2xx-adc.c static const struct of_device_id ina2xx_of_match[] = { · line 1121

Quoted 6 lines
drivers/iio/adc/ina2xx-adc.c +2 -0
@@ -1082,6 +1117,10 @@ static const struct of_device_id ina2xx_of_match[] = {
  		.compatible = "ti,ina231",
  		.data = (void *)ina226
  	},
+	{
+		.compatible = "ti,ina236",

This is not documented. Please add/extend a binding for it.

There is only a devicetree/bindings/hwmon/ti,ina2xx.yaml, but I only added support for IIO (no HWMON). Should I extend the existing binding regardless?

Thanks,
Chuang

Quoted 1 line

Rob

maintainer
#5 lore raw
Quoted 10 lines · On Sun, 12 Apr 2026 23:21:59 +0800 Chuang Zhu <[email protected]> wrote:
Quoted 8 lines · Rob Herring

drivers/iio/adc/ina2xx-adc.c static const struct of_device_id ina2xx_of_match[] = { · line 1121

Quoted 6 lines
drivers/iio/adc/ina2xx-adc.c +2 -0
@@ -1082,6 +1117,10 @@ static const struct of_device_id ina2xx_of_match[] = {
  		.compatible = "ti,ina231",
  		.data = (void *)ina226
  	},
+	{
+		.compatible = "ti,ina236",  

This is not documented. Please add/extend a binding for it.

Quoted 4 lines

There is only a devicetree/bindings/hwmon/ti,ina2xx.yaml, but I only added support for IIO (no HWMON). Should I extend the existing binding regardless?

Good question. Given no DT maintainer reply (most aren't in +CC) I'd go for it and see if you get push back.

J

Quoted 5 lines

Thanks,
Chuang

Quoted 1 line

Rob