Skip to contentSkip to conversation

iio: light: Add driver for PixArt PAJ7620

PATCH In review Harpreet Saini 2 participants 2 messages Apr 13 1 message not in the archive IIO

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 iio: light: Add driver for PixArt PAJ7620

---
This is part 2 of a 2-patch series proposing a driver for the PixArt PAJ7620 gesture sensor. This patch adds the actual C driver, Kconfig hooks, and Makefile integrations. The device tree bindings were submitted in the preceding patch.

 drivers/iio/light/Kconfig   |   7 +
 drivers/iio/light/Makefile  |   1 +
 drivers/iio/light/paj7620.c | 433 ++++++++++++++++++++++++++++++++++++
 3 files changed, 441 insertions(+)
 create mode 100644 drivers/iio/light/paj7620.c
drivers/iio/light/Kconfig +7 -0
index ac1408d374c9..71c1dd76683e 100644
@@ -520,6 +520,13 @@ config PA12203001
 	  This driver can also be built as a module.  If so, the module
 	  will be called pa12203001.
 
+config PAJ7620
+	tristate "PixArt PAJ7620 Gesture Sensor"
+	depends on I2C
+	select REGMAP_I2C
+	help
+	  Say Y here to build support for the PixArt PAJ7620 gesture sensor.
+
 config SI1133
 	tristate "SI1133 UV Index Sensor and Ambient Light Sensor"
 	depends on I2C
drivers/iio/light/Makefile +1 -0
index c0048e0d5ca8..9b1d2119afc9 100644
@@ -46,6 +46,7 @@ obj-$(CONFIG_OPT3001)		+= opt3001.o
 obj-$(CONFIG_OPT4001)		+= opt4001.o
 obj-$(CONFIG_OPT4060)		+= opt4060.o
 obj-$(CONFIG_PA12203001)	+= pa12203001.o
+obj-$(CONFIG_PAJ7620)		+= paj7620.o
 obj-$(CONFIG_ROHM_BU27034)	+= rohm-bu27034.o
 obj-$(CONFIG_RPR0521)		+= rpr0521.o
 obj-$(CONFIG_SI1133)		+= si1133.o
drivers/iio/light/paj7620.c new file +433 -0

433 lines not on this page · raw message

Signature · 1 line
2.43.0
reviewer
#2 lore raw
Quoted 6 lines · Harpreet Saini

---
This is part 2 of a 2-patch series proposing a driver for the PixArt PAJ7620 gesture sensor. This patch adds the actual C driver, Kconfig hooks, and Makefile integrations. The device tree bindings were submitted in the preceding patch.

Patches should be combined into a series with a cover letter.

The cover letter should explain clearly why this should be considered for the IIO subsystem instead of the input subsystem. It doesn't seem like there is a valid justification though.

Quoted 6 lines
 drivers/iio/light/Kconfig   |   7 +
 drivers/iio/light/Makefile  |   1 +
 drivers/iio/light/paj7620.c | 433 ++++++++++++++++++++++++++++++++++++
 3 files changed, 441 insertions(+)
 create mode 100644 drivers/iio/light/paj7620.c

There is no IIO_LIGHT channel, so this does not look at all like a light sensor.