Skip to contentSkip to conversation

mm/memblock: fix off-by-one page leak in reserve_mem_release_by_name()

PATCH Superseded DaeMyung Kang 2 participants 5 messages Apr 14

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/memblock: fix off-by-one page leak in reserve_mem_release_by_name()

free_reserved_area() treats its 'end' argument as exclusive: it aligns end down via 'end & PAGE_MASK' and iterates with 'pos < end'.

reserve_mem_release_by_name() instead passes 'start + map->size - 1', which causes the last page of a page-aligned reservation to never be freed. For a reservation spanning N pages, only N - 1 pages are released back to the allocator.

Fix it by passing the exclusive end address, 'start + map->size'.

---
 mm/memblock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memblock.c +1 -1
index b3ddfdec7a80..d4a02f1750e9 100644
@@ -2434,7 +2434,7 @@ int reserve_mem_release_by_name(const char *name)
 		return 0;
 
 	start = phys_to_virt(map->start);
-	end = start + map->size - 1;
+	end = start + map->size;
 	snprintf(buf, sizeof(buf), "reserve_mem:%s", name);
 	free_reserved_area(start, end, 0, buf);
 	map->size = 0;
Signature · 1 line
2.43.0
#1 lore raw

Hi

Quoted 11 lines · DaeMyung Kang

free_reserved_area() treats its 'end' argument as exclusive: it aligns end down via 'end & PAGE_MASK' and iterates with 'pos < end'.

reserve_mem_release_by_name() instead passes 'start + map->size - 1', which causes the last page of a page-aligned reservation to never be freed. For a reservation spanning N pages, only N - 1 pages are released back to the allocator.

Fix it by passing the exclusive end address, 'start + map->size'.

Do we need a fixes tag?

-Donet

Quoted 17 lines
---
  mm/memblock.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
mm/memblock.c +1 -1
index b3ddfdec7a80..d4a02f1750e9 100644
@@ -2434,7 +2434,7 @@ int reserve_mem_release_by_name(const char *name)
  		return 0;
 
  	start = phys_to_virt(map->start);
-	end = start + map->size - 1;
+	end = start + map->size;
  	snprintf(buf, sizeof(buf), "reserve_mem:%s", name);
  	free_reserved_area(start, end, 0, buf);
  	map->size = 0;
#2 lore raw

PATCH v2 1/1 mm/memblock: fix off-by-one page leak in reserve_mem_release_by_name()

In reply to DaeMyung Kang

free_reserved_area() treats its 'end' argument as exclusive: it aligns end down via 'end & PAGE_MASK' and iterates with 'pos < end'.

reserve_mem_release_by_name() instead passes 'start + map->size - 1', which causes the last page of a page-aligned reservation to never be freed. For a reservation spanning N pages, only N - 1 pages are released back to the allocator.

Fix it by passing the exclusive end address, 'start + map->size'.

Fixes 74e2498ccf7b ("mm/memblock: Add reserved memory release function")

---
Changes in v2:
- Add Fixes: tag and Cc: stable (per Donet Tom's review).
- v1: https://lore.kernel.org/lkml/

 mm/memblock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memblock.c +1 -1
index b3ddfdec7a80..d4a02f1750e9 100644
@@ -2434,7 +2434,7 @@ int reserve_mem_release_by_name(const char *name)
 		return 0;
 
 	start = phys_to_virt(map->start);
-	end = start + map->size - 1;
+	end = start + map->size;
 	snprintf(buf, sizeof(buf), "reserve_mem:%s", name);
 	free_reserved_area(start, end, 0, buf);
 	map->size = 0;
Signature · 1 line
2.43.0
Reviewed-by on v2 1/1
#3 lore raw

Hi

Quoted 8 lines · DaeMyung Kang

free_reserved_area() treats its 'end' argument as exclusive: it aligns end down via 'end & PAGE_MASK' and iterates with 'pos < end'.

reserve_mem_release_by_name() instead passes 'start + map->size - 1', which causes the last page of a page-aligned reservation to never be freed. For a reservation spanning N pages, only N - 1 pages are released back to the allocator.

Quoted 5 lines

Fix it by passing the exclusive end address, 'start + map->size'.

Fixes 74e2498ccf7b ("mm/memblock: Add reserved memory release function")

I think it might be better to send v2 as a separate patch  rather than as a reply to the previous version.

This patch looks good to me.

-Donet

Quoted 21 lines

---
Changes in v2:
- Add Fixes: tag and Cc: stable (per Donet Tom's review).
- v1: https://lore.kernel.org/lkml/

  mm/memblock.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
mm/memblock.c +1 -1
index b3ddfdec7a80..d4a02f1750e9 100644
@@ -2434,7 +2434,7 @@ int reserve_mem_release_by_name(const char *name)
  		return 0;
 
  	start = phys_to_virt(map->start);
-	end = start + map->size - 1;
+	end = start + map->size;
  	snprintf(buf, sizeof(buf), "reserve_mem:%s", name);
  	free_reserved_area(start, end, 0, buf);
  	map->size = 0;
author
#4 lore raw

Please disregard this patch -- I just noticed the same fix is already in linux-next as commit c12c3e150780 ("memblock: reserve_mem: fix end caclulation in reserve_mem_release_by_name()") by Mike Rapoport.

Sorry for the noise.

Thanks,
DaeMyung

2026년 4월 14일 (화) 오후 8:13, Donet Tom <[email protected]>님이 작성:

Quoted 50 lines

Hi

Quoted 8 lines · DaeMyung Kang

free_reserved_area() treats its 'end' argument as exclusive: it aligns end down via 'end & PAGE_MASK' and iterates with 'pos < end'.

reserve_mem_release_by_name() instead passes 'start + map->size - 1', which causes the last page of a page-aligned reservation to never be freed. For a reservation spanning N pages, only N - 1 pages are released back to the allocator.

Quoted 5 lines

Fix it by passing the exclusive end address, 'start + map->size'.

Fixes 74e2498ccf7b ("mm/memblock: Add reserved memory release function")

I think it might be better to send v2 as a separate patch rather than as a reply to the previous version.

This patch looks good to me.

-Donet

Quoted 21 lines

---
Changes in v2:
- Add Fixes: tag and Cc: stable (per Donet Tom's review).
- v1: https://lore.kernel.org/lkml/

  mm/memblock.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
mm/memblock.c +1 -1
index b3ddfdec7a80..d4a02f1750e9 100644
@@ -2434,7 +2434,7 @@ int reserve_mem_release_by_name(const char *name)
              return 0;
 
      start = phys_to_virt(map->start);
-     end = start + map->size - 1;
+     end = start + map->size;
      snprintf(buf, sizeof(buf), "reserve_mem:%s", name);
      free_reserved_area(start, end, 0, buf);
      map->size = 0;