Skip to contentSkip to conversation

arm64: dts: qcom: qrb2210-rb1: Drop modem support

PATCH In review Sumit Garg 3 participants 7 messages Apr 27 – May 1

Subsystems (3)
lore
Share & tools
lore

Sumit Garg

author
#0 lore raw

PATCH 1/2 arm64: dts: qcom: qrb2210-rb1: Drop modem support

From: Sumit Garg <[email protected]>

QRB2210 has modem fused out as it's only available on the mobile variant which is QCM2290. So let's disable modem support from RB1.

---
 arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 5 -----
 1 file changed, 5 deletions(-)
arch/arm64/boot/dts/qcom/qrb2210-rb1.dts +0 -5
index da46e9d65528..7c5e0cf18131 100644
@@ -453,11 +453,6 @@ &remoteproc_adsp {
 	status = "okay";
 };
 
-&remoteproc_mpss {
-	firmware-name = "qcom/qcm2290/modem.mbn";
-	status = "okay";
-};
-
 &rpm_requests {
 	regulators {
 		compatible = "qcom,rpm-pm2250-regulators";
Signature · 1 line
2.51.0
author
#1 lore raw

PATCH 2/2 arm64: dts: qcom: qrb2210-arduino-imola: Drop modem support

From: Sumit Garg <[email protected]>

QRB2210 has modem fused out as it's only available on the mobile variant which is QCM2290. So let's disable modem support from Arduino Imola/UNO-Q.

---
 arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 6 ------
 1 file changed, 6 deletions(-)
arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts +0 -6
index 5266f89feaaf..34f8bef222be 100644
@@ -343,12 +343,6 @@ &remoteproc_adsp {
 	status = "okay";
 };
 
-&remoteproc_mpss {
-	firmware-name = "qcom/qcm2290/modem.mbn";
-
-	status = "okay";
-};
-
 &rpm_requests {
 	regulators {
 		compatible = "qcom,rpm-pm2250-regulators";
Signature · 1 line
2.51.0
#2 lore raw

Re: [PATCH 2/2] arm64: dts: qcom: qrb2210-arduino-imola: Drop modem support

Quoted 7 lines · Sumit Garg

From: Sumit Garg <[email protected]>

QRB2210 has modem fused out as it's only available on the mobile variant which is QCM2290. So let's disable modem support from Arduino Imola/UNO-Q.

---

On previous APQ-y SoCs, the remoteproc was still physically present and served various functions (among others, GPS, IIRC). Is that not the case?

Konrad

author
#3 lore raw

Re: [PATCH 2/2] arm64: dts: qcom: qrb2210-arduino-imola: Drop modem support

Quoted 11 lines · Konrad Dybcio
Quoted 7 lines · Sumit Garg

From: Sumit Garg <[email protected]>

QRB2210 has modem fused out as it's only available on the mobile variant which is QCM2290. So let's disable modem support from Arduino Imola/UNO-Q.

---

On previous APQ-y SoCs, the remoteproc was still physically present and served various functions (among others, GPS, IIRC). Is that not the case?

That isn't the case as we hear that modem is fused out on QRB2210. Even the marketing page here [1] suggests to use add-on chip WGR7640 for GNSS.

[1] https://www.qualcomm.com/internet-of-things/products/q2-series/qrb2210

-Sumit

#4 lore raw

Re: [PATCH 2/2] arm64: dts: qcom: qrb2210-arduino-imola: Drop modem support

Quoted 10 lines · Sumit Garg
Quoted 9 lines · Konrad Dybcio
Quoted 7 lines · Sumit Garg

From: Sumit Garg <[email protected]>

QRB2210 has modem fused out as it's only available on the mobile variant which is QCM2290. So let's disable modem support from Arduino Imola/UNO-Q.

---

Quoted 8 lines
Quoted 2 lines

On previous APQ-y SoCs, the remoteproc was still physically present and served various functions (among others, GPS, IIRC). Is that not the case?

That isn't the case as we hear that modem is fused out on QRB2210. Even the marketing page here [1] suggests to use add-on chip WGR7640 for GNSS.

[1] https://www.qualcomm.com/internet-of-things/products/q2-series/qrb2210

I would like you to provide a better source than a marketing page which does not necessarily use 'modem' in the context of 'mpss remoteproc'

The easiest test to conduct is to boot up the device and run qrtr-lookup with and without the rproc.

Or actually, if the rproc succeeds to start up, that's proof enough that it's actually there..

Konrad

#5 lore raw
In reply to Sumit Garg
Quoted 10 lines · Sumit Garg

From: Sumit Garg <[email protected]>

QRB2210 has modem fused out as it's only available on the mobile variant which is QCM2290. So let's disable modem support from RB1.

---
 arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 5 -----
 1 file changed, 5 deletions(-)

No, this is not true. On QCM2290 the modem DSP is being used to download wlan firmware. As such this is wrong.

[    4.186507] remoteproc remoteproc0: modem is available
[   14.811564] remoteproc remoteproc0: powering up modem
[   14.883766] remoteproc remoteproc0: Booting fw image qcom/qcm2290/modem.mbn, size 8881672
[   15.505182] remoteproc remoteproc0: remote processor modem is now up
Signature · 2 lines
With best wishes
Dmitry
author
#6 lore raw
Quoted 6 lines · Dmitry Baryshkov
Quoted 5 lines · Sumit Garg

From: Sumit Garg <[email protected]>

QRB2210 has modem fused out as it's only available on the mobile variant which is QCM2290. So let's disable modem support from RB1.

Quoted 8 lines
Quoted 5 lines
---
 arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 5 -----
 1 file changed, 5 deletions(-)

No, this is not true. On QCM2290 the modem DSP is being used to download wlan firmware. As such this is wrong.

The modem is fused out as per internal PDMs communication but I can see the WLAN dependency which fails to load without modem PIL load. So let's drop this patch-set until there is proper clarity as to why WLAN has a dependency on modem firmware to be loaded.

Quoted 5 lines
[    4.186507] remoteproc remoteproc0: modem is available
[   14.811564] remoteproc remoteproc0: powering up modem
[   14.883766] remoteproc remoteproc0: Booting fw image qcom/qcm2290/modem.mbn, size 8881672
[   15.505182] remoteproc remoteproc0: remote processor modem is now up

-Sumit