Skip to contentSkip to conversation

staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name

PATCH Superseded kernelcoredev 2 participants 2 messages Apr 28

Subsystems (3)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name

The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed.

Remove the FIXME comment and downgrade to dev_dbg as originally intended.

Tested via code inspection only, as Project Ara hardware is no longer available.

---
 drivers/staging/greybus/bootrom.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/staging/greybus/bootrom.c +3 -6
index 83921d90c..757460c8b 100644
@@ -168,12 +168,9 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
 		 intf->ddbl1_manufacturer_id, intf->ddbl1_product_id,
 		 intf->vendor_id, intf->product_id);
 
-	// FIXME:
-	// Turn to dev_dbg later after everyone has valid bootloaders with good
-	// ids, but leave this as dev_info for now to make it easier to track
-	// down "empty" vid/pid modules.
-	dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n",
-		 firmware_name);
+
+    dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n",
+	    firmware_name);
 
 	rc = request_firmware(&bootrom->fw, firmware_name,
 			      &connection->bundle->dev);
Signature · 1 line
2.54.0
#1 lore raw
Quoted 9 lines · kernelcoredev

The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed.

Remove the FIXME comment and downgrade to dev_dbg as originally intended.

Tested via code inspection only, as Project Ara hardware is no longer available.

Put this meta commentary

Quoted 3 lines

---

^^^
Under the --- cut off line.

Quoted 10 lines
 drivers/staging/greybus/bootrom.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/staging/greybus/bootrom.c +0 -0
index 83921d90c..757460c8b 100644
@@ -168,12 +168,9 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
 		 intf->ddbl1_manufacturer_id, intf->ddbl1_product_id,
 		 intf->vendor_id, intf->product_id);

drivers/staging/greybus/bootrom.c static int find_firmware(struct gb_bootrom *bootrom, u8 stage) · line 173

Quoted 10 lines
drivers/staging/greybus/bootrom.c +3 -6
 
-	// FIXME:
-	// Turn to dev_dbg later after everyone has valid bootloaders with good
-	// ids, but leave this as dev_info for now to make it easier to track
-	// down "empty" vid/pid modules.
-	dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n",
-		 firmware_name);
+
+    dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n",
+	    firmware_name);

Please run your patches through checkpatch.pl.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter

Quoted 6 lines
drivers/staging/greybus/bootrom.c +0 -0
 	rc = request_firmware(&bootrom->fw, firmware_name,
 			      &connection->bundle->dev);
Signature · 1 line
2.54.0