Skip to contentSkip to conversation

drm/bridge: analogix_dp: Extract error pointer from correct variable

PATCH Applied Ethan Tidmore 3 participants 4 messages Apr 29 – May 4

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: analogix_dp: Extract error pointer from correct variable

In devm_drm_panel_bridge_add() error path the pointer error should be extracted from dp->plat_data->next_bridge but instead it is extracted from bridge, which is a valid pointer and not part of this error path.

Extract error pointer from correct variable.

Detected by Smatch:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
warn: passing a valid pointer to 'PTR_ERR'

Fixes 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper")
---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +1 -1
index 460729fdcecd..3e46350170d4 100644
@@ -1486,7 +1486,7 @@ int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev)
 		dp->plat_data->next_bridge = devm_drm_panel_bridge_add(dp->dev,
 								       dp->plat_data->panel);
 		if (IS_ERR(dp->plat_data->next_bridge)) {
-			ret = PTR_ERR(bridge);
+			ret = PTR_ERR(dp->plat_data->next_bridge);
 			goto err_unregister_aux;
 		}
 	}
Signature · 1 line
2.54.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Ethan Tidmore

In devm_drm_panel_bridge_add() error path the pointer error should be extracted from dp->plat_data->next_bridge but instead it is extracted from bridge, which is a valid pointer and not part of this error path.

Quoted 8 lines

Extract error pointer from correct variable.

Detected by Smatch:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
warn: passing a valid pointer to 'PTR_ERR'

Fixes 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper")

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Reviewed-by
#2 lore raw
Quoted 7 lines · Luca Ceresoli
Quoted 6 lines · Ethan Tidmore

In devm_drm_panel_bridge_add() error path the pointer error should be extracted from dp->plat_data->next_bridge but instead it is extracted from bridge, which is a valid pointer and not part of this error path.

Extract error pointer from correct variable.

Quoted 10 lines
Quoted 6 lines

Detected by Smatch:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
warn: passing a valid pointer to 'PTR_ERR'

Fixes 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper")

Best regards,
Damon

reviewer Applied
#3 lore raw
In reply to Ethan Tidmore
Quoted 11 lines · Ethan Tidmore

In devm_drm_panel_bridge_add() error path the pointer error should be extracted from dp->plat_data->next_bridge but instead it is extracted from bridge, which is a valid pointer and not part of this error path.

Extract error pointer from correct variable.

Detected by Smatch:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
warn: passing a valid pointer to 'PTR_ERR'

[...]

Applied, thanks!

[1/1] drm/bridge: analogix_dp: Extract error pointer from correct variable

      commit: 002ef4dc52dcc1dd0eb1556cffa8f02e2e7edd51

Best regards,

Signature · 1 line
Luca Ceresoli <[email protected]>