drm/bridge: analogix_dp: Extract error pointer from correct variable
Subsystems (3)
PATCH 1/1 drm/bridge: analogix_dp: Extract error pointer from correct variable
In devm_drm_panel_bridge_add() error path the pointer error should be extracted from dp->plat_data->next_bridge but instead it is extracted from bridge, which is a valid pointer and not part of this error path.
Extract error pointer from correct variable.
Detected by Smatch:drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
warn: passing a valid pointer to 'PTR_ERR'
--- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +1 -1
@@ -1486,7 +1486,7 @@ int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev) dp->plat_data->next_bridge =devm_drm_panel_bridge_add (dp->dev, dp->plat_data->panel);if (IS_ERR (dp->plat_data->next_bridge)) { - ret =PTR_ERR (bridge); + ret =PTR_ERR (dp->plat_data->next_bridge); goto err_unregister_aux; } }
Signature · 1 line
2.54.0
Quoted 4 lines · Ethan Tidmore
In
devm_drm_panel_bridge_add()error path the pointer error should be extracted fromdp->plat_data->next_bridgebut instead it is extracted from bridge, which is a valid pointer and not part of this error path.
Quoted 8 lines
Extract error pointer from correct variable.
Detected by Smatch:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489analogix_dp_bind()
warn: passing a valid pointer to 'PTR_ERR'Fixes 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper")Signed-off-by Ethan Tidmore <[email protected]>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Damon Ding
Reviewed-byQuoted 7 lines · Luca Ceresoli
Quoted 6 lines · Ethan Tidmore
In
devm_drm_panel_bridge_add()error path the pointer error should be extracted fromdp->plat_data->next_bridgebut instead it is extracted from bridge, which is a valid pointer and not part of this error path.Extract error pointer from correct variable.
Quoted 10 lines
Quoted 6 lines
Detected by Smatch:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489analogix_dp_bind()
warn: passing a valid pointer to 'PTR_ERR'Fixes 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper")Signed-off-by Ethan Tidmore <[email protected]>Reviewed-by Luca Ceresoli <[email protected]>
Best regards,
Damon
Quoted 11 lines · Ethan Tidmore
In
devm_drm_panel_bridge_add()error path the pointer error should be extracted fromdp->plat_data->next_bridgebut instead it is extracted from bridge, which is a valid pointer and not part of this error path.Extract error pointer from correct variable.
Detected by Smatch:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489analogix_dp_bind()
warn: passing a valid pointer to 'PTR_ERR'[...]
Applied, thanks!
[1/1] drm/bridge: analogix_dp: Extract error pointer from correct variable
commit: 002ef4dc52dcc1dd0eb1556cffa8f02e2e7edd51
Best regards,
Signature · 1 line
Luca Ceresoli <[email protected]>