Skip to contentSkip to conversation

staging: rtl8723bs: remove unnecessary blank lines

PATCH Superseded Stepan Ionichev 3 participants 4 messages May 1 – May 4 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: remove unnecessary blank lines

Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:

CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Please don't use multiple blank lines
CHECK: Blank lines aren't necessary after an open brace '{'

No functional change.

---
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +0 -4
index c70541f95..8edc62752 100644
@@ -120,9 +120,7 @@ u8 rtw_do_join(struct adapter *padapter)
 					pmlmepriv->to_join = false;
 				}
 			}
-
 		}
-
 	}
 
 exit:
@@ -340,7 +338,6 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
 	return true;
 }
 
-
 u8 rtw_set_802_11_disassociate(struct adapter *padapter)
 {
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -417,7 +414,6 @@ u8 rtw_set_802_11_authentication_mode(struct adapter *padapter, enum ndis_802_11
 
 u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep)
 {
-
 	signed int		keyid, res;
 	struct security_priv *psecuritypriv = &(padapter->securitypriv);
 	u8 ret = _SUCCESS;
Signature · 1 line
2.33.0.windows.2
#1 lore raw

PATCH v2 1/1 staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c

Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:

CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'

No functional change.

---
v2:
- Rebased onto staging-next.
- Dropped the hunk between rtw_set_802_11_infrastructure_mode() and rtw_set_802_11_disassociate(): already addressed by commit 7dbc9fd71438 ("staging: rtl8723bs: remove multiple blank lines in core/").
- Narrowed subject to mention rtw_ioctl_set.c, since the wider scope is no longer needed.

 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +0 -3
index 69cbf89f0..3cc2a7c9d 100644
@@ -120,9 +120,7 @@ u8 rtw_do_join(struct adapter *padapter)
 					pmlmepriv->to_join = false;
 				}
 			}
-
 		}
-
 	}
 
 exit:
@@ -416,7 +414,6 @@ u8 rtw_set_802_11_authentication_mode(struct adapter *padapter, enum ndis_802_11
 
 u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep)
 {
-
 	signed int		keyid, res;
 	struct security_priv *psecuritypriv = &(padapter->securitypriv);
 	u8 ret = _SUCCESS;
Signature · 1 line
2.33.0.windows.2
Reviewed-by on v2 1/1
#2 lore raw

Re: [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c

Quoted 8 lines · Stepan Ionichev

Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:

CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'

No functional change.

Looks good to me.

Thanks,
Nikolay

Reviewed-by on v2 1/1
#3 lore raw

Re: [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c

In reply to Stepan Ionichev
Quoted 17 lines · Stepan Ionichev

Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:

CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'

No functional change.

---
v2:
- Rebased onto staging-next.
- Dropped the hunk between rtw_set_802_11_infrastructure_mode() and rtw_set_802_11_disassociate(): already addressed by commit 7dbc9fd71438 ("staging: rtl8723bs: remove multiple blank lines in core/").
- Narrowed subject to mention rtw_ioctl_set.c, since the wider scope is no longer needed.

Quoted 3 lines

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ---

1 file changed, 3 deletions(-)

LGTM,

Best regards,
Luka Gejak