staging: rtl8723bs: remove unnecessary blank lines
PATCH 1/1 staging: rtl8723bs: remove unnecessary blank lines
Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Please don't use multiple blank lines
CHECK: Blank lines aren't necessary after an open brace '{'
No functional change.
--- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +0 -4
@@ -120,9 +120,7 @@ u8 rtw_do_join(struct adapter *padapter) pmlmepriv->to_join = false; } } - } - } exit:
@@ -340,7 +338,6 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,return true; } -u8 rtw_set_802_11_disassociate (struct adapter *padapter) {struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -417,7 +414,6 @@ u8 rtw_set_802_11_authentication_mode(struct adapter *padapter, enum ndis_802_11u8 rtw_set_802_11_add_wep (struct adapter *padapter,struct ndis_802_11_wep *wep) { -signed int keyid, res;struct security_priv *psecuritypriv = &(padapter->securitypriv);u8 ret = _SUCCESS;
Signature · 1 line
2.33.0.windows.2
PATCH v2 1/1 staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c
Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'
No functional change.
---
v2:
- Rebased onto staging-next.
- Dropped the hunk between rtw_set_802_11_infrastructure_mode() and rtw_set_802_11_disassociate(): already addressed by commit 7dbc9fd71438 ("staging: rtl8723bs: remove multiple blank lines in core/").
- Narrowed subject to mention rtw_ioctl_set.c, since the wider scope is no longer needed.
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +0 -3
@@ -120,9 +120,7 @@ u8 rtw_do_join(struct adapter *padapter) pmlmepriv->to_join = false; } } - } - } exit:
@@ -416,7 +414,6 @@ u8 rtw_set_802_11_authentication_mode(struct adapter *padapter, enum ndis_802_11u8 rtw_set_802_11_add_wep (struct adapter *padapter,struct ndis_802_11_wep *wep) { -signed int keyid, res;struct security_priv *psecuritypriv = &(padapter->securitypriv);u8 ret = _SUCCESS;
Signature · 1 line
2.33.0.windows.2
Re: [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c
Quoted 8 lines · Stepan Ionichev
Drop blank lines flagged by checkpatch.pl in
rtw_ioctl_set.c:CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'No functional change.
Signed-off-by Stepan Ionichev <[email protected]>
Looks good to me.
Thanks,
Nikolay
Re: [PATCH v2] staging: rtl8723bs: remove unnecessary blank lines in rtw_ioctl_set.c
In reply to Stepan IonichevQuoted 17 lines · Stepan Ionichev
Drop blank lines flagged by checkpatch.pl in
rtw_ioctl_set.c:CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'No functional change.
Signed-off-by Stepan Ionichev <[email protected]>---
v2:
- Rebased onto staging-next.
- Dropped the hunk betweenrtw_set_802_11_infrastructure_mode()andrtw_set_802_11_disassociate(): already addressed by commit7dbc9fd71438("staging: rtl8723bs: remove multiple blank lines in core/").
- Narrowed subject to mentionrtw_ioctl_set.c, since the wider scope is no longer needed.
Quoted 3 lines
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c| 3 ---1 file changed, 3 deletions(-)
LGTM,
Best regards,
Luka Gejak