Skip to contentSkip to conversation

shadow-native: Change upstream status of disable_syslog.patch

PATCH Superseded [email protected] 2 participants 4 messages May 7

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 shadow-native: Change upstream status of disable_syslog.patch

From: Dmitry Sakhonchik <[email protected]>

Upstream has accepted configure option and merged it into their master branch.

https://github.com/shadow-maint/shadow/pull/1618

After they release v4.20 we can remove the patch and rewrite recipe with the configure option.

Fixes [YOCTO #15785]

---
 meta/recipes-extended/shadow/files/disable_syslog.patch | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-extended/shadow/files/disable_syslog.patch +2 -1
index 7299a8e61c..7afe0654ae 100644
@@ -2,8 +2,9 @@ When building images using shadow-native, we shouldn't be spamming the host's
 log with lots of syslog messages which aren't relavent. Disable syslog use
 in the native case.
 
-Upstream-Status: Inappropriate [Would upstream accept a configure option?]
+Upstream-Status: Submitted [Merged to upstream's master, waiting for release]
 Signed-off-by: Richard Purdie <[email protected]>
+Signed-off-by: Dmitry Sakhonchik <[email protected]>
 
 Index: shadow-4.17.2/lib/defines.h
 ===================================================================
#1 lore raw
Quoted 1 line · On Thu, 7 May 2026 at 12:24, frezidok1 via lists.openembedded.org…

After they release v4.20 we can remove the patch and rewrite recipe with the configure option.

We don't need to wait for 4.20 to do that. You can replace the patch below with a backport of what was accepted, and then tweak the recipe to use the newly added option.

meta/recipes-extended/shadow/files/disable_syslog.patch When building images using shadow-native, we shouldn't be spamming the host's · line 5

Quoted 2 lines
meta/recipes-extended/shadow/files/disable_syslog.patch +1 -1
-Upstream-Status: Inappropriate [Would upstream accept a configure option?]
+Upstream-Status: Submitted [Merged to upstream's master, waiting for release]

Also this change isn't accurate: the patch that was submitted and merged is not the same as this one. If this patch is kept, then the accurate status would be:

Inappropriate [upstream has accepted a better patch at $link]

Alex

#2 lore raw
Quoted 1 line

You can replace the patch below with a backport of what was accepted

No, I can't do that because the current shadow's master and v4.19.4 (last release) are quite different. I cannot simply cherry-pick my commit and apply it as a patch, the only way to backport is to manually completely recreate these changes for v4.19.4. I have already discussed this topic with Randy ([email protected]), and he advised me that waiting for a stable release (they are promising late June 2026) is better than doing this complex backport.

Though, if required, I don't mind creating a different patch special for v4.19.4 so we can use the new configure option ASAP. But since the shadow recipe will have to be rewritten anyway after v4.20 release, should I? I don't really know what would be better, so I appreciate any opinion.

чт, 7 мая 2026 г. в 14:18, Alexander Kanavin <[email protected]>:

Quoted 22 lines
Quoted 1 line · On Thu, 7 May 2026 at 12:24, frezidok1 via lists.openembedded.org…

After they release v4.20 we can remove the patch and rewrite recipe with

the configure option.

We don't need to wait for 4.20 to do that. You can replace the patch below with a backport of what was accepted, and then tweak the recipe to use the newly added option.

Quoted 1 line

-Upstream-Status: Inappropriate [Would upstream accept a configure

option?]

Quoted 1 line

+Upstream-Status: Submitted [Merged to upstream's master, waiting for

release]

Also this change isn't accurate: the patch that was submitted and merged is not the same as this one. If this patch is kept, then the accurate status would be:

Inappropriate [upstream has accepted a better patch at $link]

Alex

#3 lore raw
Quoted 1 line · Dmitry Sakhonchik

No, I can't do that because the current shadow's master and v4.19.4 (last release) are quite different. I cannot simply cherry-pick my commit and apply it as a patch, the only way to backport is to manually completely recreate these changes for v4.19.4. I have already discussed this topic with Randy ([email protected]), and he advised me that waiting for a stable release (they are promising late June 2026) is better than doing this complex backport.

This is fine too. Then you just need to update the upstream status of the existing patch as suggested.

Alex