iio: adc: ad7192: replace usleep_range() with fsleep()
Subsystems (3)
PATCH v3 1/1 iio: adc: ad7192: replace usleep_range() with fsleep()
The AD7192 datasheet (Rev. A, page 34, RESET section) says:
"When a reset is initiated, the user must allow a period of 500 us before accessing any of the on-chip registers."
fsleep(500) expands to the same usleep_range(500, 1000) and keeps the 500 us minimum.
Drop the redundant "/* Wait for at least 500us */" comment.
No functional change.
---
v3:
- Cite AD7192 datasheet for the 500 us minimum (per Andy)
- Add this changelog (was missing in v2)
v2:
- Drop the redundant "Wait for at least 500us" comment
drivers/iio/adc/ad7192.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7192.c +1 -1
@@ -576,7 +576,7 @@ static int ad7192_setup(struct iio_dev *indio_dev, struct device *dev) ret =ad_sd_reset (&st->sd);if (ret <0 )return ret; -usleep_range (500 ,1000 );/* Wait for at least 500us */ +fsleep (500 );/* write/read test for device presence */ ret =ad_sd_read_reg (&st->sd,AD7192_REG_ID ,1 , &id);
Signature · 1 line
2.43.0
Quoted 10 lines · Stepan Ionichev
The AD7192 datasheet (Rev. A, page 34, RESET section) says:
"When a reset is initiated, the user must allow a period of 500 us before accessing any of the on-chip registers."fsleep(500) expands to the same
usleep_range(500, 1000)and keeps the 500 us minimum.Drop the redundant "/* Wait for at least 500us */" comment.
No functional change.
Same comment as per other patch.
Quoted 4 lines
Signed-off-by Stepan Ionichev <[email protected]>---
v3:
- Cite AD7192 datasheet for the 500 us minimum (per Andy)
To have it in the code comment is much more important.
Quoted 1 line
- Add this changelog (was missing in v2)
...
drivers/iio/adc/ad7192.c static int ad7192_setup(struct iio_dev *indio_dev, struct device *dev) · line 578
Quoted 2 lines
drivers/iio/adc/ad7192.c +0
-0if (ret <0 )return ret;
+ blank line
+ comment as per datasheet
Quoted 2 lines
drivers/iio/adc/ad7192.c +1
-1-usleep_range (500 ,1000 );/* Wait for at least 500us */ +fsleep (500 );
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v4 1/1 iio: adc: ad7192: replace usleep_range() with fsleep()
In reply to Stepan IonichevThe AD7192 datasheet (Rev. A, page 34, RESET section) says:
"When a reset is initiated, the user must allow a period of 500 us before accessing any of the on-chip registers."
Use fsleep(500) instead of usleep_range(500, 1000). The 500 us minimum stays the same; fsleep() picks the upper slack itself (about +25% on a default config).
Add a code comment with the datasheet reference so the "why" of the wait is visible at the call site.
---
v4:
- Move the datasheet citation into a code comment (per Andy)
- Add a blank line before the fsleep call (per Andy)
- Drop the "No functional change" claim — fsleep's upper bound is about +25%, narrower than the original usleep_range(500, 1000)
v3:
- Cite AD7192 datasheet for the 500 us minimum
- Add changelog (was missing in v2)
v2:
- Drop the redundant "Wait for at least 500us" comment
drivers/iio/adc/ad7192.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/iio/adc/ad7192.c +6 -1
@@ -576,7 +576,12 @@ static int ad7192_setup(struct iio_dev *indio_dev, struct device *dev) ret =ad_sd_reset (&st->sd);if (ret <0 )return ret; -usleep_range (500 ,1000 );/* Wait for at least 500us */ + +/* +* Per AD7192 datasheet (Rev. A, page 34, RESET section), allow +* 500 us after a reset before accessing on-chip registers. +*/ +fsleep (500 );/* write/read test for device presence */ ret =ad_sd_read_reg (&st->sd,AD7192_REG_ID ,1 , &id);
Signature · 1 line
2.43.0
Quoted 7 lines · Stepan Ionichev
The AD7192 datasheet (Rev. A, page 34, RESET section) says:
"When a reset is initiated, the user must allow a period of 500 us before accessing any of the on-chip registers."Use fsleep(500) instead of
usleep_range(500, 1000). The 500 us minimum stays the same;fsleep()picks the upper slack itself (about +25% on a default config).
The second sentence here...
Quoted 2 lines
Add a code comment with the datasheet reference so the "why" of the wait is visible at the call site.
...and this paragraph are unneeded details.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Jonathan Cameron
maintainerQuoted 9 lines · On Mon, 11 May 2026 16:28:39 +0300 Andy Shevchenko…
Quoted 7 lines · Stepan Ionichev
The AD7192 datasheet (Rev. A, page 34, RESET section) says:
"When a reset is initiated, the user must allow a period of 500 us before accessing any of the on-chip registers."Use fsleep(500) instead of
usleep_range(500, 1000). The 500 us minimum stays the same;fsleep()picks the upper slack itself (about +25% on a default config).
Quoted 9 lines
The second sentence here...
Quoted 2 lines
Add a code comment with the datasheet reference so the "why" of the wait is visible at the call site.
...and this paragraph are unneeded details.
Reviewed-by Andy Shevchenko <[email protected]>
Tweaked and applied.