Skip to contentSkip to conversation

iio: adc: ad7192: replace usleep_range() with fsleep()

PATCH Superseded Stepan Ionichev 2 participants 4 messages May 10

Subsystems (3)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: ad7192: replace usleep_range() with fsleep()

The "at least 500us" wait after serial interface reset has no specific upper bound. fsleep(500) expands to the same usleep_range(500, 1000) internally and is the kernel helper for plain "about N microseconds" delays.

No functional change.

---
 drivers/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7192.c +1 -1
index 8b1664f6b..712004ab5 100644
@@ -576,7 +576,7 @@ static int ad7192_setup(struct iio_dev *indio_dev, struct device *dev)
 	ret = ad_sd_reset(&st->sd);
 	if (ret < 0)
 		return ret;
-	usleep_range(500, 1000); /* Wait for at least 500us */
+	fsleep(500); /* Wait for at least 500us */
 
 	/* write/read test for device presence */
 	ret = ad_sd_read_reg(&st->sd, AD7192_REG_ID, 1, &id);
Signature · 1 line
2.43.0
#1 lore raw
Quoted 6 lines · Stepan Ionichev

The "at least 500us" wait after serial interface reset has no specific upper bound. fsleep(500) expands to the same usleep_range(500, 1000) internally and is the kernel helper for plain "about N microseconds" delays.

No functional change.

...

drivers/iio/adc/ad7192.c static int ad7192_setup(struct iio_dev *indio_dev, struct device *dev) · line 579

Quoted 2 lines
drivers/iio/adc/ad7192.c +1 -1
-	usleep_range(500, 1000); /* Wait for at least 500us */
+	fsleep(500); /* Wait for at least 500us */

This is useless comment, I can see it from the code. Better comment to explain "why?" and ideally with a reference to a datasheet.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

PATCH v2 1/1 iio: adc: ad7192: replace usleep_range() with fsleep()

In reply to Stepan Ionichev

The "at least 500us" wait after serial interface reset has no specific upper bound. fsleep(500) expands to the same usleep_range(500, 1000) internally.

Drop the trailing "/* Wait for at least 500us */" comment which just restated the previous arguments.

No functional change.

---
 drivers/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7192.c +1 -1
index 8b1664f6b..6bd9cdaa6 100644
@@ -576,7 +576,7 @@ static int ad7192_setup(struct iio_dev *indio_dev, struct device *dev)
 	ret = ad_sd_reset(&st->sd);
 	if (ret < 0)
 		return ret;
-	usleep_range(500, 1000); /* Wait for at least 500us */
+	fsleep(500);
 
 	/* write/read test for device presence */
 	ret = ad_sd_read_reg(&st->sd, AD7192_REG_ID, 1, &id);
Signature · 1 line
2.43.0
#3 lore raw
Quoted 11 lines · Stepan Ionichev

The "at least 500us" wait after serial interface reset has no specific upper bound. fsleep(500) expands to the same usleep_range(500, 1000) internally.

Drop the trailing "/* Wait for at least 500us */" comment which just restated the previous arguments.

No functional change.

---

You missed a changelog here.

Quoted 1 line
 1 file changed, 1 insertion(+), 1 deletion(-)

...

drivers/iio/adc/ad7192.c static int ad7192_setup(struct iio_dev *indio_dev, struct device *dev) · line 579

Quoted 2 lines
drivers/iio/adc/ad7192.c +1 -1
-	usleep_range(500, 1000); /* Wait for at least 500us */
+	fsleep(500);

Have you checked the datasheet? What does it say about this sleep?

Signature · 2 lines
With Best Regards,
Andy Shevchenko