Skip to contentSkip to conversation

staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature

PATCH Superseded Moksh Panicker 3 participants 8 messages May 16 Staging

v1 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature

Reformat multi-line function signature to a single line to fix line length and coding style warnings from checkpatch.pl.

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +1 -4
index 803a608b74fa..987d05816c5c 100644
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
  * 09/23/2008	MHC		Copy from WMAC.
  *
  */
-u8
-rtw_efuse_read_1_byte(
-struct adapter *Adapter,
-u16		Address)
+u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 {
 	u8 Bytetemp = {0x00};
 	u8 temp = {0x00};
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/4 staging: rtl8723bs: add braces to else clause in rtw_efuse.c

Add missing braces to the else clause to satisfy the coding style requirement that both arms of an if/else statement use braces.

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +1 -1
index 987d05816c5c..2be74f2d4ac8 100644
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 				break;
 		}
 		return rtw_read8(Adapter, EFUSE_CTRL);
-	} else
+	} else {
 		return 0xFF;
 
 } /* rtw_efuse_read_1_byte */
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

Quoted 13 lines · Moksh Panicker

Add missing braces to the else clause to satisfy the coding style requirement that both arms of an if/else statement use braces.

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +0 -0
index 987d05816c5c..2be74f2d4ac8 100644

drivers/staging/rtl8723bs/core/rtw_efuse.c u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address) · line 79

Quoted 8 lines
drivers/staging/rtl8723bs/core/rtw_efuse.c +1 -1
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 				break;
 		}
 		return rtw_read8(Adapter, EFUSE_CTRL);
-	} else
+	} else {
 		return 0xFF;
 
 } /* rtw_efuse_read_1_byte */

Always compile test your code. Also why did you send this patch twice?

regards,
dan carpenter

#3 lore raw

Re: [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

Hi Dan,

Apologies for sending it twice. That was due to a mistake in my send workflow which I have since corrected. I will make sure to compile test before submitting future patches.

Moksh

Quoted 30 lines · Dan Carpenter
Quoted 13 lines · Moksh Panicker

Add missing braces to the else clause to satisfy the coding style requirement that both arms of an if/else statement use braces.

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +0 -0
index 987d05816c5c..2be74f2d4ac8 100644

drivers/staging/rtl8723bs/core/rtw_efuse.c u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address) · line 79

Quoted 8 lines
drivers/staging/rtl8723bs/core/rtw_efuse.c +1 -1
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
                              break;
              }
              return rtw_read8(Adapter, EFUSE_CTRL);
-     } else
+     } else {
              return 0xFF;
 
 } /* rtw_efuse_read_1_byte */

Always compile test your code. Also why did you send this patch twice?

regards,
dan carpenter

#4 lore raw

Re: [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c

HI Dan,
I have made sure to compile test it before submitting.

Moksh

Quoted 41 lines · Moksh Panicker

Hi Dan,

Apologies for sending it twice. That was due to a mistake in my send workflow which I have since corrected. I will make sure to compile test before submitting future patches.

Moksh

Quoted 30 lines · Dan Carpenter
Quoted 13 lines · Moksh Panicker

Add missing braces to the else clause to satisfy the coding style requirement that both arms of an if/else statement use braces.

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +0 -0
index 987d05816c5c..2be74f2d4ac8 100644

drivers/staging/rtl8723bs/core/rtw_efuse.c u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address) · line 79

Quoted 8 lines
drivers/staging/rtl8723bs/core/rtw_efuse.c +1 -1
@@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
                              break;
              }
              return rtw_read8(Adapter, EFUSE_CTRL);
-     } else
+     } else {
              return 0xFF;
 
 } /* rtw_efuse_read_1_byte */

Always compile test your code. Also why did you send this patch twice?

regards,
dan carpenter

#5 lore raw

PATCH 3/4 staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature

In reply to Moksh Panicker

Reformat multi-line function signature to a single line to fix line length and coding style warnings from checkpatch.pl.

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +1 -5
index 2be74f2d4ac8..ef0cec40d388 100644
@@ -79,11 +79,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 } /* rtw_efuse_read_1_byte */
 
 /*  11/16/2008 MH Read one byte from real Efuse. */
-u8
-rtw_efuse_one_byte_read(
-struct adapter *padapter,
-u16	addr,
-u8	*data)
+u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
 {
 	u32 tmpidx = 0;
 	u8 bResult;
Signature · 1 line
2.34.1
maintainer
#6 lore raw
In reply to Moksh Panicker
Quoted 28 lines · Moksh Panicker

Reformat multi-line function signature to a single line to fix line length and coding style warnings from checkpatch.pl.

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +1 -4
index 803a608b74fa..987d05816c5c 100644
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
  * 09/23/2008	MHC		Copy from WMAC.
  *
  */
-u8
-rtw_efuse_read_1_byte(
-struct adapter *Adapter,
-u16		Address)
+u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 {
 	u8 Bytetemp = {0x00};
 	u8 temp = {0x00};
Signature · 1 line
2.34.1

I only see 3 patches here :(

#7 lore raw

i have sent correct patches with the cover letter

Moksh

Quoted 32 lines · Greg KH
Quoted 25 lines · Moksh Panicker

Reformat multi-line function signature to a single line to fix line length and coding style warnings from checkpatch.pl.

---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +1 -5
index 803a608b74fa..987d05816c5c 100644
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
  * 09/23/2008        MHC             Copy from WMAC.
  *
  */
-u8
-rtw_efuse_read_1_byte(
-struct adapter *Adapter,
-u16          Address)
+u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
 {
      u8 Bytetemp = {0x00};
      u8 temp = {0x00};
--
Quoted 3 lines

2.34.1

I only see 3 patches here :(