Skip to contentSkip to conversation

dmaengine: bestcomm: Enable compile testing

PATCH Superseded Rosen Penev 3 participants 3 messages May 20 – May 22

Subsystems (2)
libata dmaengine

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Rosen Penev

author
#0 lore raw

PATCH 1/1 dmaengine: bestcomm: Enable compile testing

Allow the BestComm DMA engine to be selected for PowerPC compile-test builds.

Make PATA_MPC52xx depend on PPC_BESTCOMM directly so selecting PPC_BESTCOMM_ATA does not bypass the helper dependency.

Assisted-by Codex:GPT-5.5
Signed-off-by Rosen Penev <[email protected]>
---
 drivers/ata/Kconfig          | 2 +-
 drivers/dma/bestcomm/Kconfig | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
drivers/ata/Kconfig +1 -1
index 28ca856ecc75..6e25e9fcadb2 100644
@@ -823,7 +823,7 @@ config PATA_MARVELL
 
 config PATA_MPC52xx
 	tristate "Freescale MPC52xx SoC internal IDE"
-	depends on PPC_MPC52xx && PPC_BESTCOMM
+	depends on PPC_BESTCOMM
 	select PPC_BESTCOMM_ATA
 	help
 	  This option enables support for integrated IDE controller
drivers/dma/bestcomm/Kconfig +1 -2
index 5dd437295964..153b5492c93c 100644
@@ -5,7 +5,7 @@
 
 config PPC_BESTCOMM
 	tristate "Bestcomm DMA engine support"
-	depends on PPC_MPC52xx
+	depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
 	default n
 	select PPC_LIB_RHEAP
 	help

@@ -34,4 +34,3 @@ config PPC_BESTCOMM_GEN_BD
 	depends on PPC_BESTCOMM
 	help
 	  This option enables the support for the GenBD tasks.
-
Signature · 1 line
2.54.0
AI review
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Relaxing the dependency of PATA_MPC52xx causes a link failure on unsupported PowerPC platforms…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Relaxing the dependency of PATA_MPC52xx causes a link failure on unsupported PowerPC platforms under COMPILE_TEST due to an undefined reference. --

commit 950d74a4a60c655a1252de12aa32ba4329c5e07c
Author: Rosen Penev <[email protected]>

dmaengine: bestcomm: Enable compile testing

Allow the BestComm DMA engine to be selected for PowerPC compile-test builds, and update the PATA_MPC52xx dependency to rely directly on PPC_BESTCOMM.

drivers/ata/Kconfig config PATA_MARVELL · line 826

Quoted 10 lines
drivers/ata/Kconfig +1 -1
index fff305ec1e788..462cbb01567c3 100644
@@ -823,7 +823,7 @@ config PATA_MARVELL
 
 config PATA_MPC52xx
 	tristate "Freescale MPC52xx SoC internal IDE"
-	depends on PPC_MPC52xx && PPC_BESTCOMM
+	depends on PPC_BESTCOMM

[Severity: Low]
Will relaxing this dependency introduce a regression on unsupported PowerPC platforms under COMPILE_TEST due to a link failure?

Because PPC_BESTCOMM now allows COMPILE_TEST on any PPC architecture, PATA_MPC52xx can also be built on architectures other than MPC52xx or MPC512x.

However, drivers/ata/pata_mpc52xx.c unconditionally calls mpc5xxx_get_bus_frequency(), which is implemented in arch/powerpc/sysdev/mpc5xxx_clocks.c.

Since mpc5xxx_clocks.c is only compiled when CONFIG_PPC_MPC512x or CONFIG_PPC_MPC52xx is enabled, building this driver on other PowerPC architectures (like PPC64) might result in an undefined reference to mpc5xxx_get_bus_frequency() at link time.

Quoted 1 line
drivers/ata/Kconfig +0 -0
 	select PPC_BESTCOMM_ATA

[ ... ]

Quoted 12 lines
drivers/dma/bestcomm/Kconfig +1 -1
index 5dd437295964d..153b5492c93c7 100644
@@ -5,7 +5,7 @@
 
 config PPC_BESTCOMM
 	tristate "Bestcomm DMA engine support"
-	depends on PPC_MPC52xx
+	depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
 	default n
 	select PPC_LIB_RHEAP
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
build bot
#2 lore raw
In reply to Rosen Penev
kernel test robot noticed the following build errors:

Hi Rosen,

kernel test robot noticed the following build errors:

[auto build test ERROR on vkoul-dmaengine/next]
[also build test ERROR on linus/master v7.1-rc4 next-20260521] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/dmaengine-bestcomm-Enable-compile-testing/20260521-063851
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
patch link:    https://lore.kernel.org/r/20260520223704.39320-1-rosenp%40gmail.com
patch subject: [PATCH] dmaengine: bestcomm: Enable compile testing
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20260522/[email protected]/config)
compiler: powerpc64-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260522/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> ERROR: modpost: "mpc5xxx_fwnode_get_bus_frequency" [drivers/ata/pata_mpc52xx.ko] undefined!

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki