KVM: x86: Introduce has_protected_pmu state for TDX VMs
Subsystems (4)
PATCH v5 1/1 KVM: x86: Introduce has_protected_pmu state for TDX VMs
PMU state for TDX VMs is virtualized by TDX Module [1]. Host has following toggles to control the PMU functionality exposed to TDX VMs:
1) Configure TD_PARAMS to allow guests to use performance monitoring.
2) Restrict the TD to a subset of the PEBS counters if supported.
3) Limit the TD to setup a certain perfmon events using basic/enhanced event filtering.
KVM will need to be enlightened to support these toggles. Introduce has_protected_pmu state to track the pmu state for such scenarios and explicitly set the has_protected_pmu flag for TDX VMs.
If pmu state is protected:
1) Disable KVM's PMU virtualization framework as additional enlightenment is needed within KVM to control/manage the visibility of PMU state to such VMs.
2) Disallow userspace VMM from enabling PMU virtualization state using KVM_CAP_PMU_CAPABILITY.
[1] Section 15.2: https://cdrdv2.intel.com/v1/dl/getContent/733575
---
v4 -> v5:
- Allow userspace to disable PMU virtualization before creating any vcpus inline with existing ABI contract for KVM_CAP_PMU_CAPABILITY.
v4: https://lore.kernel.org/kvm/[email protected]/
arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/vmx/tdx.c | 6 ++++++ arch/x86/kvm/x86.c | 6 +++++- 3 files changed, 12 insertions(+), 1 deletion(-)
arch/x86/include/asm/kvm_host.h +1 -0
@@ -1422,6 +1422,7 @@ struct kvm_arch {bool has_private_mem;bool has_protected_state;bool has_protected_eoi; +bool has_protected_pmu;bool pre_fault_allowed;struct hlist_head *mmu_page_hash;struct list_head active_mmu_pages;
arch/x86/kvm/vmx/tdx.c +6 -0
@@ -638,6 +638,12 @@ int tdx_vm_init(struct kvm *kvm) kvm->arch.has_private_mem = true; kvm->arch.disabled_quirks |=KVM_X86_QUIRK_IGNORE_GUEST_PAT ; +/* +* PMU support is provided by the TDX-Module (if enabled for the VM). +* From KVM's perspective, the VM doesn't have a virtual PMU. +*/ + kvm->arch.has_protected_pmu = true; +/* * Because guest TD is protected, VMM can't parse the instruction in TD. * Instead, guest uses MMIO hypercall. For unmodified device driver,
arch/x86/kvm/x86.c +5 -1
@@ -6909,6 +6909,10 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm,if (!enable_pmu || (cap->args[0 ] & ~KVM_CAP_PMU_VALID_MASK ))break ; +if (kvm->arch.has_protected_pmu && + cap->args[0 ] !=KVM_PMU_CAP_DISABLE ) +break ; +mutex_lock (&kvm->lock);if (!kvm->created_vcpus && !kvm->arch.created_mediated_pmu) { kvm->arch.enable_pmu = !(cap->args[0 ] &KVM_PMU_CAP_DISABLE );
@@ -13375,7 +13379,7 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) kvm->arch.default_tsc_khz = max_tsc_khz ? : tsc_khz; kvm->arch.apic_bus_cycle_ns =APIC_BUS_CYCLE_NS_DEFAULT ; kvm->arch.guest_can_read_msr_platform_info = true; - kvm->arch.enable_pmu = enable_pmu; + kvm->arch.enable_pmu = enable_pmu && !kvm->arch.has_protected_pmu;#if IS_ENABLED (CONFIG_HYPERV )spin_lock_init (&kvm->arch.hv_root_tdp_lock);
Signature · 1 line
2.54.0.746.g67dd491aae-goog
Quoted 8 lines · Vishal Annapurve
PMU state for TDX VMs is virtualized by TDX Module [1]. Host has following toggles to control the PMU functionality exposed to TDX VMs:
1) ConfigureTD_PARAMSto allow guests to use performance monitoring.
2) Restrict the TD to a subset of the PEBS counters if supported.
3) Limit the TD to setup a certain perfmon events using basic/enhanced event filtering.[...]
Applied to kvm-x86 misc, with a heavily modified changelog. Thanks!
[1/1] KVM: x86: Introduce has_protected_pmu state for TDX VMs
https://github.com/kvm-x86/linux/commit/986833d381d2