dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility
Subsystems (3)
PATCH v2 1/1 dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility
From: Zhi Li <[email protected]>
c36069c6f46c added two optional cells to eswin,hsp-sp-csr, but omitted minItems: 4.
As a result, dt-schema implicitly required all 6 cells, which broke backward compatibility with existing 4-cell device trees.
Add minItems: 4 to preserve backward compatibility.
---
Changes in v2:
- Reference c36069c6f46c explicitly instead of "previous change".
- Improve commit message formatting and line wrapping.
- No functional change.
- Link to v1:
https://lore.kernel.org/lkml/[email protected]/ --- Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml +2 -1
@@ -84,7 +84,8 @@ properties: This reference is provided for background information only. $ref: /schemas/types.yaml#/definitions/phandle-array items: - - items: + - minItems: 4 + items: - description: Phandle to HSP(High-Speed Peripheral) device - description: Offset of phy control register for internal or external clock selection
Signature · 1 line
2.25.1
Rob Herring
maintainerQuoted 4 lines · On Mon, Jun 01, 2026 at 11:28:52AM +0800, [email protected] wrote:
From: Zhi Li <[email protected]>
c36069c6f46cadded two optional cells to eswin,hsp-sp-csr, but omitted minItems: 4.
Please run checkpatch.pl and fix the issue it reports with the commit reference.
Quoted 40 lines
As a result, dt-schema implicitly required all 6 cells, which broke backward compatibility with existing 4-cell device trees.
Add minItems: 4 to preserve backward compatibility.
Fixes c36069c6f46c ("dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsets")Reported-by Sashiko AI <[email protected]>Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by Zhi Li <[email protected]>---
Changes in v2:
- Referencec36069c6f46cexplicitly instead of "previous change".
- Improve commit message formatting and line wrapping.
- No functional change.
- Link to v1:https://lore.kernel.org/lkml/[email protected]/ --- Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml +2
-1@@ -84,7 +84,8 @@ properties: This reference is provided for background information only. $ref: /schemas/types.yaml#/definitions/phandle-array items: - - items: + - minItems: 4 + items: - description: Phandle to HSP(High-Speed Peripheral) device - description: Offset of phy control register for internal or external clock selectionSignature · 1 line
2.25.1
Quoted 10 lines
-----Original Messages-----
From: "Rob Herring" <[email protected]>
Send time:Tuesday, 02/06/2026 05:34:06
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], "Krzysztof Kozlowski" <[email protected]>
Subject: Re: [PATCH net v2] dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility
Quoted 9 lines
Quoted 4 lines · On Mon, Jun 01, 2026 at 11:28:52AM +0800, [email protected] wrote:
From: Zhi Li <[email protected]>
c36069c6f46cadded two optional cells to eswin,hsp-sp-csr, but omitted minItems: 4.Please run checkpatch.pl and fix the issue it reports with the commit reference.
Thanks for pointing this out.
I'll fix it and send a v3.
Quoted 40 lines
Quoted 40 lines
As a result, dt-schema implicitly required all 6 cells, which broke backward compatibility with existing 4-cell device trees.
Add minItems: 4 to preserve backward compatibility.
Fixes c36069c6f46c ("dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsets")Reported-by Sashiko AI <[email protected]>Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by Zhi Li <[email protected]>---
Changes in v2:
- Referencec36069c6f46cexplicitly instead of "previous change".
- Improve commit message formatting and line wrapping.
- No functional change.
- Link to v1:https://lore.kernel.org/lkml/[email protected]/ --- Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml +2
-1@@ -84,7 +84,8 @@ properties: This reference is provided for background information only. $ref: /schemas/types.yaml#/definitions/phandle-array items: - - items: + - minItems: 4 + items: - description: Phandle to HSP(High-Speed Peripheral) device - description: Offset of phy control register for internal or external clock selectionSignature · 1 line
2.25.1