Skip to contentSkip to conversation

lib/test_firmware: allocate the configured into_buf size

PATCH Applied Samuel Moelius 2 participants 2 messages Jun 5 – Jun 6 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/test_firmware: allocate the configured into_buf size

The batched into_buf test path allocates TEST_FIRMWARE_BUF_SIZE bytes unconditionally, but then passes test_fw_config->buf_size to request_firmware_into_buf() or request_partial_firmware_into_buf().

Userspace can set config_buf_size above TEST_FIRMWARE_BUF_SIZE before triggering a batched request. If the firmware file is large enough, the firmware loader writes past the end of the 1 KiB test buffer.

Allocate the buffer with the same size that the test passes to the firmware API so config_buf_size remains the actual buffer size under test.

Assisted-by Codex:gpt-5.5-cyber-preview
---
 lib/test_firmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/test_firmware.c +1 -1
index b471d720879a..7459bba65444 100644
@@ -867,7 +867,7 @@ static int test_fw_run_batch_request(void *data)
 	if (test_fw_config->into_buf) {
 		void *test_buf;
 
-		test_buf = kzalloc(TEST_FIRMWARE_BUF_SIZE, GFP_KERNEL);
+		test_buf = kzalloc(test_fw_config->buf_size, GFP_KERNEL);
 		if (!test_buf)
 			return -ENOMEM;
 
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 10 lines · On Fri, 5 Jun 2026 00:30:37 +0000 Samuel Moelius…

The batched into_buf test path allocates TEST_FIRMWARE_BUF_SIZE bytes unconditionally, but then passes test_fw_config->buf_size to request_firmware_into_buf() or request_partial_firmware_into_buf().

Userspace can set config_buf_size above TEST_FIRMWARE_BUF_SIZE before triggering a batched request. If the firmware file is large enough, the firmware loader writes past the end of the 1 KiB test buffer.

Allocate the buffer with the same size that the test passes to the firmware API so config_buf_size remains the actual buffer size under test.

Cool, thanks.

Quoted 1 line
Assisted-by Codex:gpt-5.5-cyber-preview

Sashiko evidently looked further:

	https://sashiko.dev/#/patchset/[email protected]

And appears to have found other bugs in test_firmware.c. Let me cc a few people who have previously worked on this.