Skip to contentSkip to conversation

Add support for NetCube Systems OpenNMC (dobermann)

PATCH Superseded Lukas Schmid 2 participants 5 messages Jun 6

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add support for NetCube Systems OpenNMC (dobermann)

This series adds support for the NetCube Systems OpenNMC

Changes in v3:
- actually add the Makefile changes

Changes in v2:
- fixed ordering of compatible enum
- fixed gpio line names

---
Lukas Schmid (3):
dt-bindings: arm: sunxi: Add NetCube Systems OpenNMC (dobermann)
riscv: dts: allwinner: d1s-t113: Add uart4 pinctrl required by NetCube
Systems OpenNMC
ARM: dts: sunxi: add support for NetCube Systems OpenNMC (dobermann)

 .../devicetree/bindings/arm/sunxi.yaml        |   1 +
 arch/arm/boot/dts/allwinner/Makefile          |   2 +
 .../sun8i-t113s-netcube-dobermann.dts         | 149 ++++++++++++++++++
 .../boot/dts/allwinner/sunxi-d1s-t113.dtsi    |   6 +
 4 files changed, 158 insertions(+)
 create mode 100644 arch/arm/boot/dts/allwinner/sun8i-t113s-netcube-dobermann.dts
Signature · 1 line
2.47.3
#1 lore raw

PATCH v3 1/3 dt-bindings: arm: sunxi: Add NetCube Systems OpenNMC (dobermann)

The OpenNMC is an open replacement for APC SmartSlot management cards based on the Nagami System-on-Module.

---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/sunxi.yaml +1 -0
index e6443c266fa1..077b65507645 100644
@@ -598,6 +598,7 @@ properties:
       - description: NetCube Systems Nagami SoM based boards
         items:
           - enum:
+              - netcube,dobermann
               - netcube,nagami-basic-carrier
               - netcube,nagami-keypad-carrier
           - const: netcube,nagami
Signature · 1 line
2.47.3
#2 lore raw

PATCH v3 2/3 riscv: dts: allwinner: d1s-t113: Add uart4 pinctrl required by NetCube Systems OpenNMC

In reply to Lukas Schmid

Added the "uart4_pb_pins" pinctrl used by the OpenNMC

---
 arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi +6 -0
index 82cc85acccb1..00fddedfa36f 100644
@@ -191,6 +191,12 @@ uart3_pb_pins: uart3-pb-pins {
 				pins = "PB6", "PB7";
 				function = "uart3";
 			};
+
+			/omit-if-no-ref/
+			uart4_pb_pins: uart4-pb-pins {
+				pins = "PB2", "PB3";
+				function = "uart4";
+			};
 		};
 
 		ccu: clock-controller@2001000 {
Signature · 1 line
2.47.3
#3 lore raw

PATCH v3 3/3 ARM: dts: sunxi: add support for NetCube Systems OpenNMC (dobermann)

In reply to Lukas Schmid

NetCube Systems OpenNMC is an open replacement for APC SmartSlot Management Cards. It is based on the Nagami System-on-Module. It breaks out the following interfaces:

- 10/100 Mbps Ethernet
- USB Type-C OTG using a TUSB320 (usb0)
- USB Type-C Console Port using a CH340 (uart3)
- USB Type-A Host with internal CH334 USB-Hub (usb1)
- MicroSD Slot with Card-Detect (mmc0)
- WiFi/Bluetooth using the modules built-in ESP32
- SmartSlot serial interface (uart4)
- DS3232 RTC with CR1220 Battery Backup
- Extension connector providing SPI,I2C,USB,CAN,UART for future use.

---
 arch/arm/boot/dts/allwinner/Makefile          |   2 +
 .../sun8i-t113s-netcube-dobermann.dts         | 149 ++++++++++++++++++
 2 files changed, 151 insertions(+)
 create mode 100644 arch/arm/boot/dts/allwinner/sun8i-t113s-netcube-dobermann.dts
arch/arm/boot/dts/allwinner/Makefile +2 -0
index f71392a55df8..220a20734dc2 100644
@@ -201,6 +201,7 @@ DTC_FLAGS_sun8i-h3-orangepi-pc := -@
 DTC_FLAGS_sun8i-h3-bananapi-m2-plus-v1.2 := -@
 DTC_FLAGS_sun8i-h3-orangepi-pc-plus := -@
 DTC_FLAGS_sun8i-t113s-netcube-nagami-basic-carrier := -@
+DTC_FLAGS_sun8i-t113s-netcube-dobermann := -@
 DTC_FLAGS_sun8i-v3s-netcube-kumquat := -@
 dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-a23-evb.dtb \
@@ -261,6 +262,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-s3-lichee-zero-plus.dtb \
 	sun8i-s3-pinecube.dtb \
 	sun8i-t113s-mangopi-mq-r-t113.dtb \
+	sun8i-t113s-netcube-dobermann.dts \
 	sun8i-t113s-netcube-nagami-basic-carrier.dtb \
 	sun8i-t113s-netcube-nagami-keypad-carrier.dtb \
 	sun8i-t3-cqa3t-bv3.dtb \
arch/arm/boot/dts/allwinner/sun8i-t113s-netcube-dobermann.dts new file +149 -0

149 lines not on this page · raw message

Signature · 1 line
2.47.3
#4 lore raw

Re: [PATCH v3 3/3] ARM: dts: sunxi: add support for NetCube Systems OpenNMC (dobermann)

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The device tree source file is incorrectly added to the Makefile with a `.dts` extension instead of…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree source file is incorrectly added to the Makefile with a .dts extension instead of .dtb, which prevents the build system from generating the compiled device tree blob. --

commit 050625703589dd3473dcaea2f70357c5bd2c45b5
Author: Lukas Schmid <[email protected]>

ARM: dts: sunxi: add support for NetCube Systems OpenNMC (dobermann)

This commit adds device tree support for the NetCube Systems OpenNMC board, which acts as an open replacement for APC SmartSlot Management Cards based on the Nagami System-on-Module.

Quoted 4 lines
arch/arm/boot/dts/allwinner/Makefile +0 -0
index f71392a55df87..220a20734dc24 100644

[ ... ]

arch/arm/boot/dts/allwinner/Makefile dtb-$(CONFIG_MACH_SUN8I) += \ · line 265

Quoted 5 lines
arch/arm/boot/dts/allwinner/Makefile +1 -0
@@ -261,6 +262,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-s3-lichee-zero-plus.dtb \
 	sun8i-s3-pinecube.dtb \
 	sun8i-t113s-mangopi-mq-r-t113.dtb \
+	sun8i-t113s-netcube-dobermann.dts \

[Severity: Low]
Does this target need to use the .dtb extension instead of .dts? Kbuild expects the compiled device tree blob targets in the dtb-y lists to resolve the compilation rules. Listing the source .dts file here might cause the build system to skip compiling the new device tree blob entirely.

[ ... ]

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3