perf build: Respect V=1 for Python extension builds
PATCH 1/1 perf build: Respect V=1 for Python extension builds
Make util/setup.py respect the verbose build flag (V=1) by conditionally passing --quiet only when not in verbose mode.
This eases debugging of Python extension compilation issues and aligns with the existing perf build system behavior.
---
Notes (jremus):
This patch applies on top of tip:perf/core:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
tools/perf/Makefile.perf | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
tools/perf/Makefile.perf +6 -2
@@ -402,6 +402,10 @@ export PYTHON_EXTBUILD_LIB PYTHON_EXTBUILD_TMP python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT)python/perf*.so +ifneq ($(quiet),) +setup_quiet=--quiet +endif + # Use the detected configuration -include $(OUTPUT).config-detected
@@ -747,7 +751,7 @@ $(OUTPUT)python/perf$(PYTHON_EXTENSION_SUFFIX): util/python.c util/setup.py $(PE $(QUIET_GEN)LDSHARED="$(CC) -pthread -shared" \ CFLAGS='$(CFLAGS)' LDFLAGS='$(LDFLAGS) $(LIBS_PY)' \ $(PYTHON_WORD) util/setup.py \ - --quiet build_ext; \ + $(setup_quiet) build_ext; \ cp $(PYTHON_EXTBUILD_LIB)perf*.so $(OUTPUT)python/ python_perf_target:
@@ -1152,7 +1156,7 @@ install-bin: install-tools install-tests install: install-bin try-install-man install-python_ext: - $(PYTHON_WORD) util/setup.py --quiet install --root='/$(DESTDIR_SQ)' + $(PYTHON_WORD) util/setup.py $(setup_quiet) install --root='/$(DESTDIR_SQ)' # 'make install-doc' should call 'make -C Documentation install' $(INSTALL_DOC_TARGETS):
Signature · 1 line
2.53.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The `setup_quiet` variable is not initialized before its conditional assignment, allowing it to…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The setup_quiet variable is not initialized before its conditional assignment, allowing it to inherit arbitrary values from the user's environment when V=1 is used. --
commit 8926935922228db2605e3a9cb12821c9b36a4337
Author: Jens Remus <[email protected]>
perf build: Respect V=1 for Python extension builds
This commit modifies the perf build system to conditionally pass the --quiet flag to setup.py. It aims to respect the V=1 verbose build flag to ease debugging of Python extension compilation issues.
tools/perf/Makefile.perf export PYTHON_EXTBUILD_LIB PYTHON_EXTBUILD_TMP · line 407
Quoted 12 lines
tools/perf/Makefile.perf +4
-0@@ -401,6 +401,10 @@ export PYTHON_EXTBUILD_LIB PYTHON_EXTBUILD_TMP python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT)python/perf*.so +ifneq ($(quiet),) +setup_quiet=--quiet +endif +
[Severity: Low]
Does this leave setup_quiet uninitialized when V=1 is used?
Because make imports environment variables automatically, if a user happens to have an environment variable named setup_quiet, it could be unintentionally passed directly to util/setup.py when the quiet variable evaluates to empty.
Would it be safer to explicitly initialize setup_quiet to an empty string before the conditional block to prevent environment variable contamination?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Ian Rogers
reviewerQuoted 7 lines · Jens Remus
Make
util/setup.pyrespect the verbose build flag (V=1) by conditionally passing --quiet only when not in verbose mode.This eases debugging of Python extension compilation issues and aligns with the existing perf build system behavior.
Quoted 8 lines
Tested-by Jan Polensky <[email protected]>Signed-off-by Jens Remus <[email protected]>---
Notes (jremus):
This patch applies on top of tip:perf/core:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.gitperf/core
This is a useful change! I suspect it will need rebasing on the perf-tools-next tree to come in that way:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/
tools/perf/Makefile.perf export PYTHON_EXTBUILD_LIB PYTHON_EXTBUILD_TMP · line 406
Quoted 13 lines
tools/perf/Makefile.perf | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)tools/perf/Makefile.perf +2
-0@@ -402,6 +402,10 @@ export PYTHON_EXTBUILD_LIB PYTHON_EXTBUILD_TMP python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT)python/perf*.so +ifneq ($(quiet),) +setup_quiet=--quiet
nit: could this variable be python_setup_quiet to add a little more intent to the name?
Thanks,
Ian
Quoted 26 lines
tools/perf/Makefile.perf +4
-3+endif + # Use the detected configuration -include $(OUTPUT).config-detected@@ -747,7 +751,7 @@ $(OUTPUT)python/perf$(PYTHON_EXTENSION_SUFFIX): util/python.c util/setup.py $(PE $(QUIET_GEN)LDSHARED="$(CC) -pthread -shared" \ CFLAGS='$(CFLAGS)' LDFLAGS='$(LDFLAGS) $(LIBS_PY)' \ $(PYTHON_WORD) util/setup.py \ - --quiet build_ext; \ + $(setup_quiet) build_ext; \ cp $(PYTHON_EXTBUILD_LIB)perf*.so $(OUTPUT)python/ python_perf_target:@@ -1152,7 +1156,7 @@ install-bin: install-tools install-tests install: install-bin try-install-man install-python_ext: - $(PYTHON_WORD) util/setup.py --quiet install --root='/$(DESTDIR_SQ)' + $(PYTHON_WORD) util/setup.py $(setup_quiet) install --root='/$(DESTDIR_SQ)' # 'make install-doc' should call 'make -C Documentation install' $(INSTALL_DOC_TARGETS): --2.53.0