Nuvoton NPCM FIU DTS fixes and binding conversion

The NPCM7xx FIU controller driver gets its single clock with devm_clk_get_enabled(dev, NULL) and does not perform a named clock lookup. Drop the redundant clock-names properties from the FIU controller nodes so the DTS describes only the resources the driver actually uses.

Signed-off-by Tomer Maimon <[email protected]>

---
 arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 3 ---
 1 file changed, 3 deletions(-)

The NPCM7xx FIU controller driver gets its single clock with devm_clk_get_enabled(dev, NULL) and does not perform a named clock lookup. Drop the redundant clock-names properties from the FIU controller nodes so the DTS describes only the resources the driver actually uses.

Signed-off-by Tomer Maimon <[email protected]>

---
 arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 3 ---

 1 file changed, 3 deletions(-)

arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +0 -1

index a16450abea0e..83cd10b47273 100644
@@ -193,7 +193,6 @@ fiu0: spi@fb000000 {
  			reg = <0xfb000000 0x1000>;
  			reg-names = "control";
  			clocks = <&clk NPCM7XX_CLK_SPI0>;
-			clock-names = "clk_spi0";
  			status = "disabled";
  		};

arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +0 -2

@@ -204,7 +203,6 @@ fiu3: spi@c0000000 {
  			reg = <0xc0000000 0x1000>;
  			reg-names = "control";
  			clocks = <&clk NPCM7XX_CLK_SPI3>;
-			clock-names = "clk_spi3";
  			pinctrl-names = "default";
  			pinctrl-0 = <&spi3_pins>;
  			status = "disabled";

@@ -217,7 +215,6 @@ fiux: spi@fb001000 {
  			reg = <0xfb001000 0x1000>;
  			reg-names = "control";
  			clocks = <&clk NPCM7XX_CLK_SPIX>;
-			clock-names = "clk_spix";
  			status = "disabled";
  		};

Quoted 5 lines · Tomer Maimon

The NPCM7xx FIU controller driver gets its single clock with devm_clk_get_enabled(dev, NULL) and does not perform a named clock lookup. Drop the redundant clock-names properties from the FIU controller nodes so the DTS describes only the resources the driver actually uses.

The devicetree is a description of the hardware in the form documented by the bindings. Generally it's not right to discuss Linux drivers
here: they're only relevant in the context of Linux, but the devicetree binding governs devicetrees over multiple projects.

From a quick look it seems that these names are not described in the corresponding binding, therefore no drivers should be using them and as such they can (and should) be dropped. A driver would only be worth mentioning if it did use the undocumented names (as that would be a complication).

Can you please rework the description?

Andrew

Quoted 18 lines

Signed-off-by Tomer Maimon <[email protected]>

---
 arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 3 ---
 1 file changed, 3 deletions(-)

arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +0 -1

index a16450abea0e..83cd10b47273 100644
@@ -193,7 +193,6 @@ fiu0: spi@fb000000 {
                      reg = <0xfb000000 0x1000>;
                      reg-names = "control";
                      clocks = <&clk NPCM7XX_CLK_SPI0>;
-                     clock-names = "clk_spi0";
                      status = "disabled";
              };
 

Quoted 9 lines

arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +0 -1

@@ -204,7 +203,6 @@ fiu3: spi@c0000000 {
                      reg = <0xc0000000 0x1000>;
                      reg-names = "control";
                      clocks = <&clk NPCM7XX_CLK_SPI3>;
-                     clock-names = "clk_spi3";
                      pinctrl-names = "default";
                      pinctrl-0 = <&spi3_pins>;
                      status = "disabled";

arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi fiux: spi@fb001000 { · line 220

Quoted 7 lines

arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +0 -1

@@ -217,7 +215,6 @@ fiux: spi@fb001000 {
                      reg = <0xfb001000 0x1000>;
                      reg-names = "control";
                      clocks = <&clk NPCM7XX_CLK_SPIX>;
-                     clock-names = "clk_spix";
                      status = "disabled";
              };
 

Quoted 19 lines · Andrew Jeffery

Quoted 5 lines · Tomer Maimon

The NPCM7xx FIU controller driver gets its single clock with devm_clk_get_enabled(dev, NULL) and does not perform a named clock lookup. Drop the redundant clock-names properties from the FIU controller nodes so the DTS describes only the resources the driver actually uses.

The devicetree is a description of the hardware in the form documented by the bindings. Generally it's not right to discuss Linux drivers
here: they're only relevant in the context of Linux, but the devicetree binding governs devicetrees over multiple projects.

From a quick look it seems that these names are not described in the corresponding binding, therefore no drivers should be using them and as such they can (and should) be dropped. A driver would only be worth mentioning if it did use the undocumented names (as that would be a complication).

Quoted 1 line

Can you please rework the description?

do you mean change the description as follows
"
The NPCM7xx FIU controller nodes reference a single clock, but the FIU binding does not describe their clock-names properties. Drop the undocumented names so the DTS matches the binding. "

Quoted 21 lines · Tomer Maimon

Quoted 19 lines · Andrew Jeffery

Quoted 5 lines · Tomer Maimon

The NPCM7xx FIU controller driver gets its single clock with devm_clk_get_enabled(dev, NULL) and does not perform a named clock lookup. Drop the redundant clock-names properties from the FIU controller nodes so the DTS describes only the resources the driver actually uses.

The devicetree is a description of the hardware in the form documented by the bindings. Generally it's not right to discuss Linux drivers
here: they're only relevant in the context of Linux, but the devicetree binding governs devicetrees over multiple projects.

From a quick look it seems that these names are not described in the corresponding binding, therefore no drivers should be using them and as such they can (and should) be dropped. A driver would only be worth mentioning if it did use the undocumented names (as that would be a complication).

Quoted 7 lines

Quoted 1 line

Can you please rework the description?

do you mean change the description as follows
"
The NPCM7xx FIU controller nodes reference a single clock, but the FIU binding does not describe their clock-names properties. Drop the undocumented names so the DTS matches the binding. "

That sounds reasonable to me.

Thanks,

Andrew

Convert the Nuvoton NPCM FIU binding to DT schema format.

Document the required control registers and the optional direct- mapped flash window separately, matching the driver behavior when the direct mapping is not described.

Signed-off-by Tomer Maimon <[email protected]>

---
 .../bindings/spi/nuvoton,npcm-fiu.txt         | 58 ------------
 .../bindings/spi/nuvoton,npcm750-fiu.yaml     | 93 +++++++++++++++++++
 2 files changed, 93 insertions(+), 58 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
 create mode 100644 Documentation/devicetree/bindings/spi/nuvoton,npcm750-fiu.yaml

Nuvoton NPCM FIU DTS fixes and binding conversion

This series fixes the in-tree NPCM7xx FIU controller nodes so their resources match what the DTS actually describes, and converts the legacy Nuvoton NPCM FIU binding to YAML DT schema.

Patch 1 drops the bogus "memory" entry from reg-names on the NPCM7xx FIU nodes.

[...]