Skip to contentSkip to conversation

Add vm_bind param check to ensure no overlap with kbo AS carveout

PATCH Superseded Adrián Larumbe 3 participants 8 messages Jun 16 – Jun 23

Subsystems (3)

v1 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

cover Add vm_bind param check to ensure no overlap with kbo AS carveout

Just a quick check to make sure user-supplied vm_bind regions aren't clashing with the region reserved for kernel bo's.

I tried to introduce a similar check for panthor_vm_alloc_va(), to throw back an error when mappings of kernel bo's against specific addresses fall within the auto_va region. However that is not possible, since there's one FW region that must be mapped right at CSF_MCU_SHARED_REGION_START. That is usually not a problem, since drm_mm_insert_node_in_range() will pick the next one available.

---
Adrián Larumbe (2):
drm/panthor: Add vm_bind region with kbo range intersection check drm/panthor: Fix comment to reflect actual struct field name

 drivers/gpu/drm/panthor/panthor_mmu.c | 35 ++++++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

---
base-commit: 2afdfc658f7a7e9ee2a67ec6663922da9c799c53
change-id: 20260614-vm_bind_checks-46075ba069a0

Best regards,

Signature · 1 line
Adrián Larumbe <[email protected]>
#1 lore raw

PATCH 1/2 drm/panthor: Add vm_bind region with kbo range intersection check

When a VM is created, caller has to specify the range of the address space carve-out set aside for mapping kernel BO's. That means vm_bind mappings of UM-exposed BO's should not intersect with that region, but at the moment we're not checking this.

At first, I thought of giving these values to drm_gpuvm_init() through its reserve_{offset, range} arguments, but it turns out that is meant for VM address spans that are not managed through the usual drm_gpuvm split/merge circuit, so I had no choice but to sort of duplicate that functionality in Panthor. That means we also need to keep that interval recorded in the VM.

---
 drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
drivers/gpu/drm/panthor/panthor_mmu.c +33 -0
index 31cc57029c12..5625f3d34031 100644
@@ -301,6 +301,15 @@ struct panthor_vm {
 	/** @mm_lock: Lock protecting the @mm field. */
 	struct mutex mm_lock;
 
+	/** @kernel_va: VA-range reserved for kernel BOs. */
+	struct {
+		/** @kernel_va.start: Start of the VA-range for kernel BOs. */
+		u64 start;
+
+		/** @kernel_va.range: Size of the automatic VA-range for kernel BOs. */
+		u64 range;
+	} kernel_va;
+
 	/** @kernel_auto_va: Automatic VA-range for kernel BOs. */
 	struct {
 		/** @kernel_auto_va.start: Start of the automatic VA-range for kernel BOs. */
@@ -1309,6 +1318,24 @@ static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx)
 	return 0;
 }
 
+static bool
+panthor_vm_is_kernel_address(struct panthor_vm *vm,
+			     const struct drm_panthor_vm_bind_op *op)
+{
+	u32 op_type = op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK;
+	u64 end, kstart, krange, kend;
+
+	if (op_type == DRM_PANTHOR_VM_BIND_OP_TYPE_SYNC_ONLY)
+		return false;
+
+	end = op->va + op->size;
+	kstart = vm->kernel_va.start;
+	krange = vm->kernel_va.range;
+	kend = kstart + krange;
+
+	return krange && op->va < kend && kstart < end;
+}
+
 #define PANTHOR_VM_BIND_OP_MAP_FLAGS \
 	(DRM_PANTHOR_VM_BIND_OP_MAP_READONLY | \
 	 DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC | \
@@ -2891,6 +2918,8 @@ panthor_vm_create(struct panthor_device *ptdev, bool for_mcu,
 	} else {
 		min_va = 0;
 		va_range = full_va_range;
+		vm->kernel_va.start = kernel_va_start;
+		vm->kernel_va.range = kernel_va_size;
 	}
 
 	mutex_init(&vm->mm_lock);
@@ -2981,6 +3010,10 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file,
 	if (!IS_ALIGNED(op->va | op->size | op->bo_offset, vm_pgsz))
 		return -EINVAL;
 
+	/* We don't allow mappings that intersect with kbo's reserved range */
+	if (panthor_vm_is_kernel_address(vm, op))
+		return -EINVAL;
+
 	switch (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) {
 	case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP:
 		if (!(op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE)) {
Signature · 1 line
2.54.0
maintainer
#2 lore raw

Re: [PATCH 1/2] drm/panthor: Add vm_bind region with kbo range intersection check

Quoted 22 lines · On Tue, 16 Jun 2026 15:46:43 +0100 Adrián Larumbe…

When a VM is created, caller has to specify the range of the address space carve-out set aside for mapping kernel BO's. That means vm_bind mappings of UM-exposed BO's should not intersect with that region, but at the moment we're not checking this.

At first, I thought of giving these values to drm_gpuvm_init() through its reserve_{offset, range} arguments, but it turns out that is meant for VM address spans that are not managed through the usual drm_gpuvm split/merge circuit, so I had no choice but to sort of duplicate that functionality in Panthor. That means we also need to keep that interval recorded in the VM.

---
 drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
drivers/gpu/drm/panthor/panthor_mmu.c +0 -0
index 31cc57029c12..5625f3d34031 100644
@@ -301,6 +301,15 @@ struct panthor_vm {
 	/** @mm_lock: Lock protecting the @mm field. */

drivers/gpu/drm/panthor/panthor_mmu.c struct panthor_vm { · line 311

Quoted 10 lines
drivers/gpu/drm/panthor/panthor_mmu.c +8 -0
 	struct mutex mm_lock;
 
+	/** @kernel_va: VA-range reserved for kernel BOs. */
+	struct {
+		/** @kernel_va.start: Start of the VA-range for kernel BOs. */
+		u64 start;
+
+		/** @kernel_va.range: Size of the automatic VA-range for kernel BOs. */
+		u64 range;
+	} kernel_va;

We can do with a single user_va_end.

drivers/gpu/drm/panthor/panthor_mmu.c static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx) · line 1323

Quoted 11 lines
drivers/gpu/drm/panthor/panthor_mmu.c +4 -0
+
 	/** @kernel_auto_va: Automatic VA-range for kernel BOs. */
 	struct {
 		/** @kernel_auto_va.start: Start of the automatic VA-range for kernel BOs. */
@@ -1309,6 +1318,24 @@ static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx)
 	return 0;
 }
 
+static bool
+panthor_vm_is_kernel_address(struct panthor_vm *vm,
+			     const struct drm_panthor_vm_bind_op *op)

Rather than checking if the VA is not in the kernel range, I'd check that the VA is in the user range, since that's what we want to enforce, and if we ever decide to carve out extra sections above the user-range that the UMD is not supposed to access, we would still catch invalid map/unmap ops.

drivers/gpu/drm/panthor/panthor_mmu.c static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx) · line 1329

Quoted 6 lines
drivers/gpu/drm/panthor/panthor_mmu.c +6 -0
+{
+	u32 op_type = op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK;
+	u64 end, kstart, krange, kend;
+
+	if (op_type == DRM_PANTHOR_VM_BIND_OP_TYPE_SYNC_ONLY)
+		return false;

IIRC, we force op->va and op->size to be zero in that case[1], so no need for this extra check IMHO.

drivers/gpu/drm/panthor/panthor_mmu.c static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx) · line 1336

Quoted 7 lines
drivers/gpu/drm/panthor/panthor_mmu.c +7 -0
+
+	end = op->va + op->size;
+	kstart = vm->kernel_va.start;
+	krange = vm->kernel_va.range;
+	kend = kstart + krange;
+
+	return krange && op->va < kend && kstart < end;

A single

	op->va + op->size <= vm->user_va_end;

would do, at which point I'm not too sure adding a helper makes sense.

Quoted 16 lines
drivers/gpu/drm/panthor/panthor_mmu.c +4 -0
+}
+
 #define PANTHOR_VM_BIND_OP_MAP_FLAGS \
 	(DRM_PANTHOR_VM_BIND_OP_MAP_READONLY | \
 	 DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC | \
@@ -2891,6 +2918,8 @@ panthor_vm_create(struct panthor_device *ptdev, bool for_mcu,
 	} else {
 		min_va = 0;
 		va_range = full_va_range;
+		vm->kernel_va.start = kernel_va_start;
+		vm->kernel_va.range = kernel_va_size;
 	}
 
 	mutex_init(&vm->mm_lock);

drivers/gpu/drm/panthor/panthor_mmu.c panthor_vm_bind_prepare_op_ctx(struct drm_file *file, · line 3019

Quoted 10 lines
drivers/gpu/drm/panthor/panthor_mmu.c +4 -0
@@ -2981,6 +3010,10 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file,
 	if (!IS_ALIGNED(op->va | op->size | op->bo_offset, vm_pgsz))
 		return -EINVAL;
 
+	/* We don't allow mappings that intersect with kbo's reserved range */
+	if (panthor_vm_is_kernel_address(vm, op))
+		return -EINVAL;
+
 	switch (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) {
 	case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP:
 		if (!(op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE)) {

[1]https://elixir.bootlin.com/linux/v7.0.11/source/include/uapi/drm/panthor_drm.h#L588

#3 lore raw

Re: [PATCH 1/2] drm/panthor: Add vm_bind region with kbo range intersection check

Quoted 76 lines · Boris Brezillon
Quoted 22 lines · On Tue, 16 Jun 2026 15:46:43 +0100 Adrián Larumbe…

When a VM is created, caller has to specify the range of the address space carve-out set aside for mapping kernel BO's. That means vm_bind mappings of UM-exposed BO's should not intersect with that region, but at the moment we're not checking this.

At first, I thought of giving these values to drm_gpuvm_init() through its reserve_{offset, range} arguments, but it turns out that is meant for VM address spans that are not managed through the usual drm_gpuvm split/merge circuit, so I had no choice but to sort of duplicate that functionality in Panthor. That means we also need to keep that interval recorded in the VM.

---
 drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
drivers/gpu/drm/panthor/panthor_mmu.c +0 -0
index 31cc57029c12..5625f3d34031 100644
@@ -301,6 +301,15 @@ struct panthor_vm {
 	/** @mm_lock: Lock protecting the @mm field. */

drivers/gpu/drm/panthor/panthor_mmu.c struct panthor_vm { · line 311

Quoted 10 lines
drivers/gpu/drm/panthor/panthor_mmu.c +8 -0
 	struct mutex mm_lock;
 
+	/** @kernel_va: VA-range reserved for kernel BOs. */
+	struct {
+		/** @kernel_va.start: Start of the VA-range for kernel BOs. */
+		u64 start;
+
+		/** @kernel_va.range: Size of the automatic VA-range for kernel BOs. */
+		u64 range;
+	} kernel_va;

We can do with a single user_va_end.

drivers/gpu/drm/panthor/panthor_mmu.c static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx) · line 1323

Quoted 11 lines
drivers/gpu/drm/panthor/panthor_mmu.c +4 -0
+
 	/** @kernel_auto_va: Automatic VA-range for kernel BOs. */
 	struct {
 		/** @kernel_auto_va.start: Start of the automatic VA-range for kernel BOs. */
@@ -1309,6 +1318,24 @@ static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx)
 	return 0;
 }
 
+static bool
+panthor_vm_is_kernel_address(struct panthor_vm *vm,
+			     const struct drm_panthor_vm_bind_op *op)

Rather than checking if the VA is not in the kernel range, I'd check that the VA is in the user range, since that's what we want to enforce, and if we ever decide to carve out extra sections above the user-range that the UMD is not supposed to access, we would still catch invalid map/unmap ops.

drivers/gpu/drm/panthor/panthor_mmu.c static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx) · line 1329

Quoted 6 lines
drivers/gpu/drm/panthor/panthor_mmu.c +6 -0
+{
+	u32 op_type = op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK;
+	u64 end, kstart, krange, kend;
+
+	if (op_type == DRM_PANTHOR_VM_BIND_OP_TYPE_SYNC_ONLY)
+		return false;

IIRC, we force op->va and op->size to be zero in that case[1], so no need for this extra check IMHO.

drivers/gpu/drm/panthor/panthor_mmu.c static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx) · line 1336

Quoted 7 lines
drivers/gpu/drm/panthor/panthor_mmu.c +7 -0
+
+	end = op->va + op->size;
+	kstart = vm->kernel_va.start;
+	krange = vm->kernel_va.range;
+	kend = kstart + krange;
+
+	return krange && op->va < kend && kstart < end;

A single

Quoted 3 lines
	op->va + op->size <= vm->user_va_end;

would do, at which point I'm not too sure adding a helper makes sense.

I'll do this for v2.

Quoted 27 lines
Quoted 15 lines
drivers/gpu/drm/panthor/panthor_mmu.c +4 -0
+}
+
 #define PANTHOR_VM_BIND_OP_MAP_FLAGS \
 	(DRM_PANTHOR_VM_BIND_OP_MAP_READONLY | \
 	 DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC | \
@@ -2891,6 +2918,8 @@ panthor_vm_create(struct panthor_device *ptdev, bool for_mcu,
 	} else {
 		min_va = 0;
 		va_range = full_va_range;
+		vm->kernel_va.start = kernel_va_start;
+		vm->kernel_va.range = kernel_va_size;
 	}
 
 	mutex_init(&vm->mm_lock);

drivers/gpu/drm/panthor/panthor_mmu.c panthor_vm_bind_prepare_op_ctx(struct drm_file *file, · line 3019

Quoted 10 lines
drivers/gpu/drm/panthor/panthor_mmu.c +4 -0
@@ -2981,6 +3010,10 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file,
 	if (!IS_ALIGNED(op->va | op->size | op->bo_offset, vm_pgsz))
 		return -EINVAL;
 
+	/* We don't allow mappings that intersect with kbo's reserved range */
+	if (panthor_vm_is_kernel_address(vm, op))
+		return -EINVAL;
+
 	switch (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) {
 	case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP:
 		if (!(op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE)) {

[1]https://elixir.bootlin.com/linux/v7.0.11/source/include/uapi/drm/panthor_drm.h#L588

#4 lore raw

Re: [PATCH 1/2] drm/panthor: Add vm_bind region with kbo range intersection check

In reply to Adrián Larumbe
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Integer overflow in `panthor_vm_is_kernel_address()` bypasses the newly added kernel BO range…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Integer overflow in panthor_vm_is_kernel_address() bypasses the newly added kernel BO range check. --

commit 517863d5c6821783c9329a7a6ac1663177dce0ba
Author: Adrián Larumbe <[email protected]>

drm/panthor: Add vm_bind region with kbo range intersection check

This commit adds a check during VM binding to ensure that user-exposed BO mappings do not intersect with the virtual address space carve-out reserved for kernel BOs. It introduces panthor_vm_is_kernel_address() to evaluate if the requested mapping overlaps with the kernel VA range.

Quoted 4 lines
drivers/gpu/drm/panthor/panthor_mmu.c +0 -0
index 31cc57029c12c..5625f3d340318 100644

[ ... ]

Quoted 10 lines
drivers/gpu/drm/panthor/panthor_mmu.c +6 -0
@@ -1309,6 +1318,24 @@ static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx)
 	return 0;
 }
 
+static bool
+panthor_vm_is_kernel_address(struct panthor_vm *vm,
+			     const struct drm_panthor_vm_bind_op *op)
+{
+	u32 op_type = op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK;
+	u64 end, kstart, krange, kend;

drivers/gpu/drm/panthor/panthor_mmu.c static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx) · line 1336

Quoted 10 lines
drivers/gpu/drm/panthor/panthor_mmu.c +10 -0
+
+	if (op_type == DRM_PANTHOR_VM_BIND_OP_TYPE_SYNC_ONLY)
+		return false;
+
+	end = op->va + op->size;
+	kstart = vm->kernel_va.start;
+	krange = vm->kernel_va.range;
+	kend = kstart + krange;
+
+	return krange && op->va < kend && kstart < end;

[Severity: Medium]
Can this calculation integer overflow?

If a user provides an op->va and op->size that wrap around a 64-bit integer when added, end becomes a small value.

This would cause the intersection check (kstart < end) to evaluate to false, bypassing the newly added kernel BO range check.

Should this use an overflow safe check to validate the range before checking the intersection?

Quoted 1 line
drivers/gpu/drm/panthor/panthor_mmu.c +1 -0
+}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#5 lore raw

Re: [PATCH 1/2] drm/panthor: Add vm_bind region with kbo range intersection check

Quoted 45 lines · On 23.06.2026 20:14, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Integer overflow in panthor_vm_is_kernel_address() bypasses the newly added kernel BO range check. --

commit 517863d5c6821783c9329a7a6ac1663177dce0ba
Author: Adrián Larumbe <[email protected]>

drm/panthor: Add vm_bind region with kbo range intersection check

This commit adds a check during VM binding to ensure that user-exposed BO mappings do not intersect with the virtual address space carve-out reserved for kernel BOs. It introduces panthor_vm_is_kernel_address() to evaluate if the requested mapping overlaps with the kernel VA range.

Quoted 4 lines
drivers/gpu/drm/panthor/panthor_mmu.c +0 -0
index 31cc57029c12c..5625f3d340318 100644

[ ... ]

Quoted 10 lines
drivers/gpu/drm/panthor/panthor_mmu.c +6 -0
@@ -1309,6 +1318,24 @@ static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx)
 	return 0;
 }
 
+static bool
+panthor_vm_is_kernel_address(struct panthor_vm *vm,
+			     const struct drm_panthor_vm_bind_op *op)
+{
+	u32 op_type = op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK;
+	u64 end, kstart, krange, kend;

drivers/gpu/drm/panthor/panthor_mmu.c static int panthor_vm_op_ctx_prealloc_pts(struct panthor_vm_op_ctx *op_ctx) · line 1336

Quoted 10 lines
drivers/gpu/drm/panthor/panthor_mmu.c +10 -0
+
+	if (op_type == DRM_PANTHOR_VM_BIND_OP_TYPE_SYNC_ONLY)
+		return false;
+
+	end = op->va + op->size;
+	kstart = vm->kernel_va.start;
+	krange = vm->kernel_va.range;
+	kend = kstart + krange;
+
+	return krange && op->va < kend && kstart < end;

[Severity: Medium]
Can this calculation integer overflow?

Quoted 8 lines

If a user provides an op->va and op->size that wrap around a 64-bit integer when added, end becomes a small value.

This would cause the intersection check (kstart < end) to evaluate to false, bypassing the newly added kernel BO range check.

Should this use an overflow safe check to validate the range before checking the intersection?

Will address in v3.

Quoted 4 lines
Quoted 1 line
drivers/gpu/drm/panthor/panthor_mmu.c +1 -0
+}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

Adrian Larumbe

#6 lore raw

PATCH 2/2 drm/panthor: Fix comment to reflect actual struct field name

In reply to Adrián Larumbe

The mismatch would pop up when building the kernel with W=1.

---
 drivers/gpu/drm/panthor/panthor_mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panthor/panthor_mmu.c +1 -1
index 5625f3d34031..ab7a1698c327 100644
@@ -315,7 +315,7 @@ struct panthor_vm {
 		/** @kernel_auto_va.start: Start of the automatic VA-range for kernel BOs. */
 		u64 start;
 
-		/** @kernel_auto_va.size: Size of the automatic VA-range for kernel BOs. */
+		/** @kernel_auto_va.end: End of the automatic VA-range for kernel BOs. */
 		u64 end;
 	} kernel_auto_va;
 
Signature · 1 line
2.54.0
maintainer Reviewed-by on v1 2/2
#7 lore raw

Re: [PATCH 2/2] drm/panthor: Fix comment to reflect actual struct field name

Quoted 3 lines · On Tue, 16 Jun 2026 15:46:44 +0100 Adrián Larumbe…

The mismatch would pop up when building the kernel with W=1.

Quoted 18 lines
---
 drivers/gpu/drm/panthor/panthor_mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panthor/panthor_mmu.c +1 -1
index 5625f3d34031..ab7a1698c327 100644
@@ -315,7 +315,7 @@ struct panthor_vm {
 		/** @kernel_auto_va.start: Start of the automatic VA-range for kernel BOs. */
 		u64 start;
 
-		/** @kernel_auto_va.size: Size of the automatic VA-range for kernel BOs. */
+		/** @kernel_auto_va.end: End of the automatic VA-range for kernel BOs. */
 		u64 end;
 	} kernel_auto_va;