Skip to contentSkip to conversation

mm: hugetlb: correct CONFIG_CGROUP_HUGETLB macro name in comment

PATCH Applied Ethan Nelson-Moore 4 participants 4 messages Jun 16 – Jun 29 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: hugetlb: correct CONFIG_CGROUP_HUGETLB macro name in comment

A comment in <linux/hugetlb_cgroup.h> incorrectly refers to CONFIG_MEM_RES_CTLR_HUGETLB, which has never existed in the kernel, instead of CONFIG_CGROUP_HUGETLB. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 include/linux/hugetlb_cgroup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/hugetlb_cgroup.h +1 -1
index e5d64b8b59c2..16d72c8c71f6 100644
@@ -267,5 +267,5 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio,
 {
 }
 
-#endif  /* CONFIG_MEM_RES_CTLR_HUGETLB */
+#endif  /* CONFIG_CGROUP_HUGETLB */
 #endif
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Ethan Nelson-Moore

A comment in <linux/hugetlb_cgroup.h> incorrectly refers to CONFIG_MEM_RES_CTLR_HUGETLB, which has never existed in the kernel, instead of CONFIG_CGROUP_HUGETLB. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

Thanks.

Reviewed-by on v1 1/1
#2 lore raw
In reply to Ethan Nelson-Moore
Quoted 17 lines · Ethan Nelson-Moore

A comment in <linux/hugetlb_cgroup.h> incorrectly refers to CONFIG_MEM_RES_CTLR_HUGETLB, which has never existed in the kernel, instead of CONFIG_CGROUP_HUGETLB. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

---
 include/linux/hugetlb_cgroup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/hugetlb_cgroup.h +0 -0
index e5d64b8b59c2..16d72c8c71f6 100644

include/linux/hugetlb_cgroup.h static inline void hugetlb_cgroup_migrate(struct folio *old_folio, · line 271

Quoted 6 lines
include/linux/hugetlb_cgroup.h +1 -1
@@ -267,5 +267,5 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio,
 {
 }
 
-#endif  /* CONFIG_MEM_RES_CTLR_HUGETLB */
+#endif  /* CONFIG_CGROUP_HUGETLB */
 #endif

Right, commit 2bc64a204697 ("mm/hugetlb: add new HugeTLB cgroup") introduced that. Probably a leftover after reworks.

Signature · 3 lines
Cheers,

David
Reviewed-by on v1 1/1
#3 lore raw
In reply to Ethan Nelson-Moore
Quoted 8 lines · Ethan Nelson-Moore

A comment in <linux/hugetlb_cgroup.h> incorrectly refers to CONFIG_MEM_RES_CTLR_HUGETLB, which has never existed in the kernel, instead of CONFIG_CGROUP_HUGETLB. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.

LGTM, so:

Quoted 16 lines
---
 include/linux/hugetlb_cgroup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/hugetlb_cgroup.h +1 -2
index e5d64b8b59c2..16d72c8c71f6 100644
@@ -267,5 +267,5 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio,
 {
 }
 
-#endif  /* CONFIG_MEM_RES_CTLR_HUGETLB */
+#endif  /* CONFIG_CGROUP_HUGETLB */
 #endif
--
Quoted 2 lines

2.43.0

Cheers, Lorenzo