mm: hugetlb: correct CONFIG_CGROUP_HUGETLB macro name in comment
PATCH 1/1 mm: hugetlb: correct CONFIG_CGROUP_HUGETLB macro name in comment
A comment in <linux/hugetlb_cgroup.h> incorrectly refers to CONFIG_MEM_RES_CTLR_HUGETLB, which has never existed in the kernel, instead of CONFIG_CGROUP_HUGETLB. Correct it.
Discovered while searching for CONFIG_* symbols referenced in code but not defined in any Kconfig file.
--- include/linux/hugetlb_cgroup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/hugetlb_cgroup.h +1 -1
@@ -267,5 +267,5 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio, { } -#endif /* CONFIG_MEM_RES_CTLR_HUGETLB */ +#endif /* CONFIG_CGROUP_HUGETLB */ #endif
Signature · 1 line
2.43.0
Quoted 12 lines · Ethan Nelson-Moore
A comment in <
linux/hugetlb_cgroup.h> incorrectly refers toCONFIG_MEM_RES_CTLR_HUGETLB, which has never existed in the kernel, instead ofCONFIG_CGROUP_HUGETLB. Correct it.Discovered while searching for CONFIG_* symbols referenced in code but not defined in any
Kconfigfile.Signed-off-by Ethan Nelson-Moore <[email protected]>
Thanks.
Quoted 17 lines · Ethan Nelson-Moore
A comment in <
linux/hugetlb_cgroup.h> incorrectly refers toCONFIG_MEM_RES_CTLR_HUGETLB, which has never existed in the kernel, instead ofCONFIG_CGROUP_HUGETLB. Correct it.Discovered while searching for CONFIG_* symbols referenced in code but not defined in any
Kconfigfile.Signed-off-by Ethan Nelson-Moore <[email protected]>--- include/linux/hugetlb_cgroup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/hugetlb_cgroup.h +0
-0
include/linux/hugetlb_cgroup.h static inline void hugetlb_cgroup_migrate(struct folio *old_folio, · line 271
Quoted 6 lines
include/linux/hugetlb_cgroup.h +1
-1@@ -267,5 +267,5 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio, { } -#endif /* CONFIG_MEM_RES_CTLR_HUGETLB */ +#endif /* CONFIG_CGROUP_HUGETLB */ #endif
Right, commit 2bc64a204697 ("mm/hugetlb: add new HugeTLB cgroup") introduced that. Probably a leftover after reworks.
Signature · 3 lines
Cheers, David
Quoted 8 lines · Ethan Nelson-Moore
A comment in <
linux/hugetlb_cgroup.h> incorrectly refers toCONFIG_MEM_RES_CTLR_HUGETLB, which has never existed in the kernel, instead ofCONFIG_CGROUP_HUGETLB. Correct it.Discovered while searching for CONFIG_* symbols referenced in code but not defined in any
Kconfigfile.Signed-off-by Ethan Nelson-Moore <[email protected]>
LGTM, so:
Quoted 16 lines
--- include/linux/hugetlb_cgroup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/hugetlb_cgroup.h +1
-2@@ -267,5 +267,5 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio, { } -#endif /* CONFIG_MEM_RES_CTLR_HUGETLB */ +#endif /* CONFIG_CGROUP_HUGETLB */ #endif --
Quoted 2 lines
2.43.0
Cheers, Lorenzo