mtd: mtdpart: validate partition bounds in mtd_add_partition()
PATCH 1/1 mtd: mtdpart: validate partition bounds in mtd_add_partition()
mtd_add_partition() checks that 'length' is positive but does not validate that 'offset + length' fits within the parent partition's size. A userspace caller using the BLKPG_ADD_PARTITION ioctl can supply a crafted large 'length' value that passes the length <= 0 check, causing add_mtd_device() to fire a WARN_ON() when it detects the oversized partition.
Fix this by adding explicit bounds checks before allocate_partition() is called:
- Reject negative or out-of-range offsets.
- Use u64 arithmetic to safely check offset + length <= parent_size, avoiding potential signed integer overflow.
--- drivers/mtd/mtdpart.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/mtd/mtdpart.c +5 -0
@@ -264,6 +264,11 @@ int mtd_add_partition(struct mtd_info *parent, const char *name,if (length <=0 )return -EINVAL ; +if (offset <0 || offset >= (long long )parent_size) +return -EINVAL ; + +if ((u64 )offset + (u64 )length > parent_size) +return -EINVAL ;memset (&part,0 ,sizeof (part)); part.name = name; part.size = length;
Signature · 1 line
2.43.0
Quoted 8 lines · Deepanshu Kartikey
mtd_add_partition()checks that 'length' is positive but does not validate that 'offset + length' fits within the parent partition's size. A userspace caller using theBLKPG_ADD_PARTITIONioctl can supply a crafted large 'length' value that passes the length <= 0 check, causingadd_mtd_device()to fire aWARN_ON()when it detects the oversized partition.[...]
Applied to mtd/fixes, thanks!
[1/1] mtd: mtdpart: validate partition bounds in mtd_add_partition()
commit: a74e31d0a2d52c65d9a6647c87b54bf78c0d9317
Patche(s) should be available on mtd/linux.git and will be part of the next PR (provided that no robot complains by then).
Kind regards,
Miquèl