staging: rtl8723bs: remove unused function declarations
PATCH v2 1/1 staging: rtl8723bs: remove unused function declarations
rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status() are declared in rtl8192c_recv.h but have no implementation and no caller anywhere in the kernel tree. They are leftover from when this driver was derived from Realtek's shared vendor codebase covering multiple chip families.
Verified via grep across the full tree that neither symbol is referenced outside this declaration, and confirmed via a full build of the module before and after removal that no warnings or errors are introduced.
This addresses the "find and remove any code for other chips that is left over" item in the driver's TODO file.
------------------------------------------------------------------
Changes since v1:
- Rebased onto linux-next as requested by Dan Carpenter
--- drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0 -3
@@ -30,7 +30,4 @@ struct phy_stat {/* Rx smooth factor */ #define Rx_Smooth_Factor (20) -void rtl8192c_translate_rx_signal_stuff (union recv_frame *precvframe,struct phy_stat *pphy_status); -void rtl8192c_query_rx_desc_status (union recv_frame *precvframe,struct recv_stat *pdesc); -#endif
Signature · 1 line
2.53.0
Greg KH
maintainerQuoted 11 lines · Aditya Chari
rtl8192c_translate_rx_signal_stuff()andrtl8192c_query_rx_desc_status()are declared inrtl8192c_recv.hbut have no implementation and no caller anywhere in the kernel tree. They are leftover from when this driver was derived from Realtek's shared vendor codebase covering multiple chip families.Verified via grep across the full tree that neither symbol is referenced outside this declaration, and confirmed via a full build of the module before and after removal that no warnings or errors are introduced.
Quoted 5 lines
This addresses the "find and remove any code for other chips that is left over" item in the driver's TODO file.
Signed-off-by Aditya Chari <[email protected]>------------------------------------------------------------------
This line isn't needed because:
Quoted 3 lines
Changes since v1:
- Rebased onto linux-next as requested by Dan Carpenter
That should go below
Quoted 1 line
---
That line.
I think the documentation explains this, right?
thanks,
greg k-h