staging: rtl8723bs: remove unused function declarations
PATCH v3 1/1 staging: rtl8723bs: remove unused function declarations
rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status() are declared in rtl8192c_recv.h but have no implementation and no caller anywhere in the kernel tree. They are leftover from when this driver was derived from Realtek's shared vendor codebase covering multiple chip families.
Verified via grep across the full tree that neither symbol is referenced outside this declaration, and confirmed via a full build of the module before and after removal that no warnings or errors are introduced.
This addresses the "find and remove any code for other chips that is left over" item in the driver's TODO file.
---
Changes since v2:
- Fixed placement of changelog notes below the --- marker, per submitting-patches.rst
drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0 -3
@@ -30,7 +30,4 @@ struct phy_stat {/* Rx smooth factor */ #define Rx_Smooth_Factor (20) -void rtl8192c_translate_rx_signal_stuff (union recv_frame *precvframe,struct phy_stat *pphy_status); -void rtl8192c_query_rx_desc_status (union recv_frame *precvframe,struct recv_stat *pdesc); -#endif
Signature · 1 line
2.53.0
Greg KH
maintainerQuoted 39 lines · Aditya Chari
rtl8192c_translate_rx_signal_stuff()andrtl8192c_query_rx_desc_status()are declared inrtl8192c_recv.hbut have no implementation and no caller anywhere in the kernel tree. They are leftover from when this driver was derived from Realtek's shared vendor codebase covering multiple chip families.Verified via grep across the full tree that neither symbol is referenced outside this declaration, and confirmed via a full build of the module before and after removal that no warnings or errors are introduced.
This addresses the "find and remove any code for other chips that is left over" item in the driver's TODO file.
Signed-off-by Aditya Chari <[email protected]>---
Changes since v2:
- Fixed placement of changelog notes below the --- marker, persubmitting-patches.rstdrivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 --- 1 file changed, 3 deletions(-)drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0
-3@@ -30,7 +30,4 @@ struct phy_stat {/* Rx smooth factor */ #define Rx_Smooth_Factor (20) -void rtl8192c_translate_rx_signal_stuff (union recv_frame *precvframe,struct phy_stat *pphy_status); -void rtl8192c_query_rx_desc_status (union recv_frame *precvframe,struct recv_stat *pdesc); -#endif Signature · 1 line
2.53.0
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- Your patch did not apply to any known trees that Greg is in control of. Possibly this is because you made it against Linus's tree, not the linux-next tree, which is where all of the development for the next version of the kernel is at. Please refresh your patch against the linux-next tree, or even better yet, the development tree specified in the MAINTAINERS file for the subsystem you are submitting a patch for, and resend it.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot