Skip to contentSkip to conversation

common: log mkfs output in _test_streams

PATCH Superseded Christoph Hellwig 2 participants 3 messages Jun 30 – Jul 1

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common: log mkfs output in _test_streams

Log the mkfs output to allow debugging the mkfs paramters, especially when mkfs and thus the test fails.

---
 common/filestreams | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/filestreams +1 -1
index 459de8c6b6a6..0b11b6644977 100644
@@ -89,7 +89,7 @@ _test_streams() {
 	# Skip these tests on zoned file systems as filestreams don't work
 	# with the zoned allocator, and the operation below would force it into
 	# the tiny data section only used for metadata anyway.
-	_try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
+	_try_scratch_mkfs_xfs >$seqres.full 2>&1 || _fail "mkfs failed"
 	_scratch_mount
 	_require_xfs_scratch_non_zoned
 	_scratch_unmount 2>/dev/null
Signature · 1 line
2.53.0
#1 lore raw
Quoted 13 lines · Christoph Hellwig

Log the mkfs output to allow debugging the mkfs paramters, especially when mkfs and thus the test fails.

---
 common/filestreams | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/filestreams +0 -0
index 459de8c6b6a6..0b11b6644977 100644

common/filestreams _test_streams() { · line 92

Quoted 5 lines
common/filestreams +1 -1
@@ -89,7 +89,7 @@ _test_streams() {
 	# Skip these tests on zoned file systems as filestreams don't work
 	# with the zoned allocator, and the operation below would force it into
 	# the tiny data section only used for metadata anyway.
-	_try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
+	_try_scratch_mkfs_xfs >$seqres.full 2>&1 || _fail "mkfs failed"

This should >>$seqres.full so that you don't obliterate whatever might already be in that file. Otherwise this sounds like a good idea to me.

--D

Quoted 7 lines
common/filestreams +0 -0
 	_scratch_mount
 	_require_xfs_scratch_non_zoned
 	_scratch_unmount 2>/dev/null
Signature · 1 line
2.53.0
#2 lore raw
Quoted 9 lines · Darrick J. Wong
Quoted 8 lines · Christoph Hellwig

Log the mkfs output to allow debugging the mkfs paramters, especially when mkfs and thus the test fails.

---
 common/filestreams | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

common/filestreams _test_streams() { · line 92

Quoted 10 lines
common/filestreams +1 -1
index 459de8c6b6a6..0b11b6644977 100644
@@ -89,7 +89,7 @@ _test_streams() {
 	# Skip these tests on zoned file systems as filestreams don't work
 	# with the zoned allocator, and the operation below would force it into
 	# the tiny data section only used for metadata anyway.
-	_try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
+	_try_scratch_mkfs_xfs >$seqres.full 2>&1 || _fail "mkfs failed"

This should >>$seqres.full so that you don't obliterate whatever might already be in that file. Otherwise this sounds like a good idea to me.

Oh, right..