Skip to contentSkip to conversation

selftests: netfilter: conntrack_resize.sh: fix skip exit code

PATCH In review Dharmik Parmar 3 participants 3 messages Jul 5 – Jul 21 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 selftests: netfilter: conntrack_resize.sh: fix skip exit code

When conntrack sysctls are unavailable, the test prints SKIP but exits with $KSFT_SKIP. lib.sh defines ksft_skip instead, so the kselftest runner did not see a proper skip.

Use ksft_skip.

Fixes d33f889fd80c ("selftests: netfilter: add conntrack stress test")
---
 tools/testing/selftests/net/netfilter/conntrack_resize.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/netfilter/conntrack_resize.sh +1 -1
index 615fe3c6f405..51564092cec4 100755
@@ -22,7 +22,7 @@ insert_count=2000
 modprobe -q nf_conntrack
 if ! sysctl -q net.netfilter.nf_conntrack_max >/dev/null;then
 	echo "SKIP: conntrack sysctls not available"
-	exit $KSFT_SKIP
+	exit $ksft_skip
 fi
 
 init_net_max=$(sysctl -n net.netfilter.nf_conntrack_max) || exit 1
Signature · 1 line
2.43.0
maintainer Acked-by on v1 1/1
#2 lore raw
Quoted 3 lines · Dharmik Parmar

When conntrack sysctls are unavailable, the test prints SKIP but exits with $KSFT_SKIP. lib.sh defines ksft_skip instead, so the kselftest runner did not see a proper skip.

maintainer
#3 lore raw
Quoted 6 lines · On Mon, 6 Jul 2026 08:53:55 +0200 Florian Westphal wrote:
Quoted 3 lines · Dharmik Parmar

When conntrack sysctls are unavailable, the test prints SKIP but exits with $KSFT_SKIP. lib.sh defines ksft_skip instead, so the kselftest runner did not see a proper skip.

This is tagged for net but FWIW & AFAIU we haven't applied it.