selftests: netfilter: conntrack_resize.sh: fix skip exit code
Subsystems (4)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 selftests: netfilter: conntrack_resize.sh: fix skip exit code
When conntrack sysctls are unavailable, the test prints SKIP but exits with $KSFT_SKIP. lib.sh defines ksft_skip instead, so the kselftest runner did not see a proper skip.
Use ksft_skip.
--- tools/testing/selftests/net/netfilter/conntrack_resize.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/netfilter/conntrack_resize.sh +1 -1
@@ -22,7 +22,7 @@ insert_count=2000 modprobe -q nf_conntrack if ! sysctl -q net.netfilter.nf_conntrack_max >/dev/null;then echo "SKIP: conntrack sysctls not available" - exit $KSFT_SKIP + exit $ksft_skip fi init_net_max=$(sysctl -n net.netfilter.nf_conntrack_max) || exit 1
Signature · 1 line
2.43.0
Quoted 3 lines · Dharmik Parmar
When conntrack sysctls are unavailable, the test prints SKIP but exits with $KSFT_SKIP.
lib.shdefinesksft_skipinstead, so the kselftest runner did not see a proper skip.
Jakub Kicinski
maintainerQuoted 6 lines · On Mon, 6 Jul 2026 08:53:55 +0200 Florian Westphal wrote:
Quoted 3 lines · Dharmik Parmar
When conntrack sysctls are unavailable, the test prints SKIP but exits with $KSFT_SKIP.
lib.shdefinesksft_skipinstead, so the kselftest runner did not see a proper skip.Acked-by Florian Westphal <[email protected]>
This is tagged for net but FWIW & AFAIU we haven't applied it.