Skip to contentSkip to conversation

arm64/pcie/pmu: Add pci id for LECARC pcie pmu

PATCH Superseded Braden Zhang 2 participants 2 messages Jul 10

Subsystems (2)

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64/pcie/pmu: Add pci id for LECARC pcie pmu

From: Brett Zhou <[email protected]>

This patch adds  for LECARC SoCs that pcie Controller IP PCI Express DM Controller pum function

---

---
 include/linux/pci_ids.h  | 1 +
 include/linux/pcie-dwc.h | 2 ++
 2 files changed, 3 insertions(+)
include/linux/pci_ids.h +1 -0
index 1c9d40e09107..1c4fd1631505 100644
@@ -173,6 +173,7 @@
 #define PCI_VENDOR_ID_DYNALINK		0x0675
 #define PCI_DEVICE_ID_DYNALINK_IS64PH	0x1702
 
+#define PCI_VENDOR_ID_LECARC            0x0720
 #define PCI_VENDOR_ID_UBIQUITI		0x0777
 
 #define PCI_VENDOR_ID_BERKOM			0x0871
include/linux/pcie-dwc.h +2 -0
index 8ff778e7aec0..1a31fe4db228 100644
@@ -32,6 +32,8 @@ static const struct dwc_pcie_vsec_id dwc_pcie_rasdes_vsec_ids[] = {
 	  .vsec_id = 0x02, .vsec_rev = 0x4 },
 	{ .vendor_id = PCI_VENDOR_ID_SAMSUNG,
 	  .vsec_id = 0x02, .vsec_rev = 0x4 },
+	{ .vendor_id = PCI_VENDOR_ID_LECARC,
+	  .vsec_id = 0x02, .vsec_rev = 0x4 },
 	{}
 };
 

---
base-commit: a635d6748234582ea287c5ffeae28b9b23f91c7e
change-id: 20260710-pcie-pmu-5ef78c56c3b6

Best regards,

Signature · 1 line
Braden Zhang <[email protected]>
#1 lore raw
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] Inconsistent whitespace formatting in include/linux/pci_ids.h. - [Low] The commit message is…

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Inconsistent whitespace formatting in include/linux/pci_ids.h.
- [Low] The commit message is incomplete and contains typos that obscure its meaning. --

--- Patch [1]: [PATCH] arm64/pcie/pmu: Add pci id for LECARC pcie pmu --- commit c0d34696455e22a889eb602a30aeaa12283c0cfb
Author: Brett Zhou <[email protected]>

arm64/pcie/pmu: Add pci id for LECARC pcie pmu

This commit adds a new PCI vendor ID for LECARC and registers it in the DWC PCIe VSEC IDs table to support the LECARC PCIe Performance Monitoring Unit.

Quoted 2 lines

This patch adds for LECARC SoCs that pcie Controller IP PCI Express DM Controller pum function

[Severity: Low]
This isn't a bug, but there appear to be a few typos and missing words in the commit message. The phrase "adds for" seems to be missing a word like "support", and "pum" is likely a typo for "pmu". Could the message be updated for clarity?

include/linux/pci_ids.h line 176

Quoted 9 lines
include/linux/pci_ids.h +1 -0
index 1c9d40e09107d..1c4fd16315054 100644
@@ -173,6 +173,7 @@
 #define PCI_VENDOR_ID_DYNALINK		0x0675
 #define PCI_DEVICE_ID_DYNALINK_IS64PH	0x1702
 
+#define PCI_VENDOR_ID_LECARC            0x0720

[Severity: Low]
This isn't a bug, but does this newly added macro use spaces instead of tabs for alignment? The rest of include/linux/pci_ids.h appears to consistently use tabs to separate the macro name and the value.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1