Skip to contentSkip to conversation

Add device tree for NVIDIA VR-NVL BMC

PATCH Superseded Jacky Huang 4 participants 8 messages Jul 10 – Jul 23

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add device tree for NVIDIA VR-NVL BMC

This series adds the DT binding compatible and the device tree for the NVIDIA VR-NVL BMC, an Aspeed AST2600-based BMC for the Vera Rubin NVL compute platform.

Changes in v3:
- dts: reword the &mac0 comment per Andrew Lunn's feedback.

Changes in v2:
- dts: correct the compatible of the PDB I/O expander at 0x75 from nxp,pca9555 to nxp,pca9539 to match the actual part.
- Pick up Acked-by from Krzysztof Kozlowski on the binding.
- Pick up Reviewed-by from Andrew Lunn on the &mac0 and &mdio0 nodes.

v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

Jacky Huang (2):
dt-bindings: arm: aspeed: Add NVIDIA VR-NVL BMC
ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

 .../bindings/arm/aspeed/aspeed.yaml           |   1 +
 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts   | 901 ++++++++++++++++++
 3 files changed, 903 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts
Signature · 1 line
2.43.0
#1 lore raw

PATCH v3 1/2 dt-bindings: arm: aspeed: Add NVIDIA VR-NVL BMC

Add NVIDIA's VR-NVL BMC board compatible.

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index dd7996960de3..ce893553cfc3 100644
@@ -114,6 +114,7 @@ properties:
               - jabil,rbp-bmc
               - nvidia,gb200nvl-bmc
               - nvidia,msx4-bmc
+              - nvidia,vr-nvl-bmc
               - qcom,dc-scm-v1-bmc
               - quanta,s6q-bmc
               - ufispace,ncplite-bmc
Signature · 1 line
2.43.0
#2 lore raw

PATCH v3 2/2 ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

In reply to Jacky Huang

Add the device tree for the Aspeed AST2600 BMC for NVIDIA's Vera Rubin NVL compute platform.

MAC0 uses phy-mode = "rgmii-id" because the on-board PHY supplies both RGMII internal delays. The matching U-Boot device tree does not enable SoC-side MAC clock delays, leaving the MAC internal delay at zero so the PHY-provided delay is not doubled by the MAC controller.

The corresponding U-Boot change has been submitted to openbmc/u-boot:

---
v3: reword the &mac0 comment per Andrew Lunn's feedback.

 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts   | 901 ++++++++++++++++++
 2 files changed, 902 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
index 6b68671f9379..07e10083a8bd 100644
@@ -65,6 +65,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-microsoft-olympus.dtb \
 	aspeed-bmc-nvidia-gb200nvl-bmc.dtb \
 	aspeed-bmc-nvidia-msx4-bmc.dtb \
+	aspeed-bmc-nvidia-vr-nvl-bmc.dtb \
 	aspeed-bmc-opp-lanyang.dtb \
 	aspeed-bmc-opp-mowgli.dtb \
 	aspeed-bmc-opp-nicole.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +901 -0

901 lines not on this page · raw message

Signature · 1 line
2.43.0
#3 lore raw

Re: [PATCH v3 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] USB device OF properties placed inside `interface@1` subnodes for standalone CP2112 devices…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] USB device OF properties placed inside interface@1 subnodes for standalone CP2112 devices (cp2112a, cp2112b), rendering their GPIO and interrupt controller properties unreachable. --

--- Patch [2]: [PATCH v3 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC --- commit a3630d8ce64970cdc226cd47ccf45d81782d9cf0
Author: Jacky Huang <[email protected]>

ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Add the device tree for the Aspeed AST2600 BMC for NVIDIA's Vera Rubin NVL compute platform.

Quoted 6 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +0 -0
new file mode 100644
index 0000000000000..197f6c5a95fe0
@@ -0,0 +1,901 @@

[ ... ]

arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts line 242

Quoted 13 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +13 -0
+				device@1 {
+					reg = <1>;
+					#address-cells = <2>;
+					#size-cells = <0>;
+
+					cp2112a: interface@1 {
+						reg = <1 1>;
+						gpio-controller;
+						#gpio-cells = <2>;
+						interrupt-controller;
+						#interrupt-cells = <2>;
+					};
+				};

[Severity: Medium]
Will these OF properties be ignored by the kernel?

Since the CP2112 is a single-interface USB device, the USB OF core uses a combined node and assigns the parent device@1 node as the of_node for the interface device. This means child interface nodes are ignored.

Additionally, the DT specifies reg = <1 1> (interface 1), but the CP2112 only has interface 0.

Should these properties be placed directly in the device node instead?

[ ... ]

arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts line 336

Quoted 13 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +13 -0
+				device@1 {
+					reg = <1>;
+					#address-cells = <2>;
+					#size-cells = <0>;
+
+					cp2112b: interface@1 {
+						reg = <1 1>;
+						gpio-controller;
+						#gpio-cells = <2>;
+						interrupt-controller;
+						#interrupt-cells = <2>;
+					};
+				};

[Severity: Medium]
Will these properties also be ignored for the same reason as cp2112a?

Should these properties be placed directly in the device node instead?

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
maintainer
#4 lore raw

Re: [PATCH v3 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

In reply to Jacky Huang

Hi Jacky,

Quoted 13 lines · Jacky Huang

Add the device tree for the Aspeed AST2600 BMC for NVIDIA's Vera Rubin NVL compute platform.

MAC0 uses phy-mode = "rgmii-id" because the on-board PHY supplies both RGMII internal delays.  The matching U-Boot device tree does not enable SoC-side MAC clock delays, leaving the MAC internal delay at zero so the PHY-provided delay is not doubled by the MAC controller.

The corresponding U-Boot change has been submitted to openbmc/u-boot:

Quoted 7 lines

---
v3: reword the &mac0 comment per Andrew Lunn's feedback.

 arch/arm/boot/dts/aspeed/Makefile             |   1 + .../aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts   | 901 ++++++++++++++++++

 2 files changed, 902 insertions(+)

 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts

We now have scripts/dtc/dt-check-style, and going forward I'm asking that all new devicetree submissions pass in strict mode.

Currently:

   $ ../scripts/dtc/dt-check-style --mode strict ../arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts 2>&1 | wc -l
   152

Can you please address those?

Andrew

#5 lore raw

Re: [PATCH v3 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Quoted 19 lines · Andrew Jeffery

Hi Jacky,

Quoted 16 lines · Jacky Huang

Add the device tree for the Aspeed AST2600 BMC for NVIDIA's Vera Rubin NVL compute platform.

MAC0 uses phy-mode = "rgmii-id" because the on-board PHY supplies both RGMII internal delays.  The matching U-Boot device tree does not enable SoC-side MAC clock delays, leaving the MAC internal delay at zero so the PHY-provided delay is not doubled by the MAC controller.

The corresponding U-Boot change has been submitted to openbmc/u-boot:

---
v3: reword the &mac0 comment per Andrew Lunn's feedback.

Quoted 7 lines
Quoted 4 lines

 arch/arm/boot/dts/aspeed/Makefile             |   1 + .../aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts   | 901 ++++++++++++++++++

 2 files changed, 902 insertions(+)

 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts

We now have scripts/dtc/dt-check-style, and going forward I'm asking that all new devicetree submissions pass in strict mode.

Thanks!

Quoted 7 lines

Currently:

   $ ../scripts/dtc/dt-check-style --mode strict ../arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts 2>&1 | wc -l
   152

Can you please address those?

Just a note: --strict might not be ready yet. It reports some false positives which need addressing (I have plans for this, but busy with other things...), so expectation currently is:
1. No warnings from standard mode
2. Review and investigate warnings from 'strict' mode, but do not fix them automatically without thinking

Best regards,
Krzysztof

maintainer
#6 lore raw

Re: [PATCH v3 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Quoted 36 lines · Krzysztof Kozlowski
Quoted 19 lines · Andrew Jeffery

Hi Jacky,

Quoted 16 lines · Jacky Huang

Add the device tree for the Aspeed AST2600 BMC for NVIDIA's Vera Rubin NVL compute platform.

MAC0 uses phy-mode = "rgmii-id" because the on-board PHY supplies both RGMII internal delays.  The matching U-Boot device tree does not enable SoC-side MAC clock delays, leaving the MAC internal delay at zero so the PHY-provided delay is not doubled by the MAC controller.

The corresponding U-Boot change has been submitted to openbmc/u-boot:

---
v3: reword the &mac0 comment per Andrew Lunn's feedback.

Quoted 7 lines
Quoted 4 lines

 arch/arm/boot/dts/aspeed/Makefile             |   1 + .../aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts   | 901 ++++++++++++++++++

 2 files changed, 902 insertions(+)

 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts

We now have scripts/dtc/dt-check-style, and going forward I'm asking that all new devicetree submissions pass in strict mode.

Thanks!

Quoted 6 lines

Currently:

   $ ../scripts/dtc/dt-check-style --mode strict ../arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts 2>&1 | wc -l
   152
Quoted 8 lines
Quoted 1 line

Can you please address those?

Just a note: --strict might not be ready yet. It reports some false positives which need addressing (I have plans for this, but busy with other things...), so expectation currently is:
1. No warnings from standard mode
2. Review and investigate warnings from 'strict' mode, but do not fix them automatically without thinking

Understood.

Thanks,

Andrew

#7 lore raw

Re: [PATCH v3 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Hi Andrew and Krzysztof,

Appreciate the guidance and clarification! I will address the warnings and prepare the next version.

Thanks,
Jacky