Skip to contentSkip to conversation

common: log mkfs output in _test_streams

PATCH In review Christoph Hellwig 2 participants 2 messages Jul 10

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 common: log mkfs output in _test_streams

Log the mkfs output to allow debugging the mkfs paramters, especially when mkfs and thus the test fails.

---

Changes since v2:
- really append to the log

 common/filestreams | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/filestreams +1 -1
index 838b5921520a..cce7599817cd 100644
@@ -89,7 +89,7 @@ _test_streams() {
 	# Skip these tests on zoned file systems as filestreams don't work
 	# with the zoned allocator, and the operation below would force it into
 	# the tiny data section only used for metadata anyway.
-	_try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
+	_try_scratch_mkfs_xfs >>$seqres.full 2>&1 || _fail "mkfs failed"
 	_scratch_mount
 	_require_xfs_scratch_non_zoned
 	_scratch_unmount 2>/dev/null
Signature · 1 line
2.53.0
Reviewed-by on v3 1/1
#1 lore raw
Quoted 17 lines · Christoph Hellwig

Log the mkfs output to allow debugging the mkfs paramters, especially when mkfs and thus the test fails.

---

Changes since v2:
- really append to the log

 common/filestreams | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/filestreams +0 -0
index 838b5921520a..cce7599817cd 100644

common/filestreams _test_streams() { · line 92

Quoted 5 lines
common/filestreams +1 -1
@@ -89,7 +89,7 @@ _test_streams() {
 	# Skip these tests on zoned file systems as filestreams don't work
 	# with the zoned allocator, and the operation below would force it into
 	# the tiny data section only used for metadata anyway.
-	_try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
+	_try_scratch_mkfs_xfs >>$seqres.full 2>&1 || _fail "mkfs failed"

Woot!

--D

Quoted 6 lines
common/filestreams +0 -0
 	_scratch_mount
 	_require_xfs_scratch_non_zoned
 	_scratch_unmount 2>/dev/null
Signature · 1 line
2.53.0