Skip to contentSkip to conversation

MAINTAINERS: Mark sections orphaned

PATCH In review Markus Armbruster 6 participants 19 messages Jul 10 – Jul 15

lore
Share & tools
lore
#0 lore raw

cover MAINTAINERS: Mark sections orphaned

"S: Supported" without an M: makes no sense. Change to S: Orphan.

If you want them to remain supported, please find a maintainer.

We could do "S: Odd fixes" for "vhost-user-scmi", since it has an R:. Milan, you decide.

Markus Armbruster (2):
MAINTAINERS: Mark "Microchip PolarFire SoC Icicle Kit" orphaned
MAINTAINERS: Mark "vhost-user-scmi" orphaned

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.54.0
#1 lore raw

PATCH 1/2 MAINTAINERS: Mark "Microchip PolarFire SoC Icicle Kit" orphaned

Commit 4a16a1a7ad (MAINTAINERS: Remove Bin Meng from RISC-V maintainers, 2025-01-28) removed the only M:, but left S: Supported. This makes no sense. Downgrade to S: Orphan.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 576ef6fff5..aa2df9cbe3 100644
@@ -1761,7 +1761,7 @@ F: tests/tcg/riscv64/test-crc32.S
 
 Microchip PolarFire SoC Icicle Kit
 L: [email protected]
-S: Supported
+S: Orphan
 F: docs/system/riscv/microchip-icicle-kit.rst
 F: hw/riscv/microchip_pfsoc.c
 F: hw/char/mchp_pfsoc_mmuart.c
Signature · 1 line
2.54.0
#2 lore raw

Re: [PATCH 1/2] MAINTAINERS: Mark "Microchip PolarFire SoC Icicle Kit" orphaned

Quoted 15 lines · Markus Armbruster

Commit 4a16a1a7ad (MAINTAINERS: Remove Bin Meng from RISC-V maintainers, 2025-01-28) removed the only M:, but left S: Supported. This makes no sense. Downgrade to S: Orphan.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index 576ef6fff5..aa2df9cbe3 100644

MAINTAINERS F: tests/tcg/riscv64/test-crc32.S

Quoted 9 lines
MAINTAINERS +1 -2
@@ -1761,7 +1761,7 @@ F: tests/tcg/riscv64/test-crc32.S
 
 Microchip PolarFire SoC Icicle Kit
 L: [email protected]
-S: Supported
+S: Orphan
 F: docs/system/riscv/microchip-icicle-kit.rst
 F: hw/riscv/microchip_pfsoc.c
 F: hw/char/mchp_pfsoc_mmuart.c
--

I plan to send a patch series to resurrect PolarFire SoC support.

Regards,
Bin

#3 lore raw

Re: [PATCH 1/2] MAINTAINERS: Mark "Microchip PolarFire SoC Icicle Kit" orphaned

Quoted 17 lines · Bin Meng
Quoted 16 lines · Markus Armbruster

Commit 4a16a1a7ad (MAINTAINERS: Remove Bin Meng from RISC-V maintainers, 2025-01-28) removed the only M:, but left S: Supported. This makes no sense. Downgrade to S: Orphan.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index 576ef6fff5..aa2df9cbe3 100644
@@ -1761,7 +1761,7 @@ F: tests/tcg/riscv64/test-crc32.S
 
Quoted 10 lines

MAINTAINERS F: tests/tcg/riscv64/test-crc32.S

Quoted 8 lines
MAINTAINERS +1 -2
 Microchip PolarFire SoC Icicle Kit
 L: [email protected]
-S: Supported
+S: Orphan
 F: docs/system/riscv/microchip-icicle-kit.rst
 F: hw/riscv/microchip_pfsoc.c
 F: hw/char/mchp_pfsoc_mmuart.c
--

I plan to send a patch series to resurrect PolarFire SoC support.

What does this resurrection constitute? The files aren't gone anywhere (yet, at least), so I take it you mean you'll be actively working on the platform?

#4 lore raw

Re: [PATCH 1/2] MAINTAINERS: Mark "Microchip PolarFire SoC Icicle Kit" orphaned

Quoted 30 lines · Conor Dooley
Quoted 17 lines · Bin Meng
Quoted 16 lines · Markus Armbruster

Commit 4a16a1a7ad (MAINTAINERS: Remove Bin Meng from RISC-V maintainers, 2025-01-28) removed the only M:, but left S: Supported. This makes no sense. Downgrade to S: Orphan.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index 576ef6fff5..aa2df9cbe3 100644
@@ -1761,7 +1761,7 @@ F: tests/tcg/riscv64/test-crc32.S
 
Quoted 10 lines

MAINTAINERS F: tests/tcg/riscv64/test-crc32.S

Quoted 8 lines
MAINTAINERS +1 -2
 Microchip PolarFire SoC Icicle Kit
 L: [email protected]
-S: Supported
+S: Orphan
 F: docs/system/riscv/microchip-icicle-kit.rst
 F: hw/riscv/microchip_pfsoc.c
 F: hw/char/mchp_pfsoc_mmuart.c
--

I plan to send a patch series to resurrect PolarFire SoC support.

Quoted 3 lines

What does this resurrection constitute? The files aren't gone anywhere (yet, at least), so I take it you mean you'll be actively working on the platform?

Yes, I will rework HSS boot support to accommodate newer versions, just as HSS was originally supported years ago.

Regards,
Bin

#5 lore raw

Re: [PATCH 1/2] MAINTAINERS: Mark "Microchip PolarFire SoC Icicle Kit" orphaned

In reply to Bin Meng
Quoted 17 lines · Bin Meng
Quoted 16 lines · Markus Armbruster

Commit 4a16a1a7ad (MAINTAINERS: Remove Bin Meng from RISC-V maintainers, 2025-01-28) removed the only M:, but left S: Supported. This makes no sense. Downgrade to S: Orphan.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index 576ef6fff5..aa2df9cbe3 100644
@@ -1761,7 +1761,7 @@ F: tests/tcg/riscv64/test-crc32.S
 
Quoted 10 lines

MAINTAINERS F: tests/tcg/riscv64/test-crc32.S

Quoted 8 lines
MAINTAINERS +1 -2
 Microchip PolarFire SoC Icicle Kit
 L: [email protected]
-S: Supported
+S: Orphan
 F: docs/system/riscv/microchip-icicle-kit.rst
 F: hw/riscv/microchip_pfsoc.c
 F: hw/char/mchp_pfsoc_mmuart.c
--

I plan to send a patch series to resurrect PolarFire SoC support.

Nice! Please re-add yourself to MAINTAINERS then.

#6 lore raw

Re: [PATCH 1/2] MAINTAINERS: Mark "Microchip PolarFire SoC Icicle Kit" orphaned

In reply to Markus Armbruster
Quoted 14 lines · Markus Armbruster

Commit 4a16a1a7ad (MAINTAINERS: Remove Bin Meng from RISC-V maintainers, 2025-01-28) removed the only M:, but left S: Supported. This makes no sense. Downgrade to S: Orphan.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index 576ef6fff5..aa2df9cbe3 100644

MAINTAINERS F: tests/tcg/riscv64/test-crc32.S · line 1764

Quoted 5 lines
MAINTAINERS +1 -1
@@ -1761,7 +1761,7 @@ F: tests/tcg/riscv64/test-crc32.S
 
 Microchip PolarFire SoC Icicle Kit
 L: [email protected]
-S: Supported
+S: Orphan

This should have been updated in:
https://lore.kernel.org/qemu-devel/[email protected]/

Alistair said he applied that patch, so I'm guessing whatever tree you've based on doesn't include it yet?

Cheers,
Conor.

Quoted 7 lines
MAINTAINERS +0 -0
 F: docs/system/riscv/microchip-icicle-kit.rst
 F: hw/riscv/microchip_pfsoc.c
 F: hw/char/mchp_pfsoc_mmuart.c
Signature · 1 line
2.54.0
#7 lore raw

Re: [PATCH 1/2] MAINTAINERS: Mark "Microchip PolarFire SoC Icicle Kit" orphaned

Quoted 25 lines · Conor Dooley
Quoted 18 lines · Markus Armbruster

Commit 4a16a1a7ad (MAINTAINERS: Remove Bin Meng from RISC-V maintainers, 2025-01-28) removed the only M:, but left S:
Supported.
This makes no sense.  Downgrade to S: Orphan.

---
 MAINTAINERS | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index 576ef6fff5..aa2df9cbe3 100644
@@ -1761,7 +1761,7 @@ F: tests/tcg/riscv64/test-crc32.S


 Microchip PolarFire SoC Icicle Kit
 L: [email protected]

MAINTAINERS F: tests/tcg/riscv64/test-crc32.S · line 1764

Quoted 2 lines
MAINTAINERS +1 -1
-S: Supported
+S: Orphan

This should have been updated in:
https://lore.kernel.org/qemu-devel/[email protected]/

Quoted 3 lines

Alistair said he applied that patch, so I'm guessing whatever tree you've
based on doesn't include it yet?

Yeah, I thought I applied it. But somehow it seems to have disappeared....

I think this patch should be dropped and I'll actually apply:
https://lore.kernel.org/qemu-devel/[email protected]/

Then Bin can update this in the future if you want to.

Sorry about the confusion here

Alistair

Quoted 11 lines

Cheers,
Conor.

Quoted 7 lines

 F: docs/system/riscv/microchip-icicle-kit.rst
 F: hw/riscv/microchip_pfsoc.c
 F: hw/char/mchp_pfsoc_mmuart.c

Signature · 1 line
2.54.0
#8 lore raw

Re: [PATCH 1/2] MAINTAINERS: Mark "Microchip PolarFire SoC Icicle Kit" orphaned

Quoted 30 lines · Alistair
Quoted 25 lines · Conor Dooley
Quoted 18 lines · Markus Armbruster

Commit 4a16a1a7ad (MAINTAINERS: Remove Bin Meng from RISC-V maintainers, 2025-01-28) removed the only M:, but left S:
Supported.
This makes no sense.  Downgrade to S: Orphan.

---
 MAINTAINERS | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index 576ef6fff5..aa2df9cbe3 100644
@@ -1761,7 +1761,7 @@ F: tests/tcg/riscv64/test-crc32.S


 Microchip PolarFire SoC Icicle Kit
 L: [email protected]

MAINTAINERS F: tests/tcg/riscv64/test-crc32.S · line 1764

Quoted 2 lines
MAINTAINERS +1 -1
-S: Supported
+S: Orphan

This should have been updated in:
https://lore.kernel.org/qemu-devel/[email protected]/

Quoted 3 lines

Alistair said he applied that patch, so I'm guessing whatever tree you've
based on doesn't include it yet?

Quoted 6 lines

Yeah, I thought I applied it. But somehow it seems to have disappeared....

I think this patch should be dropped and I'll actually apply:
https://lore.kernel.org/qemu-devel/[email protected]/

Makes sense, thanks!

Quoted 5 lines

Then Bin can update this in the future if you want to.

Sorry about the confusion here

Alistair

#9 lore raw

PATCH 2/2 MAINTAINERS: Mark "vhost-user-scmi" orphaned

In reply to Markus Armbruster

Commit a5dab090e1 (hw/virtio: Add boilerplate for vhost-user-scmi device, 2023-06-28) added the section with S: Supported, but no M:. This makes no sense. Downgrade to S: Orphan.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index aa2df9cbe3..4d558ddee9 100644
@@ -2622,7 +2622,7 @@ F: include/hw/virtio/vhost-user-snd.h
 
 vhost-user-scmi
 R: Milan Zamazal <[email protected]>
-S: Supported
+S: Orphan
 F: hw/virtio/vhost-user-scmi*
 F: include/hw/virtio/vhost-user-scmi.h
 F: tests/qtest/libqos/virtio-scmi.*
Signature · 1 line
2.54.0
#10 lore raw

Re: [PATCH 2/2] MAINTAINERS: Mark "vhost-user-scmi" orphaned

Quoted 5 lines · Markus Armbruster

Commit a5dab090e1 (hw/virtio: Add boilerplate for vhost-user-scmi device, 2023-06-28) added the section with S: Supported, but no M:. This makes no sense. Downgrade to S: Orphan.

No, this makes sense. The reason this section was added is so that Milan can get copied on vhost-user-scmi but not other virtio stuff:

./scripts/get_maintainer.pl -f hw/virtio/vhost-user-scmi.c Milan Zamazal <[email protected]> (reviewer:vhost-user-scmi) "Michael S. Tsirkin" <[email protected]> (supporter:vhost) Stefano Garzarella <[email protected]> (reviewer:vhost) [email protected] (open list:All patches CC here)

Pls drop this patch.

Quoted 19 lines
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index aa2df9cbe3..4d558ddee9 100644
@@ -2622,7 +2622,7 @@ F: include/hw/virtio/vhost-user-snd.h
 
 vhost-user-scmi
 R: Milan Zamazal <[email protected]>
-S: Supported
+S: Orphan
 F: hw/virtio/vhost-user-scmi*
 F: include/hw/virtio/vhost-user-scmi.h
 F: tests/qtest/libqos/virtio-scmi.*
Signature · 1 line
2.54.0
#11 lore raw

Re: [PATCH 2/2] MAINTAINERS: Mark "vhost-user-scmi" orphaned

Quoted 10 lines · Michael S. Tsirkin
Quoted 5 lines · Markus Armbruster

Commit a5dab090e1 (hw/virtio: Add boilerplate for vhost-user-scmi device, 2023-06-28) added the section with S: Supported, but no M:. This makes no sense. Downgrade to S: Orphan.

No, this makes sense. The reason this section was added is so that Milan can get copied on vhost-user-scmi but not other virtio stuff:

The section's S: is confusing.

Quoted 7 lines

./scripts/get_maintainer.pl -f hw/virtio/vhost-user-scmi.c Milan Zamazal <[email protected]> (reviewer:vhost-user-scmi) "Michael S. Tsirkin" <[email protected]> (supporter:vhost) Stefano Garzarella <[email protected]> (reviewer:vhost) [email protected] (open list:All patches CC here)

Pls drop this patch.

Done.

#12 lore raw

Re: [PATCH 2/2] MAINTAINERS: Mark "vhost-user-scmi" orphaned

In reply to Michael S. Tsirkin
Quoted 23 lines · Michael S. Tsirkin
Quoted 5 lines · Markus Armbruster

Commit a5dab090e1 (hw/virtio: Add boilerplate for vhost-user-scmi device, 2023-06-28) added the section with S: Supported, but no M:. This makes no sense. Downgrade to S: Orphan.

No, this makes sense. The reason this section was added is so that Milan can get copied on vhost-user-scmi but not other virtio stuff:

./scripts/get_maintainer.pl -f hw/virtio/vhost-user-scmi.c Milan Zamazal <[email protected]> (reviewer:vhost-user-scmi) "Michael S. Tsirkin" <[email protected]> (supporter:vhost) Stefano Garzarella <[email protected]> (reviewer:vhost) [email protected] (open list:All patches CC here)

Pls drop this patch.

Quoted 4 lines
---
  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines

MAINTAINERS F: include/hw/virtio/vhost-user-snd.h · line 2623

Quoted 7 lines
MAINTAINERS +0 -0
index aa2df9cbe3..4d558ddee9 100644
@@ -2622,7 +2622,7 @@ F: include/hw/virtio/vhost-user-snd.h
 
  vhost-user-scmi

So what we want is to add here:

M: Michael S. Tsirkin <[email protected]>
R: Stefano Garzarella <[email protected]>

Quoted 10 lines
Quoted 8 lines
MAINTAINERS +1 -1
  R: Milan Zamazal <[email protected]>
-S: Supported
+S: Orphan
  F: hw/virtio/vhost-user-scmi*
  F: include/hw/virtio/vhost-user-scmi.h
  F: tests/qtest/libqos/virtio-scmi.*
Signature · 1 line
2.54.0
#13 lore raw

Re: [PATCH 2/2] MAINTAINERS: Mark "vhost-user-scmi" orphaned

Quoted 33 lines · Philippe Mathieu-Daudé
Quoted 23 lines · Michael S. Tsirkin
Quoted 5 lines · Markus Armbruster

Commit a5dab090e1 (hw/virtio: Add boilerplate for vhost-user-scmi device, 2023-06-28) added the section with S: Supported, but no M:. This makes no sense. Downgrade to S: Orphan.

No, this makes sense. The reason this section was added is so that Milan can get copied on vhost-user-scmi but not other virtio stuff:

./scripts/get_maintainer.pl -f hw/virtio/vhost-user-scmi.c Milan Zamazal <[email protected]> (reviewer:vhost-user-scmi) "Michael S. Tsirkin" <[email protected]> (supporter:vhost) Stefano Garzarella <[email protected]> (reviewer:vhost) [email protected] (open list:All patches CC here)

Pls drop this patch.

Quoted 4 lines
---
  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines

MAINTAINERS F: include/hw/virtio/vhost-user-snd.h · line 2622

Quoted 6 lines
MAINTAINERS +0 -0
index aa2df9cbe3..4d558ddee9 100644
@@ -2622,7 +2622,7 @@ F: include/hw/virtio/vhost-user-snd.h
  vhost-user-scmi

So what we want is to add here:

Quoted 2 lines

M: Michael S. Tsirkin <[email protected]>
R: Stefano Garzarella <[email protected]>

But these files already get M from the match against hw/virtio/ - what am I missing?

Quoted 10 lines
Quoted 10 lines
Quoted 8 lines
MAINTAINERS +1 -1
  R: Milan Zamazal <[email protected]>
-S: Supported
+S: Orphan
  F: hw/virtio/vhost-user-scmi*
  F: include/hw/virtio/vhost-user-scmi.h
  F: tests/qtest/libqos/virtio-scmi.*
Signature · 1 line
2.54.0
#14 lore raw

Re: [PATCH 2/2] MAINTAINERS: Mark "vhost-user-scmi" orphaned

Quoted 34 lines · Michael S. Tsirkin
Quoted 33 lines · Philippe Mathieu-Daudé
Quoted 23 lines · Michael S. Tsirkin
Quoted 5 lines · Markus Armbruster

Commit a5dab090e1 (hw/virtio: Add boilerplate for vhost-user-scmi device, 2023-06-28) added the section with S: Supported, but no M:. This makes no sense. Downgrade to S: Orphan.

No, this makes sense. The reason this section was added is so that Milan can get copied on vhost-user-scmi but not other virtio stuff:

./scripts/get_maintainer.pl -f hw/virtio/vhost-user-scmi.c Milan Zamazal <[email protected]> (reviewer:vhost-user-scmi) "Michael S. Tsirkin" <[email protected]> (supporter:vhost) Stefano Garzarella <[email protected]> (reviewer:vhost) [email protected] (open list:All patches CC here)

Pls drop this patch.

Quoted 4 lines
---
   MAINTAINERS | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines

MAINTAINERS F: include/hw/virtio/vhost-user-snd.h · line 2622

Quoted 6 lines
MAINTAINERS +0 -0
index aa2df9cbe3..4d558ddee9 100644
@@ -2622,7 +2622,7 @@ F: include/hw/virtio/vhost-user-snd.h
   vhost-user-scmi

So what we want is to add here:

Quoted 5 lines
Quoted 2 lines

M: Michael S. Tsirkin <[email protected]>
R: Stefano Garzarella <[email protected]>

But these files already get M from the match against hw/virtio/ - what am I missing?

Yeah, just trying to make Markus script happy ;)

Quoted 13 lines
Quoted 11 lines
Quoted 11 lines
Quoted 9 lines
MAINTAINERS +1 -1
   R: Milan Zamazal <[email protected]>
-S: Supported
+S: Orphan
   F: hw/virtio/vhost-user-scmi*
   F: include/hw/virtio/vhost-user-scmi.h
   F: tests/qtest/libqos/virtio-scmi.*
Signature · 1 line
2.54.0
#15 lore raw

Re: [PATCH 2/2] MAINTAINERS: Mark "vhost-user-scmi" orphaned

Quoted 35 lines · Philippe Mathieu-Daudé
Quoted 34 lines · Michael S. Tsirkin
Quoted 33 lines · Philippe Mathieu-Daudé
Quoted 23 lines · Michael S. Tsirkin
Quoted 5 lines · Markus Armbruster

Commit a5dab090e1 (hw/virtio: Add boilerplate for vhost-user-scmi device, 2023-06-28) added the section with S: Supported, but no M:. This makes no sense. Downgrade to S: Orphan.

No, this makes sense. The reason this section was added is so that Milan can get copied on vhost-user-scmi but not other virtio stuff:

./scripts/get_maintainer.pl -f hw/virtio/vhost-user-scmi.c Milan Zamazal <[email protected]> (reviewer:vhost-user-scmi) "Michael S. Tsirkin" <[email protected]> (supporter:vhost) Stefano Garzarella <[email protected]> (reviewer:vhost) [email protected] (open list:All patches CC here)

Pls drop this patch.

Quoted 4 lines
---
   MAINTAINERS | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines

MAINTAINERS F: include/hw/virtio/vhost-user-snd.h · line 2622

Quoted 6 lines
MAINTAINERS +0 -0
index aa2df9cbe3..4d558ddee9 100644
@@ -2622,7 +2622,7 @@ F: include/hw/virtio/vhost-user-snd.h
   vhost-user-scmi

So what we want is to add here:

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

M: Michael S. Tsirkin <[email protected]>
R: Stefano Garzarella <[email protected]>

But these files already get M from the match against hw/virtio/ - what am I missing?

Yeah, just trying to make Markus script happy ;)

I don't mind though the duplication is a bit annoying. But let's pls document what the rules are somewhere then.

Quoted 13 lines
Quoted 13 lines
Quoted 11 lines
Quoted 11 lines
Quoted 9 lines
MAINTAINERS +1 -1
   R: Milan Zamazal <[email protected]>
-S: Supported
+S: Orphan
   F: hw/virtio/vhost-user-scmi*
   F: include/hw/virtio/vhost-user-scmi.h
   F: tests/qtest/libqos/virtio-scmi.*
Signature · 1 line
2.54.0
#16 lore raw

Re: [PATCH 2/2] MAINTAINERS: Mark "vhost-user-scmi" orphaned

In reply to Philippe Mathieu-Daudé
Quoted 35 lines · Philippe Mathieu-Daudé
Quoted 34 lines · Michael S. Tsirkin
Quoted 33 lines · Philippe Mathieu-Daudé
Quoted 23 lines · Michael S. Tsirkin
Quoted 5 lines · Markus Armbruster

Commit a5dab090e1 (hw/virtio: Add boilerplate for vhost-user-scmi device, 2023-06-28) added the section with S: Supported, but no M:. This makes no sense. Downgrade to S: Orphan.

No, this makes sense. The reason this section was added is so that Milan can get copied on vhost-user-scmi but not other virtio stuff:

./scripts/get_maintainer.pl -f hw/virtio/vhost-user-scmi.c Milan Zamazal <[email protected]> (reviewer:vhost-user-scmi) "Michael S. Tsirkin" <[email protected]> (supporter:vhost) Stefano Garzarella <[email protected]> (reviewer:vhost) [email protected] (open list:All patches CC here)

Pls drop this patch.

Quoted 4 lines
---
   MAINTAINERS | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines

MAINTAINERS F: include/hw/virtio/vhost-user-snd.h · line 2622

Quoted 6 lines
MAINTAINERS +0 -0
index aa2df9cbe3..4d558ddee9 100644
@@ -2622,7 +2622,7 @@ F: include/hw/virtio/vhost-user-snd.h
   vhost-user-scmi

So what we want is to add here:

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

M: Michael S. Tsirkin <[email protected]>
R: Stefano Garzarella <[email protected]>

But these files already get M from the match against hw/virtio/ - what am I missing?

Yeah, just trying to make Markus script happy ;)

Appreciate the kindness!

In decreasing importance:

1. Correct get_maintainers.pl output

2. Legible MAINTAINERS

99. My script is happy.

[...]

#17 lore raw

Re: [PATCH 2/2] MAINTAINERS: Mark "vhost-user-scmi" orphaned

Quoted 43 lines · Markus Armbruster
Quoted 41 lines · Philippe Mathieu-Daudé
Quoted 39 lines · Michael S. Tsirkin
Quoted 33 lines · Philippe Mathieu-Daudé
Quoted 23 lines · Michael S. Tsirkin
Quoted 5 lines · Markus Armbruster

Commit a5dab090e1 (hw/virtio: Add boilerplate for vhost-user-scmi device, 2023-06-28) added the section with S: Supported, but no M:. This makes no sense. Downgrade to S: Orphan.

No, this makes sense. The reason this section was added is so that Milan can get copied on vhost-user-scmi but not other virtio stuff:

./scripts/get_maintainer.pl -f hw/virtio/vhost-user-scmi.c Milan Zamazal <[email protected]> (reviewer:vhost-user-scmi) "Michael S. Tsirkin" <[email protected]> (supporter:vhost) Stefano Garzarella <[email protected]> (reviewer:vhost) [email protected] (open list:All patches CC here)

Pls drop this patch.

Quoted 4 lines
---
   MAINTAINERS | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines

MAINTAINERS F: include/hw/virtio/vhost-user-snd.h · line 2622

Quoted 6 lines
MAINTAINERS +0 -0
index aa2df9cbe3..4d558ddee9 100644
@@ -2622,7 +2622,7 @@ F: include/hw/virtio/vhost-user-snd.h
   vhost-user-scmi

So what we want is to add here:

Quoted 2 lines

M: Michael S. Tsirkin <[email protected]>
R: Stefano Garzarella <[email protected]>

But these files already get M from the match against hw/virtio/ - what am I missing?

Quoted 7 lines
Quoted 1 line

Yeah, just trying to make Markus script happy ;)

Appreciate the kindness!

In decreasing importance:

1. Correct get_maintainers.pl output

Is anything wrong with it?

Quoted 1 line

2. Legible MAINTAINERS

We can always come up with a new rule for such cases, where we have a reviewer just for some specific files in a project, but the supporters are from the bigger project.

How about we drop S: completely in such cases?

We can also tweak the name:
vhost-user-scmi (part of vhost)

Quoted 3 lines

99. My script is happy.

[...]

#18 lore raw

Re: [PATCH 2/2] MAINTAINERS: Mark "vhost-user-scmi" orphaned

Quoted 46 lines · Michael S. Tsirkin
Quoted 45 lines · Markus Armbruster
Quoted 42 lines · Philippe Mathieu-Daudé
Quoted 34 lines · Michael S. Tsirkin
Quoted 33 lines · Philippe Mathieu-Daudé
Quoted 23 lines · Michael S. Tsirkin
Quoted 5 lines · Markus Armbruster

Commit a5dab090e1 (hw/virtio: Add boilerplate for vhost-user-scmi device, 2023-06-28) added the section with S: Supported, but no M:. This makes no sense. Downgrade to S: Orphan.

No, this makes sense. The reason this section was added is so that Milan can get copied on vhost-user-scmi but not other virtio stuff:

./scripts/get_maintainer.pl -f hw/virtio/vhost-user-scmi.c Milan Zamazal <[email protected]> (reviewer:vhost-user-scmi) "Michael S. Tsirkin" <[email protected]> (supporter:vhost) Stefano Garzarella <[email protected]> (reviewer:vhost) [email protected] (open list:All patches CC here)

Pls drop this patch.

Quoted 4 lines
---
   MAINTAINERS | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines

MAINTAINERS F: include/hw/virtio/vhost-user-snd.h · line 2622

Quoted 6 lines
MAINTAINERS +0 -0
index aa2df9cbe3..4d558ddee9 100644
@@ -2622,7 +2622,7 @@ F: include/hw/virtio/vhost-user-snd.h
   vhost-user-scmi

So what we want is to add here:

Quoted 5 lines
Quoted 2 lines

M: Michael S. Tsirkin <[email protected]>
R: Stefano Garzarella <[email protected]>

But these files already get M from the match against hw/virtio/ - what am I missing?

Yeah, just trying to make Markus script happy ;)

Quoted 7 lines
Quoted 5 lines

Appreciate the kindness!

In decreasing importance:

1. Correct get_maintainers.pl output

Is anything wrong with it?

No, it looks good to me.

Quoted 8 lines
Quoted 1 line

2. Legible MAINTAINERS

We can always come up with a new rule for such cases, where we have a reviewer just for some specific files in a project, but the supporters are from the bigger project.

How about we drop S: completely in such cases?

Could that be differently confusing? Honest question!

1. Correct get_maintainers.pl output

Appears to be fine. As far as I can tell, it accumulates S: for all matching sections. A matching section without S: should be harmless as long as another matching section provides one.

By the way, this is another reason why my patch was bad. The S:
Orphan gets accumulated, and can lead to problematic output, e.g.

    $ scripts/get_maintainer.pl --status -f hw/virtio/vhost-user-scmi.c 
    Milan Zamazal <[email protected]> (reviewer:vhost-user-scmi)
    "Michael S. Tsirkin" <[email protected]> (supporter:vhost)
    Stefano Garzarella <[email protected]> (reviewer:vhost)
    [email protected] (open list:All patches CC here)
    Orphan
    Supported

2. Legible MAINTAINERS

S: Supported is without supporters is mildly confusing unless you understand that the supporters are listed elsewhere. Evidence: it confused me.

No S: looks like we forgot to add it. Feels less bad to me, but I might be biased. Could it use a comment? Not sure.

Hmm, S: Supported could even be misleading. Say Milan had agreed to look after this in his spare time. That's status Maintained. We'd use M: to record his commitment. But what S: to use?

S: Maintained gives M: the correct meaning, but mislead readers about the status of the matched files: these are still Supported.

S: Supported is locally correct about the status of the matched files, but misleads about the M:.

I think in this case we'd use M: Maintained as the lesser evil.

The reliable way to find out status is running get_maintainers.pl.

Quoted 2 lines

We can also tweak the name:
vhost-user-scmi (part of vhost)

I guess the "vhost-" in "vhost-user-scmi" is enough of a hint.

Quoted 3 lines
Quoted 3 lines

99. My script is happy.

[...]