Skip to contentSkip to conversation

powerpc/ps3: Remove unused struct table in setup_areas()

PATCH Applied Thorsten Blum 5 participants 5 messages Jul 13 – Jul 30

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 powerpc/ps3: Remove unused struct table in setup_areas()

The local table structure is not used - remove it.

---
Changes in v2:
- Drop the %0 change because it is valid kernel-doc markup (Amit)
- v1: https://lore.kernel.org/r/[email protected]/

---
 arch/powerpc/platforms/ps3/spu.c | 2 --
 1 file changed, 2 deletions(-)
arch/powerpc/platforms/ps3/spu.c +0 -2
index e817def7f424..2c785bc72565 100644
@@ -190,8 +190,6 @@ static void spu_unmap(struct spu *spu)
 
 static int __init setup_areas(struct spu *spu)
 {
-	struct table {char* name; unsigned long addr; unsigned long size;};
-
 	spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
 					      sizeof(struct spe_shadow),
 					      pgprot_noncached_wc(PAGE_KERNEL_RO));
Reviewed-by on v2 1/1
#1 lore raw
Quoted 7 lines · Thorsten Blum

The local table structure is not used - remove it.

---
Changes in v2:
- Drop the %0 change because it is valid kernel-doc markup (Amit)

Thanks for addressing the comment and sending a v2!

~Amit

Quoted 18 lines

- v1: https://lore.kernel.org/r/[email protected]/

---
 arch/powerpc/platforms/ps3/spu.c | 2 --
 1 file changed, 2 deletions(-)
arch/powerpc/platforms/ps3/spu.c +0 -2
index e817def7f424..2c785bc72565 100644
@@ -190,8 +190,6 @@ static void spu_unmap(struct spu *spu)
 
 static int __init setup_areas(struct spu *spu)
 {
-	struct table {char* name; unsigned long addr; unsigned long size;};
-
 	spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
 					      sizeof(struct spe_shadow),
 					      pgprot_noncached_wc(PAGE_KERNEL_RO));
reviewer Reviewed-by on v2 1/1
#3 lore raw
In reply to Thorsten Blum

Le 13/07/2026 à 11:17, Thorsten Blum a écrit :

Quoted 4 lines

The local table structure is not used - remove it.

Quoted 21 lines

---
Changes in v2:
- Drop the %0 change because it is valid kernel-doc markup (Amit)
- v1: https://lore.kernel.org/r/[email protected]/

---
  arch/powerpc/platforms/ps3/spu.c | 2 --
  1 file changed, 2 deletions(-)
arch/powerpc/platforms/ps3/spu.c +0 -2
index e817def7f424..2c785bc72565 100644
@@ -190,8 +190,6 @@ static void spu_unmap(struct spu *spu)
 
  static int __init setup_areas(struct spu *spu)
  {
-	struct table {char* name; unsigned long addr; unsigned long size;};
-
  	spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
  					      sizeof(struct spe_shadow),
  					      pgprot_noncached_wc(PAGE_KERNEL_RO));