powerpc/ps3: Remove unused struct table in setup_areas()
Subsystems (2)
PATCH v2 1/1 powerpc/ps3: Remove unused struct table in setup_areas()
The local table structure is not used - remove it.
---
Changes in v2:
- Drop the %0 change because it is valid kernel-doc markup (Amit)
- v1: https://lore.kernel.org/r/[email protected]/
--- arch/powerpc/platforms/ps3/spu.c | 2 -- 1 file changed, 2 deletions(-)
arch/powerpc/platforms/ps3/spu.c +0 -2
@@ -190,8 +190,6 @@ static void spu_unmap(struct spu *spu)static int __init setup_areas (struct spu *spu) { -struct table {char * name;unsigned long addr;unsigned long size;}; -spu_pdata (spu)->shadow =ioremap_prot (spu_pdata (spu)->shadow_addr,sizeof (struct spe_shadow ),pgprot_noncached_wc (PAGE_KERNEL_RO ));
Quoted 7 lines · Thorsten Blum
The local table structure is not used - remove it.
Reviewed-by Geert Uytterhoeven <[email protected]>Signed-off-by Thorsten Blum <[email protected]>---
Changes in v2:
- Drop the %0 change because it is valid kernel-doc markup (Amit)
Thanks for addressing the comment and sending a v2!
~Amit
Quoted 18 lines
- v1: https://lore.kernel.org/r/[email protected]/
--- arch/powerpc/platforms/ps3/spu.c | 2 -- 1 file changed, 2 deletions(-)arch/powerpc/platforms/ps3/spu.c +0
-2@@ -190,8 +190,6 @@ static void spu_unmap(struct spu *spu)static int __init setup_areas (struct spu *spu) { -struct table {char * name;unsigned long addr;unsigned long size;}; -spu_pdata (spu)->shadow =ioremap_prot (spu_pdata (spu)->shadow_addr,sizeof (struct spe_shadow ),pgprot_noncached_wc (PAGE_KERNEL_RO ));
Quoted 4 lines · Thorsten Blum
The local table structure is not used - remove it.
Reviewed-by Geert Uytterhoeven <[email protected]>Signed-off-by Thorsten Blum <[email protected]>
LGTM.
Le 13/07/2026 à 11:17, Thorsten Blum a écrit :
Quoted 4 lines
The local table structure is not used - remove it.
Reviewed-by Geert Uytterhoeven <[email protected]>Signed-off-by Thorsten Blum <[email protected]>
Quoted 21 lines
---
Changes in v2:
- Drop the %0 change because it is valid kernel-doc markup (Amit)
- v1: https://lore.kernel.org/r/[email protected]/--- arch/powerpc/platforms/ps3/spu.c | 2 -- 1 file changed, 2 deletions(-)arch/powerpc/platforms/ps3/spu.c +0
-2@@ -190,8 +190,6 @@ static void spu_unmap(struct spu *spu)static int __init setup_areas (struct spu *spu) { -struct table {char * name;unsigned long addr;unsigned long size;}; -spu_pdata (spu)->shadow =ioremap_prot (spu_pdata (spu)->shadow_addr,sizeof (struct spe_shadow ),pgprot_noncached_wc (PAGE_KERNEL_RO ));
Quoted 3 lines · Thorsten Blum
The local table structure is not used - remove it.
Applied to powerpc/fixes.
[1/1] powerpc/ps3: Remove unused struct table in setup_areas()
https://git.kernel.org/powerpc/c/41bf83c1b10781fcb992ff0680db771b7b833308
cheers