iio: dac: ad3552r-hs: fix scnprintf() buffer bound in data source show
Subsystems (2)
PATCH 1/1 iio: dac: ad3552r-hs: fix scnprintf() buffer bound in data source show
ad3552r_hs_show_data_source_avail() formats the available data source names into a 128-byte stack buffer, but bounds each scnprintf() with PAGE_SIZE instead of the buffer size, so the bound does not protect the destination at all.
This cannot overflow today - dbgfs_attr_source[] has two entries, "normal" and "ramp-16bit", 18 bytes formatted - but the bound stops protecting the stack the day the table grows. Use sizeof(buf) so the bound matches the destination.
Found by smatch:
drivers/iio/dac/ad3552r-hs.c:593 ad3552r_hs_show_data_source_avail()
error: scnprintf() 'buf[len]' too small (128 vs 4096)
--- drivers/iio/dac/ad3552r-hs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/dac/ad3552r-hs.c +1 -1
@@ -590,7 +590,7 @@ static ssize_t ad3552r_hs_show_data_source_avail(struct file *f,int i;for (i =0 ; i <ARRAY_SIZE (dbgfs_attr_source); i++) { - len +=scnprintf (buf + len,PAGE_SIZE - len,"%s " , + len +=scnprintf (buf + len,sizeof (buf) - len,"%s " , dbgfs_attr_source[i]); } buf[len -1 ] ='\n' ;
base-commit: fce2dfa773ced15f27dd27cd0b482a7473cdcf2a
Signature · 1 line
2.43.0
Quoted 10 lines · Babanpreet Singh
ad3552r_hs_show_data_source_avail()formats the available data source names into a 128-byte stack buffer, but bounds eachscnprintf()withPAGE_SIZEinstead of the buffer size, so the bound does not protect the destination at all.This cannot overflow today - dbgfs_attr_source[] has two entries, "normal" and "ramp-16bit", 18 bytes formatted - but the bound stops protecting the stack the day the table grows. Use sizeof(buf) so the bound matches the destination.
Quoted 4 lines
Found by smatch:
drivers/iio/dac/ad3552r-hs.c:593ad3552r_hs_show_data_source_avail()
error:scnprintf()'buf[len]' too small (128 vs 4096)
Nice, but please use sysfs_emit_at() instead. This will fix the above issue as well while moving towards the modern and recommended API.
Signature · 2 lines
With Best Regards, Andy Shevchenko