arm64: dts: amlogic: add support for Orbbec Zora P1
Subsystems (2)
v3 cover arm64: dts: amlogic: add support for Orbbec Zora P1
The Orbbec Zora P1 is a vision development board based on the Amlogic A311D (Meson G12B) SoC, with 2 or 4 GiB LPDDR4, an Ampak AP6256 combo module (Broadcom BCM43456 Wi-Fi over SDIO and BCM4345C5 Bluetooth over UART_A), HDMI output and Gigabit Ethernet.
According to its specifications and original device tree, the board is a revised version of the ODROID-N2 with Wi-Fi, Bluetooth and an Amlogic A311D instead of the original S922X. The device tree therefore builds on meson-g12b-a311d.dtsi and meson-g12b-odroid-n2.dtsi, mirroring meson-g12b-odroid-n2-plus.dts. It extends those descriptions with the board-specific AP6256 wiring. The status LED is green instead of the original ODROID-N2 blue and has inverted polarity.
This series consists of:
Patch 1: add the "orbbec" vendor prefix.
Patch 2: document the "orbbec,zora-p1" board compatible. Patch 3: add the meson-g12b-zora-p1.dts board file and Makefile entry.
The DTB was built, validated against the amlogic.yaml binding using DT_SCHEMA_FILES, and boot-tested twice on the board. The AP6256 Wi-Fi interface enumerates and operates with the GPIOX_16 reset and PWM clock description present. Removing the wifi32k and pwm_ef descriptions causes the SDIO Wi-Fi device to stop working on this board.
---
Changes in v2:
- Investigated the apparent GPIOX_16 overlap between the SDIO power sequence reset and the 32.768 kHz PWM clock. Retained the description after two successful hardware tests; removing the clock description prevents the AP6256 Wi-Fi device from working.
- Sort the new DTB entry alphabetically in the Amlogic Makefile.
- Sort the "orbbec" entry alphabetically in vendor-prefixes.yaml.
---
Changes in v3:
- Polished meson-g12b-zora-p1.dts
- Use proper comment with /* and */
- Use the new bindings with function and color properties instead of label in leds node
- Include dt-bindings/leds/common.h
Alberto Robazza (3):
dt-bindings: vendor-prefixes: add Orbbec
dt-bindings: arm: amlogic: document Orbbec Zora P1 board compatible
arm64: dts: amlogic: add support for Orbbec Zora P1
.../devicetree/bindings/arm/amlogic.yaml | 1 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/amlogic/Makefile | 1 + .../boot/dts/amlogic/meson-g12b-zora-p1.dts | 105 ++++++++++++++++++ 4 files changed, 109 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts
Signature · 1 line
2.55.0
PATCH v3 1/3 dt-bindings: vendor-prefixes: add Orbbec
Add the "orbbec" vendor prefix for Orbbec Inc., a manufacturer of 3D depth cameras and embedded vision boards. The prefix is needed by an upcoming board compatible string ("orbbec,zora-p1") introduced by this series.
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -1251,6 +1251,8 @@ patternProperties: description: Option NV "^oranth,.*": description: Shenzhen Oranth Technology Co., Ltd. + "^orbbec,.*": + description: Orbbec Inc. "^ORCL,.*": description: Oracle Corporation "^orisetech,.*":
Signature · 1 line
2.55.0
Re: [PATCH v3 1/3] dt-bindings: vendor-prefixes: add Orbbec
Quoted 4 lines · Alberto Robazza
Add the "orbbec" vendor prefix for Orbbec Inc., a manufacturer of 3D depth cameras and embedded vision boards. The prefix is needed by an upcoming board compatible string ("orbbec,zora-p1") introduced by this series.
Drop the last sentence. It is implied if it comes within this patchset. Are you using it in this patchset, though?
Quoted 6 lines
Signed-off-by Alberto Robazza <[email protected]>--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Best regards,
Krzysztof
PATCH v3 2/3 dt-bindings: arm: amlogic: document Orbbec Zora P1 board compatible
In reply to Alberto RobazzaDocument the "orbbec,zora-p1" compatible for the Orbbec Zora P1 board, which is based on the Amlogic A311D (Meson G12B) SoC. The corresponding device tree is added in the follow-up patch.
The "orbbec" vendor prefix used here is added in the first patch of this series
--- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/amlogic.yaml +1 -0
@@ -167,6 +167,7 @@ properties: - bananapi,bpi-m2s - khadas,vim3 - libretech,aml-a311d-cc + - orbbec,zora-p1 - radxa,zero2 - const: amlogic,a311d - const: amlogic,g12b
Signature · 1 line
2.55.0
Re: [PATCH v3 2/3] dt-bindings: arm: amlogic: document Orbbec Zora P1 board compatible
Quoted 3 lines · Alberto Robazza
Document the "orbbec,zora-p1" compatible for the Orbbec Zora P1 board, which is based on the Amlogic A311D (Meson G12B) SoC. The corresponding device tree is added in the follow-up patch.
Drop the sentence.
Quoted 3 lines
The "orbbec" vendor prefix used here is added in the first patch of this series
Drop the sentence.
Best regards,
Krzysztof
PATCH v3 3/3 arm64: dts: amlogic: add support for Orbbec Zora P1
In reply to Alberto RobazzaThe Orbbec Zora P1 is an A311D (Meson G12B) board with 2/4 GiB DDR4, an Ampak AP6256 combo module (Broadcom BCM43456 Wi-Fi over SDIO and BCM4345C5 Bluetooth over UART_A).
According to the original Linux dts, the board is a modded version of the ODROID-N2, with Amlogic A311D instead of the original S922X and WiFi and Bluetooth support.
So the device tree builds on meson-g12b-a311d.dtsi and meson-g12b-odroid-n2.dtsi (using same vddcpu values of N2+), extended with the board-specific GPIO wiring for the AP6256 handling, and some modifications for the led, GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH and different label (it is a green led, not blue as in the Odroid N2).
Add the new DTB to the Makefile.
--- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../boot/dts/amlogic/meson-g12b-zora-p1.dts | 105 ++++++++++++++++++ 2 files changed, 106 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts
arch/arm64/boot/dts/amlogic/Makefile +1 -0
@@ -40,6 +40,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero2.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-bananapi-m2s.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-zora-p1.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +105 -0
105 lines not on this page · raw message
Signature · 1 line
2.55.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [High] Hardware / Pin Multiplexing Conflict on GPIOX_16 - [Medium] Logic Error / Device Tree Overrides…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Hardware / Pin Multiplexing Conflict on GPIOX_16
- [Medium] Logic Error / Device Tree Overrides (Failed LED Rename)
--
--- Patch [3]: [PATCH v3 3/3] arm64: dts: amlogic: add support for Orbbec Zora P1 --- commit a86fe3a994f708a5d2fc9e72b435f89e92f8a493
Author: Alberto Robazza <[email protected]>
arm64: dts: amlogic: add support for Orbbec Zora P1
The Orbbec Zora P1 is an A311D (Meson G12B) board with 2/4 GiB DDR4, an Ampak AP6256 combo module (Broadcom BCM43456 Wi-Fi over SDIO and BCM4345C5 Bluetooth over UART_A).
Quoted 5 lines
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +0
-0
[ ... ]
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts line 22
Quoted 7 lines
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +7
-0+ leds { + /* Status led on Zora is actually green, same pin as N2, but reversed polarity */ + led-blue { + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + gpios = <&gpio_ao GPIOAO_11 GPIO_ACTIVE_LOW>; + };
[Severity: Medium]
Will this still result in the LED being named n2:blue in sysfs?
Since this node inherits from meson-g12b-odroid-n2.dtsi, it looks like the original label property might still be present. Because led_compose_name() in drivers/leds/led-core.c prioritizes the label property over function and color, the inherited label may bypass these new properties.
Would we need to add /delete-property/ label; here to ensure the new color is properly reflected in the sysfs name?
[ ... ]
Quoted 6 lines
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +6
-0+ sdio_pwrseq: sdio-pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&gpio GPIOX_16 GPIO_ACTIVE_LOW>; + clocks = <&wifi32k>; + clock-names = "ext_clock"; + };
[ ... ]
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts line 48
Quoted 5 lines
+&pwm_ef {
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +4
-0+ status = "okay"; + pinctrl-0 = <&pwm_e_pins>; + pinctrl-names = "default"; +};
[Severity: High]
Can this cause a pin multiplexing conflict?
It appears GPIOX_16 is requested as a static GPIO reset line for sdio_pwrseq above, but pwm_ef also requests pwm_e_pins, which maps to the exact same GPIOX_16 pin for the 32kHz clock output.
Could this cause the pinctrl subsystem to reject the secondary request with -EBUSY during boot, or potentially force the pin into conflicting electrical states?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
Quoted 62 lines · Alberto Robazza
The Orbbec Zora P1 is an A311D (Meson G12B) board with 2/4 GiB DDR4, an Ampak AP6256 combo module (Broadcom BCM43456 Wi-Fi over SDIO and BCM4345C5 Bluetooth over
UART_A).According to the original Linux dts, the board is a modded version of the ODROID-N2, with Amlogic A311D instead of the original S922X and WiFi and Bluetooth support.
So the device tree builds onmeson-g12b-a311d.dtsiandmeson-g12b-odroid-n2.dtsi(using same vddcpu values of N2+), extended with the board-specific GPIO wiring for the AP6256 handling, and some modifications for the led,GPIO_ACTIVE_LOWinstead ofGPIO_ACTIVE_HIGHand different label (it is a green led, not blue as in the Odroid N2).
Add the new DTB to theMakefile.Signed-off-by Alberto Robazza <[email protected]>--- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../boot/dts/amlogic/meson-g12b-zora-p1.dts | 105 ++++++++++++++++++ 2 files changed, 106 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dtsarch/arm64/boot/dts/amlogic/Makefile +1
-0@@ -40,6 +40,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero2.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-bananapi-m2s.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-zora-p1.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtbarch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +22
-0@@ -0,0 +1,105 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2026 Alberto Robazza <[email protected]> + */ + +/dts-v1/; + +#include "meson-g12b-a311d.dtsi" +#include "meson-g12b-odroid-n2.dtsi" +#include <dt-bindings/leds/common.h> + +/ { + compatible = "orbbec,zora-p1", "amlogic,a311d", "amlogic,g12b"; + model = "Orbbec Zora P1"; + + leds { + /* Status led on Zora is actually green, same pin as N2, but reversed polarity */ + led-blue { + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + gpios = <&gpio_ao GPIOAO_11 GPIO_ACTIVE_LOW>; + };
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts line 32
Quoted 10 lines
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +10
-0+ }; + + sdio_pwrseq: sdio-pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&gpio GPIOX_16 GPIO_ACTIVE_LOW>; + clocks = <&wifi32k>; + clock-names = "ext_clock"; + }; + + wifi32k: wifi32k {
Please use name for all fixed clocks which matches current format
recommendation: 'clock-<freq>' (see also the pattern in the binding for any other options).
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/fixed-clock.yaml
Or any other reasonable name based on generic prefix. wifi32k is for sure nothing related to clock...
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts line 42
Quoted 10 lines
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +10
-0+ compatible = "pwm-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + pwms = <&pwm_ef 0 30518 0>; + }; + + sound { + model = "ZORA-P1"; + }; +};
Best regards,
Krzysztof