arm64: dts: amlogic: add support for Orbbec Zora P1
Subsystems (2)
v4 cover arm64: dts: amlogic: add support for Orbbec Zora P1
The Orbbec Zora P1 is a vision development board based on the Amlogic A311D (Meson G12B) SoC, with 2 or 4 GiB LPDDR4, an Ampak AP6256 combo module (Broadcom BCM43456 Wi-Fi over SDIO and BCM4345C5 Bluetooth over UART_A), HDMI output and Gigabit Ethernet.
According to its specifications and original device tree, the board is a revised version of the ODROID-N2 with Wi-Fi, Bluetooth and an Amlogic A311D instead of the original S922X. The device tree therefore builds on meson-g12b-a311d.dtsi and meson-g12b-odroid-n2.dtsi, mirroring meson-g12b-odroid-n2-plus.dts. It extends those descriptions with the board-specific AP6256 wiring. The status LED is green instead of the original ODROID-N2 blue and has inverted polarity.
This series consists of:
Patch 1: add the "orbbec" vendor prefix.
Patch 2: document the "orbbec,zora-p1" board compatible. Patch 3: add the meson-g12b-zora-p1.dts board file and Makefile entry.
The DTB was built, validated against the amlogic.yaml binding using DT_SCHEMA_FILES, and boot-tested twice on the board. The AP6256 Wi-Fi interface enumerates and operates with the GPIOX_16 reset and PWM clock description present. Removing the wifi32k and pwm_ef descriptions causes the SDIO Wi-Fi device to stop working on this board.
---
Changes in v2:
- Investigated the apparent GPIOX_16 overlap between the SDIO power sequence reset and the 32.768 kHz PWM clock. Retained the description after two successful hardware tests; removing the clock description prevents the AP6256 Wi-Fi device from working.
- Sort the new DTB entry alphabetically in the Amlogic Makefile.
- Sort the "orbbec" entry alphabetically in vendor-prefixes.yaml.
---
Changes in v3:
- Polished meson-g12b-zora-p1.dts.
- Use proper comment with /* and */.
- Use the new bindings with function and color properties instead of label in leds node.
- Include dt-bindings/leds/common.h.
---
Changes in v4:
- Dropped unnecessary sentences from patch 1 and 2.
- Renamed "wifi32k" node to "clock-32768" as updated guidelines suggest.
Alberto Robazza (3):
dt-bindings: vendor-prefixes: add Orbbec
dt-bindings: arm: amlogic: document Orbbec Zora P1 board compatible
arm64: dts: amlogic: add support for Orbbec Zora P1
.../devicetree/bindings/arm/amlogic.yaml | 1 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/amlogic/Makefile | 1 + .../boot/dts/amlogic/meson-g12b-zora-p1.dts | 105 ++++++++++++++++++ 4 files changed, 109 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts
Signature · 1 line
2.55.0
PATCH v4 1/3 dt-bindings: vendor-prefixes: add Orbbec
Add the "orbbec" vendor prefix for Orbbec Inc., a manufacturer of 3D depth cameras and embedded vision boards.
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -1251,6 +1251,8 @@ patternProperties: description: Option NV "^oranth,.*": description: Shenzhen Oranth Technology Co., Ltd. + "^orbbec,.*": + description: Orbbec Inc. "^ORCL,.*": description: Oracle Corporation "^orisetech,.*":
Signature · 1 line
2.55.0
Re: [PATCH v4 1/3] dt-bindings: vendor-prefixes: add Orbbec
Hi Alberto,
Quoted 8 lines · Alberto Robazza
Add the "orbbec" vendor prefix for Orbbec Inc., a manufacturer of 3D depth cameras and embedded vision boards.
Signed-off-by Alberto Robazza <[email protected]>---
Documentation/devicetree/bindings/vendor-prefixes.yaml| 2 ++1 file changed, 2 insertions(+)
You seem to have missed Krzysztof's Acked-by tag in this patch:
https://lore.kernel.org/all/20260729-unbreakable-observant-clam-ca4f6d@quoll/
Reviewers will typically give out Acked-by or Reviewed-by tags to your patch to signal that the patch looks good to them (typically the former tag) or that they have reviewed it in great detail and approve it (typically the latter tag). These tags need to be picked up and added to your patch.
If you use b4 to send the patches, you can run b4 trailers -u each time before sending a new patchset revision to the mailing list to get all Acked-by and Reviewed-by tags reviewers will give to your patch. If you don't use b4, you should be able to add them manually still with git commands.
If you don't have them added to your patch, it may sound like you ignored their review. Reviewing takes effort and is time-consuming, so always make sure you have all of them added.
Also see: https://docs.kernel.org/process/submitting-patches.html
Best regards,
Ferass
Quoted 21 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +2
-0@@ -1251,6 +1251,8 @@ patternProperties: description: Option NV "^oranth,.*": description: Shenzhen Oranth Technology Co., Ltd. + "^orbbec,.*": + description: Orbbec Inc. "^ORCL,.*": description: Oracle Corporation "^orisetech,.*":Signature · 7 lines
2.55.0 _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic
Re: [PATCH v4 1/3] dt-bindings: vendor-prefixes: add Orbbec
Thank you for the feedback. I didn't ignored, indeed the suggestion was implemented in v4. My bad!
Regards,
Alberto
Quoted 57 lines · Ferass El Hafidi
Hi Alberto,
Quoted 8 lines · Alberto Robazza
Add the "orbbec" vendor prefix for Orbbec Inc., a manufacturer of 3D depth cameras and embedded vision boards.
Signed-off-by Alberto Robazza <[email protected]>---
Documentation/devicetree/bindings/vendor-prefixes.yaml| 2 ++1 file changed, 2 insertions(+)You seem to have missed Krzysztof's Acked-by tag in this patch:
https://lore.kernel.org/all/20260729-unbreakable-observant-clam-ca4f6d@quoll/Reviewers will typically give out Acked-by or Reviewed-by tags to your patch to signal that the patch looks good to them (typically the former tag) or that they have reviewed it in great detail and approve it (typically the latter tag). These tags need to be picked up and added to your patch.
If you use b4 to send the patches, you can run
b4 trailers -ueach time before sending a new patchset revision to the mailing list to get all Acked-by and Reviewed-by tags reviewers will give to your patch. If you don't use b4, you should be able to add them manually still with git commands.If you don't have them added to your patch, it may sound like you ignored their review. Reviewing takes effort and is time-consuming, so always make sure you have all of them added.
Also see: https://docs.kernel.org/process/submitting-patches.html
Best regards,
FerassQuoted 21 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +2
-1@@ -1251,6 +1251,8 @@ patternProperties: description: Option NV "^oranth,.*": description: Shenzhen Oranth Technology Co., Ltd. + "^orbbec,.*": + description: Orbbec Inc. "^ORCL,.*": description: Oracle Corporation "^orisetech,.*": --2.55.0
_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
PATCH v4 2/3 dt-bindings: arm: amlogic: document Orbbec Zora P1 board compatible
In reply to Alberto RobazzaDocument the "orbbec,zora-p1" compatible for the Orbbec Zora P1 board, which is based on the Amlogic A311D (Meson G12B) SoC.
--- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/amlogic.yaml +1 -0
@@ -167,6 +167,7 @@ properties: - bananapi,bpi-m2s - khadas,vim3 - libretech,aml-a311d-cc + - orbbec,zora-p1 - radxa,zero2 - const: amlogic,a311d - const: amlogic,g12b
Signature · 1 line
2.55.0
PATCH v4 3/3 arm64: dts: amlogic: add support for Orbbec Zora P1
In reply to Alberto RobazzaThe Orbbec Zora P1 is an A311D (Meson G12B) board with 2/4 GiB DDR4, an Ampak AP6256 combo module (Broadcom BCM43456 Wi-Fi over SDIO and BCM4345C5 Bluetooth over UART_A).
According to the original Linux dts, the board is a modded version of the ODROID-N2, with Amlogic A311D instead of the original S922X and WiFi and Bluetooth support.
So the device tree builds on meson-g12b-a311d.dtsi and meson-g12b-odroid-n2.dtsi (using same vddcpu values of N2+), extended with the board-specific GPIO wiring for the AP6256 handling, and some modifications for the led, GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH and different label (it is a green led, not blue as in the Odroid N2).
Add the new DTB to the Makefile.
--- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../boot/dts/amlogic/meson-g12b-zora-p1.dts | 105 ++++++++++++++++++ 2 files changed, 106 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts
arch/arm64/boot/dts/amlogic/Makefile +1 -0
@@ -40,6 +40,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero2.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-bananapi-m2s.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-zora-p1.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +105 -0
105 lines not on this page · raw message
Signature · 1 line
2.55.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [High] Hardware pin conflict on GPIOX_16, which is simultaneously assigned as an SDIO reset GPIO and a…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Hardware pin conflict on GPIOX_16, which is simultaneously assigned as an SDIO reset GPIO and a PWM_E clock output.
- [Low] The overridden 'led-blue' node fails to delete the inherited 'label' property, causing the LED sysfs device name to incorrectly remain 'n2:blue' and ignoring the new 'color' and 'function' properties. --
--- Patch [3]: [PATCH v4 3/3] arm64: dts: amlogic: add support for Orbbec Zora P1 --- commit 42dd3ecbc89a1e42aabbfd5aa86b80cf4d5cb181
Author: Alberto Robazza <[email protected]>
arm64: dts: amlogic: add support for Orbbec Zora P1
The Orbbec Zora P1 is an A311D board modded from the ODROID-N2. This commit adds a new device tree that builds on meson-g12b-a311d.dtsi and meson-g12b-odroid-n2.dtsi, adding board-specific GPIO wiring for Wi-Fi/BT and modifying the LED configuration.
Quoted 5 lines
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +0
-0
[ ... ]
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts line 21
Quoted 6 lines
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +6
-0+ leds { + /* Status led on Zora is actually green, same pin as N2, but reversed polarity */ + led-blue { + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + gpios = <&gpio_ao GPIOAO_11 GPIO_ACTIVE_LOW>;
[Severity: Low]
Will the LED subsystem ignore the new color and function properties here?
Since this node overrides led-blue from the base meson-g12b-odroid-n2.dtsi (which sets label = "n2:blue"), not explicitly removing the label with /delete-property/ label; means the original label is inherited.
In led_parse_fwnode_props(), if a label is present, it uses that exclusively for the sysfs name and ignores the color and function properties.
Quoted 9 lines
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +9
-0+ }; + }; + + sdio_pwrseq: sdio-pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&gpio GPIOX_16 GPIO_ACTIVE_LOW>; + clocks = <&clock_32768>; + clock-names = "ext_clock"; + };
[ ... ]
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts line 46
Quoted 3 lines
+&pwm_ef {
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +2
-0+ status = "okay"; + pinctrl-0 = <&pwm_e_pins>;
[Severity: High]
Does this create a hardware pin conflict on GPIOX_16?
The sdio_pwrseq node explicitly requests GPIOX_16 as a reset GPIO. At the same time, pwm_ef claims pwm_e_pins. On Amlogic G12A/G12B platforms, the pwm_e_pins group maps directly to GPIOX_16.
This looks like the exact same pin is requested for two incompatible roles, which might conflict between the GPIO and pinctrl subsystems and prevent the Wi-Fi module from working.
Quoted 3 lines
arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts new file +3
-0+ pinctrl-names = "default"; +}; +
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3