Skip to contentSkip to conversation

arm64: dts: rockchip: Fix the BT clock-names on rk3399-hugsun-x99

PATCH Applied Fabio Estevam 2 participants 3 messages Aug 7 – Nov 1

Subsystems (2)
Device tree bindings Arm Rockchip
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH v2 1/2 arm64: dts: rockchip: Fix the BT clock-names on rk3399-hugsun-x99

According to brcm,bluetooth.yaml, the correct clock-names to describe the 32768kHz Low Power Oscillator is "lpo".

Change it accordingly to fix the following dt-schema warning:

clock-names: 'oneOf' conditional failed, one must be fixed:
['ext_clock'] is too short
'extclk' was expected
'txco' was expected
'lpo' was expected

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Use "lpo" name instead. (Sashiko)

 arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +1 -1
index 352c8efb37e0..27ebbbc66633 100644
@@ -703,7 +703,7 @@ &uart0 {
 	bluetooth {
 		compatible = "brcm,bcm43438-bt";
 		clocks = <&rk808 1>;
-		clock-names = "ext_clock";
+		clock-names = "lpo";
 		device-wakeup-gpios = <&gpio2 RK_PD2 GPIO_ACTIVE_HIGH>;
 		host-wakeup-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_HIGH>;
 		shutdown-gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH v2 2/2 arm64: dts: rockchip: Fix the BT clock-names on rk3399-leez-p710

According to brcm,bluetooth.yaml, the correct clock-names to describe the 32768kHz Low Power Oscillator is "lpo".

Change it accordingly to fix the following dt-schema warning:

clock-names: 'oneOf' conditional failed, one must be fixed:
['ext_clock'] is too short
'extclk' was expected
'txco' was expected
'lpo' was expected

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Use "lpo" name instead. (Sashiko)

 arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts +1 -1
index 2cdc2013c320..c449eaa84edc 100644
@@ -588,7 +588,7 @@ &uart0 {
 	bluetooth {
 		compatible = "brcm,bcm43438-bt";
 		clocks = <&rk808 1>;
-		clock-names = "ext_clock";
+		clock-names = "lpo";
 		device-wakeup-gpios = <&gpio2 RK_PD2 GPIO_ACTIVE_HIGH>;
 		host-wakeup-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_HIGH>;
 		shutdown-gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.43.0
maintainer Applied
#2 lore raw
In reply to Fabio Estevam
Quoted 5 lines · Fabio Estevam

According to brcm,bluetooth.yaml, the correct clock-names to describe the 32768kHz Low Power Oscillator is "lpo".

Change it accordingly to fix the following dt-schema warning:

Quoted 7 lines

clock-names: 'oneOf' conditional failed, one must be fixed:
['ext_clock'] is too short
'extclk' was expected
'txco' was expected
'lpo' was expected

[...]

Applied, thanks!

[1/2] arm64: dts: rockchip: Fix the BT clock-names on rk3399-hugsun-x99

      commit: 54b2405a6a99b049fb87023a6f780a825f3b456b
[2/2] arm64: dts: rockchip: Fix the BT clock-names on rk3399-leez-p710
      commit: 7736dd0bb7a1c78728d68880f4f8ff033fb7b83a

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>