Skip to contentSkip to conversation

arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A

PATCH Superseded Reza Kurniawan 2 participants 5 messages Aug 10 – Aug 18

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A

Thank you for the feedback. This is my first contribution and I'm not quite familiar with the process yet, apologies for the mistakes.

As instructed, I've added my name in the Signed-off-by field. Aside from that, since the changes are isolated from each other, the patch is split into multiple patches.

Changes in v2:
- Split the patch into multiple patches.
- Change name in Signed-off-by field.

v1: https://lore.kernel.org/r/[email protected]

Reza Kurniawan (3):
arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva)
arm64: dts: qcom: Add haptic vibrator support for Xiaomi Redmi 5A

    (riva)
  arm64: dts: qcom: Add notification LED support for Xiaomi Redmi 5A
    (riva)
 .../boot/dts/qcom/msm8917-xiaomi-riva.dts     | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)

base-commit: 6b8c8af514d739d0335f5579b585e02babe8a727

Signature · 1 line
2.55.0
#1 lore raw

PATCH v2 1/3 arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva)

---
 arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts +8 -0
index 4ea4fbdb5..abfaae502 100644
@@ -13,6 +13,10 @@ / {
 
 	qcom,board-id = <0x1000b 1>, <0x1000b 2>;
 
+	chosen {
+		stdout-path = &blsp1_uart2;
+	};
+
 	battery: battery {
 		compatible = "simple-battery";
 		charge-full-design-microamp-hours = <3000000>;
@@ -25,6 +29,10 @@ battery: battery {
 	};
 };
 
+&blsp1_uart2 {
+	status = "okay";
+};
+
 &blsp2_i2c1 {
 	status = "okay";
 
Signature · 1 line
2.55.0
#2 lore raw

PATCH v2 2/3 arm64: dts: qcom: Add haptic vibrator support for Xiaomi Redmi 5A (riva)

In reply to Reza Kurniawan
---
 arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts +5 -0
index abfaae502..e6e708601 100644
@@ -27,6 +27,11 @@ battery: battery {
 		charge-term-current-microamp = <60000>;
 		voltage-min-design-microvolt = <3400000>;
 	};
+
+	vibrator {
+		compatible = "gpio-vibrator";
+		enable-gpios = <&tlmm 97 GPIO_ACTIVE_HIGH>;
+	};
 };
 
 &blsp1_uart2 {
Signature · 1 line
2.55.0
#3 lore raw

PATCH v2 3/3 arm64: dts: qcom: Add notification LED support for Xiaomi Redmi 5A (riva)

In reply to Reza Kurniawan
---
 .../boot/dts/qcom/msm8917-xiaomi-riva.dts     | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts +23 -0
index e6e708601..e74433f89 100644
@@ -5,6 +5,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/leds/common.h>
 #include "msm8917-xiaomi-wingtech.dtsi"
 
 / {
@@ -34,6 +35,28 @@ vibrator {
 	};
 };
 
+&blsp1_i2c2 {
+	status = "okay";
+
+	led-controller@45 {
+		compatible = "awinic,aw2013";
+		reg = <0x45>;
+		vcc-supply = <&pm8937_l10>;
+		vio-supply = <&pm8937_l5>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		status = "okay";
+
+		led@0 {
+			reg = <0>;
+			led-max-microamp = <5000>;
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_WHITE>;
+		};
+	};
+};
+
 &blsp1_uart2 {
 	status = "okay";
 };
Signature · 1 line
2.55.0
#4 lore raw
In reply to Reza Kurniawan
Quoted 6 lines · Reza Kurniawan

Thank you for the feedback. This is my first contribution and I'm not quite familiar with the process yet, apologies for the mistakes.

As instructed, I've added my name in the Signed-off-by field. Aside from that, since the changes are isolated from each other, the patch is split into multiple patches.

You're on good track. Please make sure all of the commits, apart from a suitable title, also come with a commit message. This is important both for the reviewer to more easily grok the change (or have confidence in your understanding on the problem), as well as it brings historical value for people that come after you - they can learn from your notes.

See: https://docs.kernel.org/process/submitting-patches.html#describe-your-changeslore

For the patch submission itself, there's a tool called b4 that takes care of some of the headaches for you:

https://b4.docs.kernel.org/

Konrad