Skip to contentSkip to conversation

arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A

PATCH Applied Reza Kurniawan 3 participants 8 messages Aug 20 – Aug 31

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v4 cover arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A

Changes in v4:
- Simplify commit title
- Add commit description
- Drop redundant status propery in LED node

Changes in v3:
- Add vcc-supply for vibrator

Changes in v2:
- Split the patch into multiple patches.
- Change name in Signed-off-by field.

v3: https://lore.kernel.org/r/[email protected]
v2: https://lore.kernel.org/r/[email protected]
v1: https://lore.kernel.org/r/[email protected]

Reza Kurniawan (3):
arm64: dts: qcom: msm8917-xiaomi-riva: Enable debug UART console
arm64: dts: qcom: msm8917-xiaomi-riva: Add GPIO haptic vibrator
arm64: dts: qcom: msm8917-xiaomi-riva: Add notification LED support

 .../boot/dts/qcom/msm8917-xiaomi-riva.dts     | 35 +++++++++++++++++++
 1 file changed, 35 insertions(+)

base-commit: 6a746cd265aed59107ebdaa9ce039bb832922969

Signature · 1 line
2.55.0
#1 lore raw

PATCH v4 1/3 arm64: dts: qcom: msm8917-xiaomi-riva: Enable debug UART console

Xiaomi Redmi 5A has accessible UART test points on its PCB, they are routed to the BLSP1 UART2 port.

Enable the blsp1_uart2 node and configure stdout-path under the chosen node to allow outputting kernel logs and facilitate early debugging.

---
v4:
- Simplify commit title
- Add commit description

 arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts +8 -0
index 4ea4fbdb5..abfaae502 100644
@@ -13,6 +13,10 @@ / {
 
 	qcom,board-id = <0x1000b 1>, <0x1000b 2>;
 
+	chosen {
+		stdout-path = &blsp1_uart2;
+	};
+
 	battery: battery {
 		compatible = "simple-battery";
 		charge-full-design-microamp-hours = <3000000>;
@@ -25,6 +29,10 @@ battery: battery {
 	};
 };
 
+&blsp1_uart2 {
+	status = "okay";
+};
+
 &blsp2_i2c1 {
 	status = "okay";
 
Signature · 1 line
2.55.0
Reviewed-by on v4 1/3
#2 lore raw

Re: [PATCH v4 1/3] arm64: dts: qcom: msm8917-xiaomi-riva: Enable debug UART console

Quoted 8 lines · Reza Kurniawan

Xiaomi Redmi 5A has accessible UART test points on its PCB, they are routed to the BLSP1 UART2 port.

Enable the blsp1_uart2 node and configure stdout-path under the chosen node to allow outputting kernel logs and facilitate early debugging.

---

Konrad

#3 lore raw

PATCH v4 2/3 arm64: dts: qcom: msm8917-xiaomi-riva: Add GPIO haptic vibrator

In reply to Reza Kurniawan

The haptic vibrator in Xiaomi Redmi 5A is controlled through TLMM GPIO 97 and is directly powered vph_pwr.

Define the vibrator node using the "gpio-vibrator" driver.

---
v4:
- Simplify commit title
- Add commit description

v3:
- Add vcc-supply for vibrator

 arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts +6 -0
index abfaae502..a066d9d7a 100644
@@ -27,6 +27,12 @@ battery: battery {
 		charge-term-current-microamp = <60000>;
 		voltage-min-design-microvolt = <3400000>;
 	};
+
+	vibrator {
+		compatible = "gpio-vibrator";
+		enable-gpios = <&tlmm 97 GPIO_ACTIVE_HIGH>;
+		vcc-supply = <&vph_pwr>;
+	};
 };
 
 &blsp1_uart2 {
Signature · 1 line
2.55.0
Reviewed-by on v4 2/3
#4 lore raw

Re: [PATCH v4 2/3] arm64: dts: qcom: msm8917-xiaomi-riva: Add GPIO haptic vibrator

Quoted 7 lines · Reza Kurniawan

The haptic vibrator in Xiaomi Redmi 5A is controlled through TLMM GPIO 97 and is directly powered vph_pwr.

Define the vibrator node using the "gpio-vibrator" driver.

---

Konrad

#5 lore raw

PATCH v4 3/3 arm64: dts: qcom: msm8917-xiaomi-riva: Add notification LED support

In reply to Reza Kurniawan

Add the aw2013 led-controller node for controlling the notification LED. Since it communicates through I2C, also enable the blsp1_i2c2 node.

---
v4:
- Simplify commit title
- Add commit description
- Drop redundant status propery in LED node

 .../boot/dts/qcom/msm8917-xiaomi-riva.dts     | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts +21 -0
index a066d9d7a..7c323214a 100644
@@ -5,6 +5,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/leds/common.h>
 #include "msm8917-xiaomi-wingtech.dtsi"
 
 / {
@@ -35,6 +36,26 @@ vibrator {
 	};
 };
 
+&blsp1_i2c2 {
+	status = "okay";
+
+	led-controller@45 {
+		compatible = "awinic,aw2013";
+		reg = <0x45>;
+		vcc-supply = <&pm8937_l10>;
+		vio-supply = <&pm8937_l5>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@0 {
+			reg = <0>;
+			led-max-microamp = <5000>;
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_WHITE>;
+		};
+	};
+};
+
 &blsp1_uart2 {
 	status = "okay";
 };
Signature · 1 line
2.55.0
maintainer Applied
#7 lore raw
In reply to Reza Kurniawan
Quoted 9 lines · Reza Kurniawan

Changes in v4:
- Simplify commit title
- Add commit description
- Drop redundant status propery in LED node

Changes in v3:
- Add vcc-supply for vibrator

[...]

Applied, thanks!

[1/3] arm64: dts: qcom: msm8917-xiaomi-riva: Enable debug UART console

      commit: 205e698663f5ed1593fea5cef825adca8828b426
[2/3] arm64: dts: qcom: msm8917-xiaomi-riva: Add GPIO haptic vibrator
      commit: 067e6289a46ec5dffe824f1f4331deec55f4c356
[3/3] arm64: dts: qcom: msm8917-xiaomi-riva: Add notification LED support
      commit: e82b1285a11478ef00827b2249c31c2189fc6b99

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>