ice: fix metadata_dst refcount handling on representor teardown
Subsystems (4)
PATCH 1/1 ice: fix metadata_dst refcount handling on representor teardown
From: Tristan Madani <[email protected]>
ice_eswitch_release_repr() uses metadata_dst_free() to release the representor's metadata_dst. metadata_dst_free() directly frees the underlying memory without checking the dst_entry refcount.
When ice_eswitch_port_start_xmit() processes a packet, it takes a reference via dst_hold() and attaches the metadata_dst to the skb. If the representor is torn down while packets are still queued on the lower device (e.g. in a qdisc), the metadata_dst is freed while references are still held.
Use dst_release() instead, which correctly decrements the refcount and only frees the object when all references are dropped. The dst subsystem already handles metadata_dst cleanup in dst_destroy() when DST_METADATA is set.
Other drivers sharing this pattern (nfp, airoha, bnxt) already use dst_release() for their metadata_dst lifecycle.
--- drivers/net/ethernet/intel/ice/ice_eswitch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_eswitch.c +1 -1
@@ -95,7 +95,7 @@ ice_eswitch_release_repr(struct ice_pf *pf, struct ice_repr *repr)return ;ice_vsi_update_security (vsi, ice_vsi_ctx_set_antispoof); -metadata_dst_free (repr->dst); +dst_release (&repr->dst->dst); repr->dst =NULL ;ice_fltr_add_mac_and_broadcast (vsi, repr->parent_mac,ICE_FWD_TO_VSI );
Signature · 1 line
2.47.3
Quoted 17 lines · Tristan Madani
From: Tristan Madani <[email protected]>
ice_eswitch_release_repr()usesmetadata_dst_free()to release the representor'smetadata_dst.metadata_dst_free()directly frees the underlying memory without checking thedst_entryrefcount.When
ice_eswitch_port_start_xmit()processes a packet, it takes a reference viadst_hold()and attaches themetadata_dstto the skb. If the representor is torn down while packets are still queued on the lower device (e.g. in a qdisc), themetadata_dstis freed while references are still held.Use
dst_release()instead, which correctly decrements the refcount and only frees the object when all references are dropped. The dst subsystem already handlesmetadata_dstcleanup indst_destroy()whenDST_METADATAis set.
Quoted 6 lines
Other drivers sharing this pattern (nfp, airoha, bnxt) already use
dst_release()for theirmetadata_dstlifecycle.Fixes f5396b8a663f7 ("ice: switchdev slow path")Signed-off-by Tristan Madani <[email protected]>