Skip to contentSkip to conversation

m68k: pata_cswarp: Add Amiga cslab ata support

PATCH Applied Paolo Pisati 4 participants 7 messages Aug 26 – Sep 27

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v6 cover m68k: pata_cswarp: Add Amiga cslab ata support

Here is a driver (and the subsequent defconfig change) for the pata/CF socket in the CS-Lab Warp series of Amiga boards.

This is a respin of v5 addressing Geert's and sashiko-bot's review.

Tested on real Warp hardware.

v5: https://lore.kernel.org/linux-ide/[email protected]/

Changes in v6:
- fix 7.3 FTBFS (include <linux/device-id/zorro.h>, and use named initializers in the zorro_device_id table)
- use devm_ioremap()
- print the register window with %pR in ata_port_desc()

Changes in v5:
- return the number of bytes actually consumed on the bus
- fix the trailing byte in pata_cswarp_data_xfer()
- drop a blank line in Kconfig
- fix the remaining checkpatch complaints

Changes in v4:
- refactor pata_cswarp_data_xfer()
- ioremap WARP_OFFSET_ATA region

Changes in v3:
- suppress a comment
- properly return ata_host_activate() error code

Change in v2:
- fix style, remove duplicate swap macro, driver version, etc
- rework the zorro attach mechanism
- remove the unnecessary zorro ids refactor

Paolo Pisati (2):
ata: pata_cswarp: Add Amiga cslab ata support
m68k: defconfig: enable PATA_CSWARP

 arch/m68k/configs/amiga_defconfig |   1 +
 arch/m68k/configs/multi_defconfig |   1 +
 drivers/ata/Kconfig               |  10 ++
 drivers/ata/Makefile              |   1 +
 drivers/ata/pata_cswarp.c         | 183 ++++++++++++++++++++++++++++++
 5 files changed, 196 insertions(+)
 create mode 100644 drivers/ata/pata_cswarp.c

base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91

Signature · 1 line
2.43.0
#1 lore raw

PATCH v6 1/2 ata: pata_cswarp: Add Amiga cslab ata support

Driver for the on-board IDE interface on CS-Lab Warp Expansion Card (NOTE that idemode=native has to be set in Warp Configuration)

Assisted-by Claude_Code:claude-opus-5
---
 drivers/ata/Kconfig       |  10 +++
 drivers/ata/Makefile      |   1 +
 drivers/ata/pata_cswarp.c | 183 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 194 insertions(+)
 create mode 100644 drivers/ata/pata_cswarp.c
drivers/ata/Kconfig +10 -0
index 28ca856ecc75..86af89a9bfce 100644
@@ -1040,6 +1040,16 @@ config PATA_GAYLE
 
 	  If unsure, say N.
 
+config PATA_CSWARP
+	tristate "Amiga CS Warp PATA support"
+	depends on M68K && AMIGA && ZORRO
+	help
+	  This option enables support for the on-board IDE interface on
+	  CS-Lab Warp Expansion Card (NOTE that idemode=native has to be
+	  set in Warp Configuration)
+
+	  If unsure, say N.
+
 config PATA_BUDDHA
 	tristate "Buddha/Catweasel/X-Surf PATA support"
 	depends on ZORRO
drivers/ata/Makefile +1 -0
index b96025abd45e..647e3d4b6f75 100644
@@ -100,6 +100,7 @@ obj-$(CONFIG_PATA_WINBOND)	+= pata_sl82c105.o
 obj-$(CONFIG_PATA_CMD640_PCI)	+= pata_cmd640.o
 obj-$(CONFIG_PATA_FALCON)	+= pata_falcon.o
 obj-$(CONFIG_PATA_GAYLE)	+= pata_gayle.o
+obj-$(CONFIG_PATA_CSWARP)	+= pata_cswarp.o
 obj-$(CONFIG_PATA_BUDDHA)	+= pata_buddha.o
 obj-$(CONFIG_PATA_ISAPNP)	+= pata_isapnp.o
 obj-$(CONFIG_PATA_IXP4XX_CF)	+= pata_ixp4xx_cf.o
drivers/ata/pata_cswarp.c new file +183 -0

183 lines not on this page · raw message

Signature · 1 line
2.43.0
maintainer Reviewed-by on v6 1/2
#2 lore raw

Re: [PATCH v6 1/2] ata: pata_cswarp: Add Amiga cslab ata support

Quoted 5 lines · Paolo Pisati

Driver for the on-board IDE interface on CS-Lab Warp Expansion Card (NOTE that idemode=native has to be set in Warp Configuration)

Assisted-by Claude_Code:claude-opus-5

Looks OK to me.

Signature · 2 lines
Damien Le Moal
Western Digital Research
#3 lore raw

PATCH v6 2/2 m68k: defconfig: enable PATA_CSWARP

In reply to Paolo Pisati

Enable the new CS-Lab Warp PATA driver in the Amiga and multi defconfigs.

Assisted-by Claude_Code:claude-opus-5
---
 arch/m68k/configs/amiga_defconfig | 1 +
 arch/m68k/configs/multi_defconfig | 1 +
 2 files changed, 2 insertions(+)
arch/m68k/configs/amiga_defconfig +1 -0
index 8b7efe20dd12..794bad30f5f0 100644
@@ -284,6 +284,7 @@ CONFIG_ATA=y
 # CONFIG_ATA_VERBOSE_ERROR is not set
 # CONFIG_ATA_BMDMA is not set
 CONFIG_PATA_GAYLE=y
+CONFIG_PATA_CSWARP=y
 CONFIG_PATA_BUDDHA=y
 CONFIG_MD=y
 CONFIG_MD_LINEAR=m
arch/m68k/configs/multi_defconfig +1 -0
index 2cbd6bf20a68..3a9aa52d00e4 100644
@@ -310,6 +310,7 @@ CONFIG_ATA=y
 # CONFIG_ATA_BMDMA is not set
 CONFIG_PATA_FALCON=y
 CONFIG_PATA_GAYLE=y
+CONFIG_PATA_CSWARP=y
 CONFIG_PATA_BUDDHA=y
 CONFIG_PATA_PLATFORM=y
 CONFIG_MD=y
Signature · 1 line
2.43.0
maintainer Reviewed-by
#5 lore raw

Re: [PATCH v6 2/2] m68k: defconfig: enable PATA_CSWARP

Quoted 8 lines · Damien Le Moal
Quoted 5 lines · Paolo Pisati

Enable the new CS-Lab Warp PATA driver in the Amiga and multi defconfigs.

Assisted-by Claude_Code:claude-opus-5

i.e. will queue in the m68k tree for v7.4.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
maintainer Applied
#6 lore raw

Re: (subset) [PATCH v6 0/2] m68k: pata_cswarp: Add Amiga cslab ata support

In reply to Paolo Pisati
Quoted 8 lines · Paolo Pisati

Here is a driver (and the subsequent defconfig change) for the pata/CF socket in the CS-Lab Warp series of Amiga boards.

This is a respin of v5 addressing Geert's and sashiko-bot's review.

Tested on real Warp hardware.

[...]

Applied to libata/linux.git (for-7.4), thanks!

[1/2] ata: pata_cswarp: Add Amiga cslab ata support

      https://git.kernel.org/libata/linux/c/d388f965

Kind regards,
Niklas