Skip to content

m68k: pata_cswarp: Add Amiga cslab ata support

Paolo Pisati linux-ide linux-m68k lkml 2 versions – Applied

Status from this message: Applied to libata/linux.git (for-7.4), thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 4 repliesApplied
  2. v52 patches 5 repliesSuperseded

Changes in v6 from the cover letter

- fix 7.3 FTBFS (include <linux/device-id/zorro.h>, and use named initializers in the zorro_device_id table)
- use devm_ioremap()
- print the register window with %pR in ata_port_desc()

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/2ata: pata_cswarp: Add Amiga cslab ata supportdrivers/ata/Kconfig drivers/ata/Makefile drivers/ata/pata_cswarp.c+194 -01 reply
2/2m68k: defconfig: enable PATA_CSWARParch/m68k/configs/amiga_defconfig arch/m68k/configs/multi_defconfig+2 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchGeert UytterhoevenDamien Le Moal
1/2R-b
2/2A-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/2] m68k: pata_cswarp: Add Amiga cslab ata support

Here is a driver (and the subsequent defconfig change) for the pata/CF socket in the CS-Lab Warp series of Amiga boards.

This is a respin of v5 addressing Geert's and sashiko-bot's review.

Tested on real Warp hardware.

v5: https://lore.kernel.org/linux-ide/[email protected]/

Changes in v6:
- fix 7.3 FTBFS (include <linux/device-id/zorro.h>, and use named initializers in the zorro_device_id table)
- use devm_ioremap()
- print the register window with %pR in ata_port_desc()

Changes in v5:
- return the number of bytes actually consumed on the bus
- fix the trailing byte in pata_cswarp_data_xfer()
- drop a blank line in Kconfig
- fix the remaining checkpatch complaints

Changes in v4:
- refactor pata_cswarp_data_xfer()
- ioremap WARP_OFFSET_ATA region

Changes in v3:
- suppress a comment
- properly return ata_host_activate() error code

Change in v2:
- fix style, remove duplicate swap macro, driver version, etc
- rework the zorro attach mechanism
- remove the unnecessary zorro ids refactor

Paolo Pisati (2):
ata: pata_cswarp: Add Amiga cslab ata support
m68k: defconfig: enable PATA_CSWARP

 arch/m68k/configs/amiga_defconfig |   1 +
 arch/m68k/configs/multi_defconfig |   1 +
 drivers/ata/Kconfig               |  10 ++
 drivers/ata/Makefile              |   1 +
 drivers/ata/pata_cswarp.c         | 183 ++++++++++++++++++++++++++++++
 5 files changed, 196 insertions(+)
 create mode 100644 drivers/ata/pata_cswarp.c

base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91

Signature · 1 line
2.43.0