lib: tst_test: Clarify the .needs_abi_bit TCONF message
PATCH 1/1 lib: tst_test: Clarify the .needs_abi_bit TCONF message
The previous message was confusing. On 32bit machine sendfile09 tests that has .needs_abi_bits = 64 produced this message:
tst_test.c:1493: TCONF: 64bit ABI is not supported
This message is a bit confusing, since on 32bit x86 machine 64bit ABI is, of course, not supported, so why do we skip the test?
After this patch the message is:
tst_test.c:1493: Test needs 64bit ABI
Which is, as far as I can tell, more clear.
--- lib/tst_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/tst_test.c +1 -1
@@ -1490,7 +1490,7 @@ static void do_setup(int argc, char *argv[])tst_brk (TCONF ,"Not supported in 32-bit compat mode" );if (tst_test->needs_abi_bits && !tst_abi_bits (tst_test->needs_abi_bits)) -tst_brk (TCONF ,"%dbit ABI is not supported" , tst_test->needs_abi_bits); +tst_brk (TCONF ,"Test needs %dbit ABI" , tst_test->needs_abi_bits);if (tst_test->needs_cmds) {struct tst_cmd *pcmd = tst_test->needs_cmds;
Signature · 5 lines
2.54.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Cyril,
Quoted 5 lines
The previous message was confusing. On 32bit machine sendfile09 tests that has .needs_abi_bits = 64 produced this message:
tst_test.c:1493: TCONF: 64bit ABI is not supported
Quoted 8 lines
This message is a bit confusing, since on 32bit x86 machine 64bit ABI is, of course, not supported, so why do we skip the test?
After this patch the message is:
tst_test.c:1493: Test needs 64bit ABI
Which is, as far as I can tell, more clear.
+1, sure, merge before release.
Kind regards,
Petr
Quoted 19 lines
Fixes 56f63e54e5a3 ("lib: Add .needs_abi_bits")Signed-off-by Cyril Hrubis <[email protected]>--- lib/tst_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/tst_test.c +1
-1@@ -1490,7 +1490,7 @@ static void do_setup(int argc, char *argv[])tst_brk (TCONF ,"Not supported in 32-bit compat mode" );if (tst_test->needs_abi_bits && !tst_abi_bits (tst_test->needs_abi_bits)) -tst_brk (TCONF ,"%dbit ABI is not supported" , tst_test->needs_abi_bits); +tst_brk (TCONF ,"Test needs %dbit ABI" , tst_test->needs_abi_bits);if (tst_test->needs_cmds) {struct tst_cmd *pcmd = tst_test->needs_cmds;
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Cyril,
I dared to merge this simple fix.
Thanks!
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Cyril,
Quoted 1 line · Cyril Hrubis
lib:
tst_test: Clarify the .needs_abi_bit TCONF message
Verdict - Reviewed
---
Note:
The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp