Skip to contentSkip to conversation

lib: tst_test: Clarify the .needs_abi_bit TCONF message

PATCH In review Cyril Hrubis 4 participants 5 messages Sep 24 – Sep 25 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: tst_test: Clarify the .needs_abi_bit TCONF message

The previous message was confusing. On 32bit machine sendfile09 tests that has .needs_abi_bits = 64 produced this message:

tst_test.c:1493: TCONF: 64bit ABI is not supported

This message is a bit confusing, since on 32bit x86 machine 64bit ABI is, of course, not supported, so why do we skip the test?

After this patch the message is:

tst_test.c:1493: Test needs 64bit ABI

Which is, as far as I can tell, more clear.

Fixes 56f63e54e5a3 ("lib: Add .needs_abi_bits")
---
 lib/tst_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/tst_test.c +1 -1
index ed3d26cad..e27a24c24 100644
@@ -1490,7 +1490,7 @@ static void do_setup(int argc, char *argv[])
 		tst_brk(TCONF, "Not supported in 32-bit compat mode");
 
 	if (tst_test->needs_abi_bits && !tst_abi_bits(tst_test->needs_abi_bits))
-		tst_brk(TCONF, "%dbit ABI is not supported", tst_test->needs_abi_bits);
+		tst_brk(TCONF, "Test needs %dbit ABI", tst_test->needs_abi_bits);
 
 	if (tst_test->needs_cmds) {
 		struct tst_cmd *pcmd = tst_test->needs_cmds;
Signature · 5 lines
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v1 1/1
#2 lore raw
In reply to Cyril Hrubis

Hi Cyril,

Quoted 5 lines

The previous message was confusing. On 32bit machine sendfile09 tests that has .needs_abi_bits = 64 produced this message:

tst_test.c:1493: TCONF: 64bit ABI is not supported

Quoted 8 lines

This message is a bit confusing, since on 32bit x86 machine 64bit ABI is, of course, not supported, so why do we skip the test?

After this patch the message is:

tst_test.c:1493: Test needs 64bit ABI

Which is, as far as I can tell, more clear.

+1, sure, merge before release.

Kind regards,
Petr

Quoted 19 lines
Fixes 56f63e54e5a3 ("lib: Add .needs_abi_bits")
---
 lib/tst_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/tst_test.c +1 -1
index ed3d26cad..e27a24c24 100644
@@ -1490,7 +1490,7 @@ static void do_setup(int argc, char *argv[])
 		tst_brk(TCONF, "Not supported in 32-bit compat mode");
 
 	if (tst_test->needs_abi_bits && !tst_abi_bits(tst_test->needs_abi_bits))
-		tst_brk(TCONF, "%dbit ABI is not supported", tst_test->needs_abi_bits);
+		tst_brk(TCONF, "Test needs %dbit ABI", tst_test->needs_abi_bits);
 
 	if (tst_test->needs_cmds) {
 		struct tst_cmd *pcmd = tst_test->needs_cmds;
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Hi Cyril,

I dared to merge this simple fix.
Thanks!

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw
In reply to Cyril Hrubis

Hi Cyril,

Quoted 1 line · Cyril Hrubis

lib: tst_test: Clarify the .needs_abi_bit TCONF message

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp