Skip to contentSkip to conversation

Add support for Acer Swift SFA14-11

PATCH Superseded Jianfeng Liu 3 participants 8 messages Sep 22 – Sep 28

Subsystems (3)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

cover Add support for Acer Swift SFA14-11

Add support for Acer Swift SFA14-11, a laptop based on the Qualcomm X1E78100 SoC.

The following hardware has been tested and is working:

- NVMe SSD
- WiFi and Bluetooth (UART)
- USB-A ports
- USB-C port with DP alt mode
- eDP display with PWM backlight
- HDMI (via DP bridge)
- I2C HID keyboard and touchpad
- Audio: speakers, headphone jack, DP alt mode and HDMI
- GPU and video decoding
- Battery charging

Note on the compatible string: There are two names:
- Swift SFA14-11[1]
- SFA14-11[2]
from the support site of acer.com, but the UEFI firmware reports the Product Name as SFA14-11. The compatible string follows the firmware ("acer,sfa14-11"), while the model string uses "Acer Swift SFA14-11" for readability.

[1] https://www.acer.com/au-en/support/product-support/Swift_SFA14-11
[2] https://www.acer.com/au-en/support/product-support/SFA14-11

Jianfeng Liu (3):
dt-bindings: arm: qcom: Add Acer Swift SFA14-11
arm64: dts: qcom: Add Acer Swift SFA14-11
firmware: qcom: scm: Allow QSEECOM on Acer Swift SFA14-11

 .../devicetree/bindings/arm/qcom.yaml         |    1 +
 arch/arm64/boot/dts/qcom/Makefile             |    2 +
 .../boot/dts/qcom/x1e78100-acer-sfa14-11.dts  | 1520 +++++++++++++++++
 drivers/firmware/qcom/qcom_scm.c              |    1 +
 4 files changed, 1524 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts

---
base-commit: 5c4d4169604b335c38bbc79bc1fc03042981fc6f
branch: sfa14-11-next-20260921

Signature · 1 line
2.47.3
#1 lore raw

PATCH 1/3 dt-bindings: arm: qcom: Add Acer Swift SFA14-11

Document the X1E78100-based Acer Swift SFA14-11.

---

 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
index 5c0414d4af9b9..85e62b2c7093f 100644
@@ -1203,6 +1203,7 @@ properties:
 
       - items:
           - enum:
+              - acer,sfa14-11
               - medion,sprchrgd14s1
               - tuxedo,elite14gen1
           - const: qcom,x1e78100
Signature · 1 line
2.47.3
#2 lore raw

Re: [PATCH 1/3] dt-bindings: arm: qcom: Add Acer Swift SFA14-11

Quoted 13 lines · Jianfeng Liu

Document the X1E78100-based Acer Swift SFA14-11.

---

 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +0 -0
index 5c0414d4af9b9..85e62b2c7093f 100644

Documentation/devicetree/bindings/arm/qcom.yaml properties: · line 1206

Quoted 4 lines
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -1203,6 +1203,7 @@ properties:
 
       - items:
           - enum:
+              - acer,sfa14-11

acer,swift-sfa14-11

?

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH 1/3] dt-bindings: arm: qcom: Add Acer Swift SFA14-11

Quoted 5 lines · Krzysztof
Quoted 1 line

+ - acer,sfa14-11

acer,swift-sfa14-11

?

Hi Krzysztof,

As I mentioned in the cover leter, both Swift SFA14-11 and SFA14-11 can be found in www.acer.com, but the UEFI firmware reports the Product Name as SFA14-11, and S in SFA should have the meaning of Swift. If you think acer,swift-sfa14-11 is a better one, I can update a new version with this compatible string.

Best regards,
Jianfeng

#4 lore raw

Re: [PATCH 1/3] dt-bindings: arm: qcom: Add Acer Swift SFA14-11

Quoted 11 lines · Jianfeng Liu
Quoted 5 lines · Krzysztof
Quoted 1 line

+ - acer,sfa14-11

acer,swift-sfa14-11

?

Hi Krzysztof,

As I mentioned in the cover leter, both Swift SFA14-11 and SFA14-11 can be found in www.acer.com, but the UEFI firmware reports the Product Name as

I don't understand. Your commit subject says it is Swift SFA14-11.

Quoted 3 lines

SFA14-11, and S in SFA should have the meaning of Swift. If you think acer,swift-sfa14-11 is a better one, I can update a new version with this compatible string.

I googled and for "acer SFA14-11" I see only "Acer Swift Air 14" names, so that is the name people see everywhere.

Best regards,
Krzysztof

#5 lore raw

PATCH 2/3 arm64: dts: qcom: Add Acer Swift SFA14-11

In reply to Jianfeng Liu

Add support for Acer Swift SFA14-11, a laptop based on the Qualcomm X1E78100 SoC.

The following hardware has been tested and is working:

- NVMe SSD
- WiFi and Bluetooth (UART)
- USB-A ports
- USB-C port with DP alt mode
- eDP display with PWM backlight
- HDMI (via DP bridge)
- I2C HID keyboard and touchpad
- Audio: speakers, headphone jack, DP alt mode and HDMI
- GPU and video decoding
- Battery charging

---

 arch/arm64/boot/dts/qcom/Makefile             |    2 +
 .../boot/dts/qcom/x1e78100-acer-sfa14-11.dts  | 1520 +++++++++++++++++
 2 files changed, 1522 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts
arch/arm64/boot/dts/qcom/Makefile +2 -0
index efd7bc724ee15..8a3d85399e892 100644
@@ -450,6 +450,8 @@ talos-evk-rpi-display-2-5in-dtbs	:= \
 dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk-rpi-display-2-5in.dtb
 x1e001de-devkit-el2-dtbs	:= x1e001de-devkit.dtb x1-el2.dtbo
 dtb-$(CONFIG_ARCH_QCOM)	+= x1e001de-devkit.dtb x1e001de-devkit-el2.dtb
+x1e78100-acer-sfa14-11-el2-dtbs	:= x1e78100-acer-sfa14-11.dtb x1-el2.dtbo
+dtb-$(CONFIG_ARCH_QCOM) += x1e78100-acer-sfa14-11.dtb x1e78100-acer-sfa14-11-el2.dtb
 x1e78100-lenovo-thinkpad-t14s-el2-dtbs	:= x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo
 dtb-$(CONFIG_ARCH_QCOM)	+= x1e78100-lenovo-thinkpad-t14s.dtb x1e78100-lenovo-thinkpad-t14s-el2.dtb
 x1e78100-lenovo-thinkpad-t14s-oled-el2-dtbs	:= x1e78100-lenovo-thinkpad-t14s-oled.dtb x1-el2.dtbo
arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts new file +1520 -0

1,520 lines not on this page · raw message

Signature · 1 line
2.47.3
#6 lore raw

Re: [PATCH 2/3] arm64: dts: qcom: Add Acer Swift SFA14-11

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [High] dts: qcom: missing power-supply for backlight causes display blackout - [High] dts: qcom: swapped…

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] dts: qcom: missing power-supply for backlight causes display blackout
- [High] dts: qcom: swapped QMP PHY regulators risk hardware damage
--

commit 11d3bb0749b2f4ee1528ce4d8e70f906912678bb
Author: Jianfeng Liu <[email protected]>

arm64: dts: qcom: Add Acer Swift SFA14-11

This commit adds device tree support for the Acer Swift SFA14-11 laptop, based on the Qualcomm X1E78100 SoC.

Quoted 4 lines
arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts new file +0 -0
new file mode 100644

[ ... ]

arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts line 62

Quoted 12 lines
arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts new file +12 -0
+	backlight: backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pm8550_pwm 3 500000>;
+		enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
+
+		brightness-levels = <30 255>;
+		num-interpolated-steps = <225>;
+		default-brightness-level = <170>;
+
+		pinctrl-0 = <&edp_bl_en>, <&edp_bl_pwm>;
+		pinctrl-names = "default";
+	};

[Severity: High]
Should power-supply = <&vreg_edp_bl>; be added here to ensure the backlight regulator is claimed and remains enabled?

[ ... ]

Quoted 5 lines
arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts new file +5 -0
+	vreg_edp_bl: regulator-edp-bl {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VBL9";
+		regulator-min-microvolt = <3600000>;

arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts line 317

Quoted 10 lines
arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts new file +10 -0
+		regulator-max-microvolt = <3600000>;
+
+		gpio = <&pmc8380_3_gpios 10 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&edp_bl_reg_en>;
+		pinctrl-names = "default";
+
+		regulator-boot-on;
+	};

[Severity: High]
Does this regulator need an active consumer or regulator-always-on? It is defined with regulator-boot-on, but without any consumers in the device tree (such as the backlight node), the kernel regulator framework will automatically disable it during late init, causing the display to black out.

[ ... ]

arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts line 1428

Quoted 6 lines

+&usb_1_ss0_qmpphy {

arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts new file +5 -0
+	vdda-phy-supply = <&vreg_l2j_1p2>;
+	vdda-pll-supply = <&vreg_l1j_0p8>;
+
+	status = "okay";
+};

[Severity: High]
Are these supplies swapped? It looks like the 1.25V regulator (vreg_l2j_1p2) is mapped to the 0.88V core vdda-phy-supply, and the 0.88V regulator (vreg_l1j_0p8) is mapped to the 1.2V vdda-pll-supply. Over-voltaging the core PHY rail can cause hardware damage, and under-voltaging the PLL rail will cause the PLL to fail to lock.

[ ... ]

arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts line 1447

Quoted 5 lines

+&usb_1_ss2_qmpphy {

arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts new file +4 -0
+	vdda-phy-supply = <&vreg_l2j_1p2>;
+	vdda-pll-supply = <&vreg_l2d_0p9>;
+
+	/delete-property/ mode-switch;

[Severity: High]
Could the vdda-phy-supply and vdda-pll-supply be backwards here as well? The 1.25V regulator (vreg_l2j_1p2) is mapped to the 0.88V core vdda-phy-supply, and the 0.9V regulator (vreg_l2d_0p9) is mapped to the 1.2V vdda-pll-supply.

[ ... ]

arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts line 1513

Quoted 6 lines

+&usb_mp_qmpphy0 {

arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts new file +5 -0
+	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-pll-supply = <&vreg_l3c_0p8>;
+
+	status = "okay";
+};

[Severity: High]
Is this another instance where the supplies are swapped? It looks like the 1.2V regulator (vreg_l3e_1p2) is supplied to the 0.9V core vdda-phy-supply, and the 0.9V regulator (vreg_l3c_0p8) is supplied to the 1.2V vdda-pll-supply.

[ ... ]

arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts line 1513

Quoted 6 lines

+&usb_mp_qmpphy1 {

arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts new file +5 -0
+	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-pll-supply = <&vreg_l3c_0p8>;
+
+	status = "okay";
+};

[Severity: High]
Does this have the same swap issue as usb_mp_qmpphy0? The 1.2V regulator (vreg_l3e_1p2) is mapped to the 0.9V vdda-phy-supply, and the 0.9V regulator (vreg_l3c_0p8) is mapped to the 1.2V vdda-pll-supply.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
#7 lore raw

PATCH 3/3 firmware: qcom: scm: Allow QSEECOM on Acer Swift SFA14-11

In reply to Jianfeng Liu

The Hamoa-based Acer Swift SFA14-11 provides the same UEFI variable access through uefisecapp as other Hamoa devices, add it to the allowlist.

---

 drivers/firmware/qcom/qcom_scm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/firmware/qcom/qcom_scm.c +1 -0
index df20773dd7541..e83814fa7766e 100644
@@ -2215,6 +2215,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send);
  + any potential issues with this, only allow validated machines for now.
  */
 static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
+	{ .compatible = "acer,sfa14-11" },
 	{ .compatible = "asus,vivobook-s15" },
 	{ .compatible = "asus,vivobook-s15-x1p4" },
 	{ .compatible = "asus,zenbook-a14-ux3407na" },
Signature · 1 line
2.47.3