Skip to contentSkip to conversation

Enable Bluetooth and WiFi on K3 Pico ITX

PATCH In review Aurelien Jarno 4 participants 10 messages Sep 28 – Nov 1

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v5 cover Enable Bluetooth and WiFi on K3 Pico ITX

This patchset enables Bluetooth through USB on the K3 Pico ITX board and adds the rfkill nodes for Bluetooth and WLAN so that the devices can be activated.

Note that WLAN support (patch 4) is only useful with the following patchset, but they can be applied independently:
- https://lore.kernel.org/spacemit/[email protected]/T/#t

Changes v4 (unfortunately wrongly submitted as v3) -> v5
- rebase onto spacemit/dt-for-next
- explain in patch1 why the change does not impact the DT schema validation (reported by Sashiko)

Changes v3 -> v4
- fully move the phy definition and the board level
- rebase onto 7.3-rc1

Changes v2 -> v3
- reorder patches in a more logical order
- rebase on current linus/master
- add patch 1 to move phy definition to the board level for the "usb3d" controller
- remove link to USB3 phys, they can't be added if the combo phy is not configured accordingly - also enable Bluetooth and WLAN drivers in defconfig

Changes v1 -> v2
- Rebase on current spacemit/dt-for-next branch
- Collect Tested-by tag
- Add link to USB3 PHYs in DT now that K3 PHY support is merged

Aurelien Jarno (5):
riscv: dts: spacemit: k3: move USB3 phy to board level
riscv: dts: spacemit: k3: add USB3 B and C controllers for Pico-ITX
board
riscv: dts: spacemit: k3: add rfkill node for Bluetooth on Pico-ITX
board
riscv: dts: spacemit: k3: add rfkill node for WLAN on the K3 Pico-ITX
board
riscv64: defconfig: Enable BT and WLAN support for SpacemiT K3
Pico-ITX board

 arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 38 ++++++++++++
 arch/riscv/boot/dts/spacemit/k3.dtsi         | 63 +++++++++++++++++++-
 arch/riscv/configs/defconfig                 |  8 +++
 3 files changed, 106 insertions(+), 3 deletions(-)
Signature · 1 line
2.53.0
#1 lore raw

PATCH v5 1/5 riscv: dts: spacemit: k3: move USB3 phy to board level

On the SpacemiT K3 SoC, the combo phy provides 8 lines that can either be used for PCIe or USB3, depending on its configuration (spacemit,apmu). This configuration is defined at the board level, and assigning a phy line to a USB3 controller while it is configured as PCIe results in an "Invalid PHY mode" error.

Move the USB phy definitions at the board level, as it is done for the submitted PCIe controller [1]. As a consequence, boards that do not enable a USB3 controller node will not match the DT schema due to missing PHY entries. This is not an issue as dtbs_check only validates enabled nodes.

[1] https://lore.kernel.org/spacemit/[email protected]

Fixes 46380e4b1534 ("riscv: dts: spacemit: k3: add USB controller and USB phy support")
Cc Inochi Amaoto <[email protected]>
---
 arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 2 ++
 arch/riscv/boot/dts/spacemit/k3.dtsi         | 3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +2 -0
index b084a35aa00e3..0a6f669d509a9 100644
@@ -328,5 +328,7 @@ &usb3d_u2phy {
 };
 
 &usb3d {
+	phys = <&usb3d_u2phy>, <&combophy 4 PHY_TYPE_USB3>;
+	phy-names = "usb2-phy", "usb3-phy";
 	status = "okay";
 };
arch/riscv/boot/dts/spacemit/k3.dtsi +0 -3
index b9977e78e096a..1af47b7f1c8af 100644
@@ -452,9 +452,6 @@ usb3d: usb@81a00000 {
 				 <&syscon_apmu RESET_APMU_USB3_D_VCC>,
 				 <&syscon_apmu RESET_APMU_USB3_D_PHY>;
 			reset-names = "ahb", "vcc", "phy";
-			phys = <&usb3d_u2phy>,
-			       <&combophy 4 PHY_TYPE_USB3>;
-			phy-names = "usb2-phy", "usb3-phy";
 			phy_type = "utmi";
 			snps,dis_enblslpm_quirk;
 			snps,dis_u2_susphy_quirk;
Signature · 1 line
2.53.0
#2 lore raw

PATCH v5 2/5 riscv: dts: spacemit: k3: add USB3 B and C controllers for Pico-ITX board

In reply to Aurelien Jarno

The SpacemiT K3 has 4 USB3 controllers labelled A to D.

On the K3 Pico-ITX board, the controllers B and C are used in USB2 mode only respectively for the M.2 B-Key slot and for the RTL8852BE Bluetooth controller.

Add the two controller nodes. On the K3 Pico-ITX board, enable the controllers nodes and add the two corresponding USB2 PHY nodes.

---
 arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 22 +++++++
 arch/riscv/boot/dts/spacemit/k3.dtsi         | 60 ++++++++++++++++++++
 2 files changed, 82 insertions(+)
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +22 -0
index 0a6f669d509a9..5aa6fa89cab58 100644
@@ -323,6 +323,28 @@ &usb2_phy {
 	status = "okay";
 };
 
+&usb3b {
+	phys = <&usb3b_u2phy>;
+	phy-names = "usb2-phy";
+	maximum-speed = "high-speed";
+	status = "okay";
+};
+
+&usb3b_u2phy {
+	status = "okay";
+};
+
+&usb3c {
+	phys = <&usb3c_u2phy>;
+	phy-names = "usb2-phy";
+	maximum-speed = "high-speed";
+	status = "okay";
+};
+
+&usb3c_u2phy {
+	status = "okay";
+};
+
 &usb3d_u2phy {
 	status = "okay";
 };
arch/riscv/boot/dts/spacemit/k3.dtsi +60 -0

66 lines not on this page · raw message

Signature · 1 line
2.53.0
#3 lore raw

Re: [PATCH v5 2/5] riscv: dts: spacemit: k3: add USB3 B and C controllers for Pico-ITX board

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: missing required phys properties in usb3b and usb3c nodes --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing required phys properties in usb3b and usb3c nodes --

commit 89b216baa5d6be0e4a7be800d568bba679087495
Author: Aurelien Jarno <[email protected]>

riscv: dts: spacemit: k3: add USB3 B and C controllers for Pico-ITX board

This commit adds the USB3 controller nodes (B and C) to the SpacemiT K3 SoC device tree. It also enables them and adds the corresponding USB2 PHY nodes for the Pico-ITX board.

Quoted 4 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +0 -0
index 1af47b7f1c8af..cf1c8b572c86b 100644

[ ... ]

arch/riscv/boot/dts/spacemit/k3.dtsi soc: soc { · line 447

Quoted 8 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +4 -0
@@ -441,6 +441,66 @@ soc: soc {
 		dma-noncoherent;
 		ranges;
 
+		usb3b: usb@81400000 {
+			compatible = "spacemit,k3-dwc3";
+			reg = <0x0 0x81400000 0x0 0x10000>;
+			interrupts = <125 IRQ_TYPE_LEVEL_HIGH>;

[Severity: Low]
Does omitting the phys and phy-names properties here cause a devicetree validation regression?

The SoC devicetree fails dtbs_check validation against the binding schema (spacemit,k1-dwc3.yaml), which unconditionally requires the phys and phy-names properties.

Should this node define its hardwired connection to usb3b_u2phy via the phys and phy-names properties here, instead of omitting these SoC-internal hardwired connections from k3.dtsi and forcing downstream boards to redundantly define the SoC hardware topology?

Quoted 2 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +2 -0
+			interrupt-parent = <&saplic>;
+			clocks = <&syscon_apmu CLK_APMU_USB3_PORTB_BUS>;

[ ... ]

arch/riscv/boot/dts/spacemit/k3.dtsi soc: soc { · line 477

Quoted 4 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +4 -0
+		usb3c: usb@81700000 {
+			compatible = "spacemit,k3-dwc3";
+			reg = <0x0 0x81700000 0x0 0x10000>;
+			interrupts = <148 IRQ_TYPE_LEVEL_HIGH>;

[Severity: Low]
Similarly, does this node also need to define its hardwired connection to usb3c_u2phy via the phys and phy-names properties to avoid the same schema validation regression?

Quoted 2 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +2 -0
+			interrupt-parent = <&saplic>;
+			clocks = <&syscon_apmu CLK_APMU_USB3_PORTC_BUS>;
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
#4 lore raw

Re: [PATCH v5 2/5] riscv: dts: spacemit: k3: add USB3 B and C controllers for Pico-ITX board

Hi,

Quoted 24 lines · On 2026-09-28 21:02, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing required phys properties in usb3b and usb3c nodes --

commit 89b216baa5d6be0e4a7be800d568bba679087495
Author: Aurelien Jarno <[email protected]>

riscv: dts: spacemit: k3: add USB3 B and C controllers for Pico-ITX board

This commit adds the USB3 controller nodes (B and C) to the SpacemiT K3 SoC device tree. It also enables them and adds the corresponding USB2 PHY nodes for the Pico-ITX board.

Quoted 4 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +0 -0
index 1af47b7f1c8af..cf1c8b572c86b 100644

[ ... ]

Quoted 4 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +0 -0
@@ -441,6 +441,66 @@ soc: soc {
 		dma-noncoherent;
 		ranges;
 
Quoted 8 lines

arch/riscv/boot/dts/spacemit/k3.dtsi soc: soc { · line 447

Quoted 4 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +4 -0
+		usb3b: usb@81400000 {
+			compatible = "spacemit,k3-dwc3";
+			reg = <0x0 0x81400000 0x0 0x10000>;
+			interrupts = <125 IRQ_TYPE_LEVEL_HIGH>;

[Severity: Low]
Does omitting the phys and phy-names properties here cause a devicetree validation regression?

No it doesn't, I checked that before the submitting the patch.

Quoted 3 lines

The SoC devicetree fails dtbs_check validation against the binding schema (spacemit,k1-dwc3.yaml), which unconditionally requires the phys and phy-names properties.

No, as explained in patch 1, dtbs_check only check enabled nodes, so this is fine.

Quoted 7 lines

Should this node define its hardwired connection to usb3b_u2phy via the phys and phy-names properties here, instead of omitting these SoC-internal hardwired connections from k3.dtsi and forcing downstream boards to redundantly define the SoC hardware topology?

arch/riscv/boot/dts/spacemit/k3.dtsi soc: soc { · line 449

Quoted 2 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +2 -0
+			interrupt-parent = <&saplic>;
+			clocks = <&syscon_apmu CLK_APMU_USB3_PORTB_BUS>;

No, this has already been discussed as part of the v3 review:
https://lore.kernel.org/spacemit/[email protected]/

Quoted 12 lines

[ ... ]

arch/riscv/boot/dts/spacemit/k3.dtsi soc: soc { · line 477

Quoted 4 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +4 -0
+		usb3c: usb@81700000 {
+			compatible = "spacemit,k3-dwc3";
+			reg = <0x0 0x81700000 0x0 0x10000>;
+			interrupts = <148 IRQ_TYPE_LEVEL_HIGH>;

[Severity: Low]
Similarly, does this node also need to define its hardwired connection to usb3c_u2phy via the phys and phy-names properties to avoid the same schema validation regression?

Quoted 2 lines

arch/riscv/boot/dts/spacemit/k3.dtsi

Quoted 2 lines
arch/riscv/boot/dts/spacemit/k3.dtsi +2 -0
+			interrupt-parent = <&saplic>;
+			clocks = <&syscon_apmu CLK_APMU_USB3_PORTC_BUS>;

Ditto.

Regards
Aurelien

Signature · 2 lines
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
[email protected]                     http://aurel32.net
#5 lore raw

PATCH v5 3/5 riscv: dts: spacemit: k3: add rfkill node for Bluetooth on Pico-ITX board

In reply to Aurelien Jarno

On the K3 Pico-ITX board, by default the GPIO pin that connects to the RTL8852BE Bluetooth enable signal is driven low, resulting in impossibility to use Bluetooth. Add a DT node to expose it as an RFKILL device, which lets the Bluetooth driver or userspace toggle it as required.

---
 arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 7 +++++++
 1 file changed, 7 insertions(+)
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +7 -0
index 5aa6fa89cab58..d3f256dffb4fd 100644
@@ -43,6 +43,13 @@ reg_aux_vcc5v: regulator-aux-vcc5v {
 		regulator-max-microvolt = <5000000>;
 		regulator-always-on;
 	};
+
+	rfkill-usb-bt {
+		compatible = "rfkill-gpio";
+		label = "rfkill-usb-bt";
+		radio-type = "bluetooth";
+		shutdown-gpios = <&gpio 0 30 GPIO_ACTIVE_HIGH>;
+	};
 };
 
 &i2c2 {
Signature · 1 line
2.53.0
#6 lore raw

PATCH v5 4/5 riscv: dts: spacemit: k3: add rfkill node for WLAN on the K3 Pico-ITX board

In reply to Aurelien Jarno

On the K3 Pico-ITX board, by default the GPIO pin that connects to the RTL8852BE WLAN enable signal is driven low, resulting in impossibility to connect to any network. Add a DT node to expose it as an RFKILL device, which lets the WLAN driver or userspace toggle it as required.

---
 arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 7 +++++++
 1 file changed, 7 insertions(+)
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +7 -0
index d3f256dffb4fd..dda420900aa2c 100644
@@ -44,6 +44,13 @@ reg_aux_vcc5v: regulator-aux-vcc5v {
 		regulator-always-on;
 	};
 
+	rfkill-pcie-wlan {
+		compatible = "rfkill-gpio";
+		label = "rfkill-pcie-wlan";
+		radio-type = "wlan";
+		shutdown-gpios = <&gpio 1 3 GPIO_ACTIVE_HIGH>;
+	};
+
 	rfkill-usb-bt {
 		compatible = "rfkill-gpio";
 		label = "rfkill-usb-bt";
Signature · 1 line
2.53.0
#7 lore raw

PATCH v5 5/5 riscv64: defconfig: Enable BT and WLAN support for SpacemiT K3 Pico-ITX board

In reply to Aurelien Jarno

The SpacemiT K3 Pico-ITX board has a RTL8852BE Bluetooth and WLAN controller connected through PCIe and USB. For the WLAN part, enable CFG80211, MAC80211, RTW89 and RTW89_8852BE as modules. For the Bluetooth, enable CONFIG_BT and CONFIG_BT_HCIBTUSB as modules.

Both also require RFKILL and RFKILL_GPIO.

---
 arch/riscv/configs/defconfig | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/riscv/configs/defconfig +8 -0
index 04ae305d5511b..1bc79ba2ee649 100644
@@ -100,6 +100,12 @@ CONFIG_NET_CLS_CGROUP=m
 CONFIG_NETLINK_DIAG=y
 CONFIG_CGROUP_NET_PRIO=y
 CONFIG_CAN=m
+CONFIG_BT=m
+CONFIG_BT_HCIBTUSB=m
+CONFIG_CFG80211=m
+CONFIG_MAC80211=m
+CONFIG_RFKILL=m
+CONFIG_RFKILL_GPIO=m
 CONFIG_NET_9P=y
 CONFIG_NET_9P_VIRTIO=y
 CONFIG_PCI=y
@@ -143,6 +149,8 @@ CONFIG_DWMAC_THEAD=m
 CONFIG_MICREL_PHY=y
 CONFIG_MICROSEMI_PHY=y
 CONFIG_MOTORCOMM_PHY=y
+CONFIG_RTW89=m
+CONFIG_RTW89_8852BE=m
 CONFIG_INPUT_MOUSEDEV=y
 CONFIG_INPUT_EVDEV=y
 CONFIG_KEYBOARD_GPIO=y
Signature · 1 line
2.53.0
maintainer Reviewed-by on the v5 series
#8 lore raw
In reply to Aurelien Jarno

Hi Aurelien,

Quoted 6 lines · Aurelien Jarno

This patchset enables Bluetooth through USB on the K3 Pico ITX board and adds the rfkill nodes for Bluetooth and WLAN so that the devices can be activated.

Note that WLAN support (patch 4) is only useful with the following patchset, but they can be applied independently:

I will just take this patch, as it doesn't cause any trouble

For the series

Signature · 1 line
Yixun Lan (dlan)
#9 lore raw
In reply to Aurelien Jarno
This series was applied to riscv/linux.git (fixes) by Yixun Lan <[email protected]>:

Hello:

This series was applied to riscv/linux.git (fixes) by Yixun Lan <[email protected]>:

Quoted 9 lines · On Mon, 28 Sep 2026 22:49:05 +0200 you wrote:

This patchset enables Bluetooth through USB on the K3 Pico ITX board and adds the rfkill nodes for Bluetooth and WLAN so that the devices can be activated.

Note that WLAN support (patch 4) is only useful with the following patchset, but they can be applied independently:
- https://lore.kernel.org/spacemit/[email protected]/T/#t

[...]

Here is the summary with links:
- [v5,1/5] riscv: dts: spacemit: k3: move USB3 phy to board level

    https://git.kernel.org/riscv/c/a87ca1e5b5d2
  - [v5,2/5] riscv: dts: spacemit: k3: add USB3 B and C controllers for Pico-ITX board
    https://git.kernel.org/riscv/c/2b9612eceb96
  - [v5,3/5] riscv: dts: spacemit: k3: add rfkill node for Bluetooth on Pico-ITX board
    https://git.kernel.org/riscv/c/ea5cef6d5f3b
  - [v5,4/5] riscv: dts: spacemit: k3: add rfkill node for WLAN on the K3 Pico-ITX board
    https://git.kernel.org/riscv/c/2f3b7240a4c2

- [v5,5/5] riscv64: defconfig: Enable BT and WLAN support for SpacemiT K3 Pico-ITX board (no matching commit)

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html