Skip to contentSkip to conversation

gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print

PATCH Applied John Hubbard 2 participants 5 messages Sep 29 – Sep 30

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print

This is a high value thing to print, because it acts as kind of a bookend, showing the beginning of trying to boot up.

Cc Danilo Krummrich <[email protected]>
Fixes 658c5f0042e6 ("gpu: nova-core: use a single try_pin_init!() block in probe()")"

---

Changes in v2: moved the print statement outside of try_pin_init!().

 drivers/gpu/nova-core/driver.rs | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/nova-core/driver.rs +2 -0
index 291a047e4d86..623d59dcde6e 100644
@@ -100,6 +100,8 @@ fn probe<'bound>(
         pdev: &'bound pci::Device<Core<'_>>,
         _info: Option<&'bound Self::IdInfo>,
     ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {
+        dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");
+
         try_pin_init!(NovaCore {
             _: {
                 pdev.enable_device_mem()?;

base-commit: 658c5f0042e6e897338dd04330a363aa7022c85d

Signature · 1 line
2.55.0
#1 lore raw
Quoted 5 lines · John Hubbard

This is a high value thing to print, because it acts as kind of a bookend, showing the beginning of trying to boot up.

Cc Danilo Krummrich <[email protected]>
Fixes 658c5f0042e6 ("gpu: nova-core: use a single try_pin_init!() block in probe()")"

There is a trailing " at the end of that Fixes line. Even though I ran checkpatch.pl on both of these patch versions, it didn't flag it.

Quoted 23 lines

---

Changes in v2: moved the print statement outside of try_pin_init!().

 drivers/gpu/nova-core/driver.rs | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/nova-core/driver.rs +2 -0
index 291a047e4d86..623d59dcde6e 100644
@@ -100,6 +100,8 @@ fn probe<'bound>(
         pdev: &'bound pci::Device<Core<'_>>,
         _info: Option<&'bound Self::IdInfo>,
     ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {
+        dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");
+
         try_pin_init!(NovaCore {
             _: {
                 pdev.enable_device_mem()?;
Quoted 1 line

base-commit: 658c5f0042e6e897338dd04330a363aa7022c85d

thanks,

Signature · 1 line
John Hubbard
maintainer
#2 lore raw
Quoted 3 lines · John Hubbard

There is a trailing " at the end of that Fixes line. Even though I ran checkpatch.pl on both of these patch versions, it didn't flag it.

Thanks, I can drop it then. (Though, I'm not sure this should have a Fixes: tag in the first place.)

#3 lore raw
Quoted 7 lines · Danilo Krummrich
Quoted 3 lines · John Hubbard

There is a trailing " at the end of that Fixes line. Even though I ran checkpatch.pl on both of these patch versions, it didn't flag it.

Thanks, I can drop it then. (Though, I'm not sure this should have a Fixes: tag in the first place.)

We can just omit the entire Fixes line, yes. It's not fixing a bug or anything, that's true.

thanks,

Signature · 1 line
John Hubbard
maintainer Applied
#4 lore raw
In reply to John Hubbard
Quoted 1 line · John Hubbard

[PATCH v2] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print

Applied, thanks!

Branch: drm-rust-next
Tree: https://gitlab.freedesktop.org/drm/rust/kernel.git

[1/1] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print

      commit: c9ca2e379463

The patch will appear in the next linux-next integration (typically within 24 hours on weekdays).

The patch is queued up for the upcoming merge window for the next major kernel release.