gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print
Subsystems (4)
PATCH 1/1 gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print
This is a high value thing to print, because it acts as kind of a bookend, showing the beginning of trying to boot up.
--- drivers/gpu/nova-core/driver.rs | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/nova-core/driver.rs +2 -0
@@ -102,6 +102,8 @@ fn probe<'bound>( ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {try_pin_init! (NovaCore { _: { +dev_dbg! (pdev,"Probe Nova Core GPU driver.\n" ); + pdev.enable_device_mem ()?; pdev.set_master (); },
base-commit: 658c5f0042e6e897338dd04330a363aa7022c85d
Signature · 1 line
2.55.0
Danilo Krummrich
maintainerQuoted 15 lines · John Hubbard
This is a high value thing to print, because it acts as kind of a bookend, showing the beginning of trying to boot up.
Cc Danilo Krummrich <[email protected]>Fixes 658c5f0042e6 ("gpu: nova-core: use a single try_pin_init!() block in probe()")"Signed-off-by John Hubbard <[email protected]>--- drivers/gpu/nova-core/driver.rs | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/nova-core/driver.rs +0
-0
drivers/gpu/nova-core/driver.rs fn probe<'bound>( · line 105
Quoted 4 lines
drivers/gpu/nova-core/driver.rs +1
-0@@ -102,6 +102,8 @@ fn probe<'bound>( ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {try_pin_init! (NovaCore { _: { +dev_dbg! (pdev,"Probe Nova Core GPU driver.\n" );
I'd like to keep it outside of this block, as it will transform into a field storing a pci::DeviceEnableGuard soon.
Let's put it in its own _: {} block or before try_pin_init!().
Quoted 8 lines
drivers/gpu/nova-core/driver.rs +1
-0+ pdev.enable_device_mem ()?; pdev.set_master (); },base-commit:
658c5f0042e6e897338dd04330a363aa7022c85dSignature · 1 line
2.55.0
Quoted 25 lines · Danilo Krummrich
Quoted 15 lines · John Hubbard
This is a high value thing to print, because it acts as kind of a bookend, showing the beginning of trying to boot up.
Cc Danilo Krummrich <[email protected]>Fixes 658c5f0042e6 ("gpu: nova-core: use a single try_pin_init!() block in probe()")"Signed-off-by John Hubbard <[email protected]>--- drivers/gpu/nova-core/driver.rs | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/nova-core/driver.rs +0
-0drivers/gpu/nova-core/driver.rs fn probe<'bound>( · line 105
Quoted 4 lines
drivers/gpu/nova-core/driver.rs +1
-0@@ -102,6 +102,8 @@ fn probe<'bound>( ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {try_pin_init! (NovaCore { _: { +dev_dbg! (pdev,"Probe Nova Core GPU driver.\n" );I'd like to keep it outside of this block, as it will transform into a field storing a
pci::DeviceEnableGuardsoon.
Quoted 1 line
Let's put it in its own _: {} block or before try_pin_init!().
OK, will do.
Quoted 10 lines
Quoted 9 lines
drivers/gpu/nova-core/driver.rs +1
-0+ pdev.enable_device_mem ()?; pdev.set_master (); },base-commit:
658c5f0042e6e897338dd04330a363aa7022c85dSignature · 1 line
2.55.0
thanks,
Signature · 1 line
John Hubbard